New issue
Advanced search Search tips

Issue 730026 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 655820



Sign in to add a comment

merge project-freon overlay into the main overlay

Project Member Reported by jorgelo@chromium.org, Jun 6 2017

Issue description

Freon is used everywhere now.
 

Comment 1 Deleted

Status: WontFix (was: Untriaged)
This is kinda moot now. The only remaining diff here is what users belong to what groups, and we cannot really unify that as long as we have some xorg users (like lakitu).
Components: Infra>Client>ChromeOS>Build
Labels: -Pri-2 -Hotlist-Recharge-Cold -M-61 Hotlist-GoodFirstBug Pri-3
Status: Available (was: WontFix)
i think we still want to do this if only to cut out the need to say "freon" everywhere.  it confuses people.
The *user* baseline has been unified already. The only difference is that certain groups have different members on freon/non-freon.

So, if the suggestion is to make Freon the "default" and then overriding those groups in the test with the X11 baseline, that would probably be fine.
Summary: merge project-freon overlay into the main overlay (was: Merge Freon users into the main overlay)
i mean project-freon/ shouldn't exist at all.  the fact that it does requires people to type "freon" in a lot of places now.

when i saw "users" i wasn't thinking "unix accounts".  lemme relabel to clarify.
Ah gotcha, that does make a lot of sense.
Owner: saklein@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
I am confused how this is meant to be achieved without losing some of the configs. 

As I'm understanding overlay inheritance, if this is merged directly into the chromiumos base profile, the package.use and make.defaults would be applied to every board, and the group configs would be lost due to be overwritten by the eclass-overlay. This seems like kind of the worst case, because they'd each have part of what they originally had, but neither would be quite right.


I think the closest option I've come up with is to basically make a chromiumos freon profile that the freon boards use. That could easily replace the existing chromiumos parents by just extending the existing hierarchies to include a freon layer on top of the parent profiles they currently use. The parents files never list eclass-overlay as far as I have seen, so there's no inheritance chain to follow there, but the layout.conf masters lists are all "... chromiumos eclass-overlay ...". 

How would the inheritance work in this case? Would the eclass-overlay group configs still overwrite the profile group configs? i.e. do the project-freon group config overrides work only because freon is listed after eclass-overlay in the masters list in each freon-based board's layout.conf?

I believe the group config overwriting could be addressed by just having the non-freon based group configs in the base profile, so the freon profile usage would overwrite the base. I sort of feel like splitting out the group configs from the eclass-overlay like that is getting to be kind of messy, though, so perhaps an eclass-overlay profile would be more appropriate? If so, where would be the preferred inheritance point for it - chromiumos profiles or in the boards?

I also feel like all of this is approaching a somewhat higher level of complexity than was implied by the short conversation above, is there something simpler for putting this all together that I missed?
you are correct that we lose the ability to support X builds directly anymore.  that's OK -- we've already dropped the X server and have no plans to bring it back.  there's also no reason to when people can use Wayland/Weston/XWayland to provide backwards compat for X projects.

that means that the input/tty/video groups that exist in eclass-overlay/ are unused.  so replacing them with the accounts that exist in the freon overlay is what we want.

similarly for merging project-freon/profiles/{packages.use,make.defaults} into chromiumos-overlay/profiles/targets/chromeos/ ... we clobber/change some settings in there, but that's fine because the non-freon builds aren't tested or supported anymore.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/7da8df3fea72dd09eafb41ae41c0973f9a146076

commit 7da8df3fea72dd09eafb41ae41c0973f9a146076
Author: Alex Klein <saklein@chromium.org>
Date: Fri Aug 10 05:04:12 2018

Merged project-freon into the main overlay.

It is no longer necessary to maintain project-freon as a separate
entity from the main overlay, so it is being merged into the defaults.

BUG= chromium:730026 
TEST=trybot, precq passes
CQ-DEPEND=CL:1165329, CL:1169906

Change-Id: I665c041208547d1ef68fe39b968de57eedfbb71d
Reviewed-on: https://chromium-review.googlesource.com/1165943
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7da8df3fea72dd09eafb41ae41c0973f9a146076/profiles/base/accounts/group/tty
[modify] https://crrev.com/7da8df3fea72dd09eafb41ae41c0973f9a146076/profiles/base/accounts/group/video
[modify] https://crrev.com/7da8df3fea72dd09eafb41ae41c0973f9a146076/profiles/base/accounts/group/input

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3e655b0ac271f1add5830b990b6138e23743dfa8

commit 3e655b0ac271f1add5830b990b6138e23743dfa8
Author: Alex Klein <saklein@chromium.org>
Date: Fri Aug 10 05:04:11 2018

Update expected users/groups to reflect freon values.

It is no longer necessary to maintain project-freon as a separate
entity from the main overlay, so it is being merged into the defaults.

BUG= chromium:730026 
TEST=trybot, precq passes
CQ-DEPEND=CL:1165329, CL:1165943

Change-Id: If3a86bc9966cc80103d05d32747ccb58af51d8cd
Reviewed-on: https://chromium-review.googlesource.com/1169906
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3e655b0ac271f1add5830b990b6138e23743dfa8/cros/test/usergroup_baseline.py
[modify] https://crrev.com/3e655b0ac271f1add5830b990b6138e23743dfa8/cros/test/image_test.py

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/adcaf28e2979db6795b4a5f10fd274272431dd78

commit adcaf28e2979db6795b4a5f10fd274272431dd78
Author: Alex Klein <saklein@chromium.org>
Date: Fri Aug 10 05:04:12 2018

Merged project-freon into the main overlay.

It is no longer necessary to maintain project-freon as a separate
entity from the main overlay, so it is being merged into the defaults.

BUG= chromium:730026 
TEST=trybot, precq passes
CQ-DEPEND=CL:1165943, CL:1169906

Change-Id: Ifee853d90320ea9a65817892ef31a0425cee19a9
Reviewed-on: https://chromium-review.googlesource.com/1165329
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/adcaf28e2979db6795b4a5f10fd274272431dd78/profiles/targets/chromeos/make.defaults
[modify] https://crrev.com/adcaf28e2979db6795b4a5f10fd274272431dd78/profiles/targets/chromeos/package.use

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 32 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 34 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 35 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1fc6dfac155270153df22a791e1076cc6269ef89

commit 1fc6dfac155270153df22a791e1076cc6269ef89
Author: Alex Klein <saklein@chromium.org>
Date: Tue Aug 14 23:06:08 2018

Explicitly disable X11.

It is no longer necessary to maintain project-freon as a separate
entity from the main overlay, so it is being merged into the defaults.
This commit re-adds the freon setting that explicitly disables X11.
The disable was previously removed along with the USE enabling X11,
but that is not sufficient, it needs to be explicitly disabled.

BUG= chromium:730026 
TEST=local builds, precq passes

Change-Id: Ice300a3e3896548d98daf917022d207537b3ab31
Reviewed-on: https://chromium-review.googlesource.com/1173411
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1fc6dfac155270153df22a791e1076cc6269ef89/profiles/targets/chromeos/make.defaults

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 14

Project Member

Comment 39 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/1f470e636438accb5537cb24de740f24ee64aad2

commit 1f470e636438accb5537cb24de740f24ee64aad2
Author: Alex Klein <saklein@chromium.org>
Date: Wed Aug 15 19:54:53 2018

Removed project-freon master and parent references.

It is no longer necessary to maintain project-freon as a separate
entity from the main overlay, so it is being merged into the defaults.
This commit removes instances of freon being referenced as a master
or parent of an overlay.

BUG= chromium:730026 
TEST=precq passes
CQ-DEPEND=CL:1165329, CL:1165943, CL:1173411

Change-Id: Ib0f815c3555f299083697c5adb600670069a1e8f
Reviewed-on: https://chromium-review.googlesource.com/1165961
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-jadeite/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-umaro/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-atlas/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-nefario/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-fizz-moblab/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-pbody/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-dragonegg/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-panther/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-x86-generic/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-gandof/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-octopus/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-stumpy/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-elm/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-clapper/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kip/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-poppy/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-ultima/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-parrot/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-parrot/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-dragonegg/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-ninja/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-oak/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-oak/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-mccloud/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-octopus/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-poppy/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-x86-mario/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-lars/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-x86-zgb/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-arm64-generic/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kefka/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kidd/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-gru/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-wolf/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-bob/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-winky/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-peppy/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-edgar/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-banjo/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-setzer/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-candy/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-glados/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-meowth/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-banon/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-lulu/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-cave/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-sand/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-zako/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-celes/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-samus/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-tricky/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-butterfly/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-peppy/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-rainier/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-zako/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-wolf/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-eve/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-rambi/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-guado/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-pyro/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-sand/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-rambi/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kukui/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-nautilus/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kip/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-reks/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-gnawty/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-tricky/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-monroe/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-swanky/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-gandof/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-sumo/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-gru/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-banon/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-reef/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-samus/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-veyron/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-fizz/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-ultima/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-x86-alex/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-snappy/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-ninja/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-nocturne/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-panther/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-cheza/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-pyro/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-variant-parrot-ivb/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-foster/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-jadeite/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-hana/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-arm-generic/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-terra/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-heli/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-leon/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-snappy/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-banjo/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-fizz-moblab/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-link/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-foster/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-rikku/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-nyan/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-glimmer/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-hana/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-asuka/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-setzer/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-reef/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-reks/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-butterfly/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-swanky/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-arm64-llvmpipe/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-enguarde/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-sumo/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-stout/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-amd64-generic/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-soraka/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-coral/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-winky/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-arm-generic/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-quawks/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-cyan/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-arm64-llvmpipe/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-celes/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-enguarde/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-grunt/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-buddy/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-rikku/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-x86-zgb/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-glimmer/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-amd64-generic/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-x32-generic/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-caroline/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-falco/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-grunt/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-auron/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-cave/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-glados/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-nyan/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-asuka/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-rainier/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-candy/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kukui/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-coral/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-terra/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-meowth/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-gnawty/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-mccloud/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-falco/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kevin/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-pbody/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-orco/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-cheza/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-wizpig/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-daisy/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-auron/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-stout/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-jecht/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kidd/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-veyron/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-nautilus/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kevin/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-wizpig/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-expresso/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-rammus/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-nami/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-jecht/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-soraka/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-x86-alex/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-stumpy/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-elm/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-lars/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-sentry/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-leon/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-amenia/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-daisy/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-x86-generic/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-atlas/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-heli/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-nami/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-chell/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-tidus/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kunimitsu/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-quawks/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-buddy/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-x86-mario/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-amenia/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-chell/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-expresso/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-cyan/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-nefario/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-umaro/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-scarlet/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-relm/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-tidus/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-nocturne/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-clapper/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-bob/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-zoombini/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-variant-parrot-ivb/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-squawks/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-lumpy/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-scarlet/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kefka/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-eve/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-guado/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-lulu/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-relm/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-link/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-peach/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-rammus/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-zoombini/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-monroe/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-lumpy/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-peach/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-sentry/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-edgar/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-squawks/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-orco/profiles/base/parent
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-fizz/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-x32-generic/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-kunimitsu/metadata/layout.conf
[modify] https://crrev.com/1f470e636438accb5537cb24de740f24ee64aad2/overlay-caroline/profiles/base/parent

Blocking: 655820
Project Member

Comment 41 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/fb881a19c1dd83cd8581714926927acc602d0de0

commit fb881a19c1dd83cd8581714926927acc602d0de0
Author: Alex Klein <saklein@chromium.org>
Date: Thu Aug 23 06:25:17 2018

Removed project-freon.

It is no longer necessary to maintain project-freon as a separate
entity from the main overlay, so it is being merged into the defaults.
This commit removes project freon itself.

BUG= chromium:730026 
TEST=precq passes
CQ-DEPEND=CL:1165961, CL:*660361, CL:*660360, CL:*660359, CL:*660358
CQ-DEPEND=CL:*660357, CL:*660356, CL:*660355, CL:*660354, CL:*660353
CQ-DEPEND=CL:*660352, CL:*660351, CL:*660350, CL:*660349, CL:*660348
CQ-DEPEND=CL:*660347, CL:*660346, CL:*660345, CL:*660344, CL:*660343
CQ-DEPEND=CL:*660342, CL:*660341, CL:*660339, CL:*660338

Change-Id: I5271547768eba3f0d73144ee0f9e3e7531570810
Reviewed-on: https://chromium-review.googlesource.com/1166186
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/0756b231a8d0389dd28f13c812a225753bc02829/project-freon/profiles/base/accounts/group/input
[delete] https://crrev.com/0756b231a8d0389dd28f13c812a225753bc02829/project-freon/profiles/base/arm/parent
[delete] https://crrev.com/0756b231a8d0389dd28f13c812a225753bc02829/project-freon/profiles/base/amd64/parent
[delete] https://crrev.com/0756b231a8d0389dd28f13c812a225753bc02829/project-freon/profiles/base/accounts/group/tty
[delete] https://crrev.com/0756b231a8d0389dd28f13c812a225753bc02829/project-freon/metadata/layout.conf
[delete] https://crrev.com/0756b231a8d0389dd28f13c812a225753bc02829/project-freon/profiles/base/package.use
[delete] https://crrev.com/0756b231a8d0389dd28f13c812a225753bc02829/project-freon/profiles/base/make.defaults
[delete] https://crrev.com/0756b231a8d0389dd28f13c812a225753bc02829/project-freon/profiles/base/accounts/group/video
[delete] https://crrev.com/0756b231a8d0389dd28f13c812a225753bc02829/project-freon/profiles/base/x86/parent

Status: Fixed (was: Started)
Project Member

Comment 43 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/7d264ab8a1039741664d574ca60f86a6e58960c1

commit 7d264ab8a1039741664d574ca60f86a6e58960c1
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Aug 24 15:59:52 2018

Project Member

Comment 44 by bugdroid1@chromium.org, Aug 25

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/crostools/+/17c361da7d4ccb7acae82549a036fa2e6604dca7

commit 17c361da7d4ccb7acae82549a036fa2e6604dca7
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Aug 25 05:16:54 2018

Project Member

Comment 45 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1a8af275e9a522e26e29d567f7d59fea666ab931

commit 1a8af275e9a522e26e29d567f7d59fea666ab931
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 28 13:40:23 2018

chromeos-bmpblk: scrub freon references

We don't build/care about these anymore.  Punt the references.

BUG= chromium:730026 
TEST=precq passes

Change-Id: Ibaf8dc4b66bb6177ec26b6e49ad2c0d5aa5bdcb9
Reviewed-on: https://chromium-review.googlesource.com/1187393
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

[modify] https://crrev.com/1a8af275e9a522e26e29d567f7d59fea666ab931/sys-boot/chromeos-bmpblk/chromeos-bmpblk-9999.ebuild

Project Member

Comment 47 by bugdroid1@chromium.org, Aug 29

Sign in to add a comment