New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730025 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Bad localisation in chrome://settings

Project Member Reported by jif@chromium.org, Jun 6 2017

Issue description

Chrome Version: M59-M61
OS: macOS 10.12 (maybe all)

What steps will reproduce the problem?
(1) Set the OS' language to french
(2) open chrome://settings on a profile that does not have any theme

What is the expected result?

"Ouvrez le Chrome Webstore"

What happens instead?

"Ouvrez le Chrome Web Store"
 
bad localisation.png
74.9 KB View Download
Cc: scottchen@chromium.org dschuyler@chromium.org
Labels: -Pri-3 Proj-MaterialDesign-WebUI Pri-2
Owner: dschuyler@chromium.org
I'll take this Dan (let me know if you really wanted it).
Status: Started (was: Assigned)

Comment 5 by dbeam@chromium.org, Jun 7 2017

Labels: OS-Chrome OS-Linux OS-Windows

Comment 6 by dbeam@chromium.org, Jun 7 2017

Labels: -Pri-2 M-60 Pri-1
this is happening on stable as well :(
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5aa99d9d101379b1542958a71df3f50913f1ea2

commit e5aa99d9d101379b1542958a71df3f50913f1ea2
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Jun 07 19:41:55 2017

[MD settings] allow unicode nbsp in i18n behavior strings

This CL allows for the unicode non-breaking space '\u00a0' to appear in
translations. Such spaces appear in the French translation file 1600+
times, for example.

BUG= 730025 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2926573003
Cr-Commit-Position: refs/heads/master@{#477729}

[modify] https://crrev.com/e5aa99d9d101379b1542958a71df3f50913f1ea2/chrome/test/data/webui/i18n_behavior_test.html
[modify] https://crrev.com/e5aa99d9d101379b1542958a71df3f50913f1ea2/ui/webui/resources/js/i18n_behavior.js

Labels: Merge-Request-60
Status: Fixed (was: Started)
Labels: Merge-Request-59
Project Member

Comment 11 by sheriffbot@chromium.org, Jun 8 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks for the quick fix - have you confirmed the fix in canary? Is this a fairly safe merge overall?
Labels: ReleaseBlock-Stable
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 8 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Feedback
Tested the issue on Mac 10.12.5 using chrome dev version #61.0.3124.4 and on Win-10 using chrome dev version #61.0.3124.10 as per comment #0. 
Observed that in both OS-Mac and OS-Win, "Ouvrez le Chrome Webstore" appeared as expected in chrome://settings.

Note: Testing in Ubuntu 14.04, was not feasible as the issue need to be tested on a profile that does not have any theme, whereas in this particular OS by default classic or GTK theme is present in any profile as in the attached screenshot.

Attached screen shots for reference.

dschuyler@ - Could you please confirm if the issue is related to OS-Linux also.

Thanks...!!

localization.png
455 KB View Download
screenshot@Linux.png
96.5 KB View Download
Cc: krajshree@chromium.org
As a heads-up. I'm working on a replacement CL for this issue. The fix above didn't 100% fix it (as described in  Issue 731289 ): The above fix only replaced the *first* nbsp in the string. The new CL is almost the same fix, but addresses *all* nbsp in the string.
re #15, The string shown in the bug description is not used on Linux (The use of the string is in an 'if' that tests to be sure the code is not running on Linux prior to using the string - so that's fairly solid). I'm not currently aware of a French string on Linux that is dynamic and contains a nbsp (non-dynamic strings, which are most of the UI strings, don't have an issue with embedded nbsp).

On ChromeOS, we've found that the nbsp can appear in the theme setting (as mentioned in this bug already); and in the Display Settings where it shows the resolution of the screen (e.g. 1024&nbsp;x&nbsp;768). This is also the reason for the update fix (which should be available shortly).
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fc3b248c69ca7c5d02ee21616cab2211f1a301f

commit 1fc3b248c69ca7c5d02ee21616cab2211f1a301f
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Jun 09 19:23:11 2017

[MD settings] use regex to replace all nbsp

This CL allows for the unicode non-breaking space '\u00a0' to appear in
translations. This is an improvement (replacement) on CL 2926573003
which only replace the first occurrence. This CL will replace all of the
nbsp in the string.

BUG= 730025 ,  730025 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2930833004
Cr-Commit-Position: refs/heads/master@{#478368}

[modify] https://crrev.com/1fc3b248c69ca7c5d02ee21616cab2211f1a301f/chrome/test/data/webui/i18n_behavior_test.html
[modify] https://crrev.com/1fc3b248c69ca7c5d02ee21616cab2211f1a301f/ui/webui/resources/js/i18n_behavior.js

The CL in comment #19 is corrected fix.

Labels: -Merge-Approved-60 Merge-Request-60
I've re-added the Merge-Request-60 and removed the Merge-Approved-60 for the purpose of asking for approval on comment #19 above.
Thanks for the quick fix. Please let us know when the corrected fix (#19) is tested and verified in canary/dev. We are aiming for an M59 re-spin on Monday 6/12 and since this is marked as releaseblock-stable, we'll need to get the fix merged before Sunday 5PM pacific to make it in release candidate.
It's been tested from top-of-tree on a developer build. I'm having some difficulty building a local m-59 branch to verify (in general, not specific to this issue).
Keen. I've been able to build m-59 locally and see: the original issue, the partial fix from CL at #7, and the full fix from CL at #19.
Thanks for checking/verifying - please confirm if this a safe merge overall? 
Cc: dbeam@chromium.org

Comment 27 by dbeam@chromium.org, Jun 10 2017

i say there's basically no risk of merging Dave's CL to M59
Labels: -Merge-Review-59 Merge-Approved-59
thanks - approving merge to M59. 
Project Member

Comment 29 by sheriffbot@chromium.org, Jun 10 2017

Labels: -Merge-Request-60 Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 10 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c5f173446ab77c153266e73357f4914d080fe96

commit 4c5f173446ab77c153266e73357f4914d080fe96
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Jun 10 21:17:05 2017

[MD settings] allow unicode nbsp in i18n behavior strings

This CL allows for the unicode non-breaking space '\u00a0' to appear in
translations. Such spaces appear in the French translation file 1600+
times, for example.

BUG= 730025 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2926573003
Cr-Original-Commit-Position: refs/heads/master@{#477729}
Review-Url: https://codereview.chromium.org/2929333002 .
Cr-Commit-Position: refs/branch-heads/3071@{#771}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/4c5f173446ab77c153266e73357f4914d080fe96/chrome/test/data/webui/i18n_behavior_test.html
[modify] https://crrev.com/4c5f173446ab77c153266e73357f4914d080fe96/ui/webui/resources/js/i18n_behavior.js

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/447dbac62b00c118cfde6d5a8dcf84804830852e

commit 447dbac62b00c118cfde6d5a8dcf84804830852e
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Jun 10 21:19:36 2017

[MD settings] use regex to replace all nbsp

This CL allows for the unicode non-breaking space '\u00a0' to appear in
translations. This is an improvement (replacement) on CL 2926573003
which only replace the first occurrence. This CL will replace all of the
nbsp in the string.

BUG= 730025 ,  730025 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2930833004
Cr-Original-Commit-Position: refs/heads/master@{#478368}
Review-Url: https://codereview.chromium.org/2932973002 .
Cr-Commit-Position: refs/branch-heads/3071@{#772}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/447dbac62b00c118cfde6d5a8dcf84804830852e/chrome/test/data/webui/i18n_behavior_test.html
[modify] https://crrev.com/447dbac62b00c118cfde6d5a8dcf84804830852e/ui/webui/resources/js/i18n_behavior.js

Labels: -Merge-Review-60 Merge-Approved-60
Approved for M59 stable, and also approving for M60. 
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 12 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/109c6b4f90c73295d76fb18354c261cdf6c1250e

commit 109c6b4f90c73295d76fb18354c261cdf6c1250e
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Mon Jun 12 18:51:01 2017

[MD settings] allow unicode nbsp in i18n behavior strings

This CL allows for the unicode non-breaking space '\u00a0' to appear in
translations. Such spaces appear in the French translation file 1600+
times, for example.

BUG= 730025 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2926573003
Cr-Original-Commit-Position: refs/heads/master@{#477729}
Review-Url: https://codereview.chromium.org/2938473002 .
Cr-Commit-Position: refs/branch-heads/3112@{#309}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/109c6b4f90c73295d76fb18354c261cdf6c1250e/chrome/test/data/webui/i18n_behavior_test.html
[modify] https://crrev.com/109c6b4f90c73295d76fb18354c261cdf6c1250e/ui/webui/resources/js/i18n_behavior.js

Project Member

Comment 34 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cfc0b7dcf48f68fcc5df65fc79d5f25955428b6

commit 4cfc0b7dcf48f68fcc5df65fc79d5f25955428b6
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Mon Jun 12 18:53:11 2017

[MD settings] use regex to replace all nbsp

This CL allows for the unicode non-breaking space '\u00a0' to appear in
translations. This is an improvement (replacement) on CL 2926573003
which only replace the first occurrence. This CL will replace all of the
nbsp in the string.

BUG= 730025 ,  730025 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2930833004
Cr-Original-Commit-Position: refs/heads/master@{#478368}
Review-Url: https://codereview.chromium.org/2938483002 .
Cr-Commit-Position: refs/branch-heads/3112@{#310}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/4cfc0b7dcf48f68fcc5df65fc79d5f25955428b6/chrome/test/data/webui/i18n_behavior_test.html
[modify] https://crrev.com/4cfc0b7dcf48f68fcc5df65fc79d5f25955428b6/ui/webui/resources/js/i18n_behavior.js

Cc: hdodda@chromium.org
Labels: -Needs-Feedback TE-Verified-M61 TE-Verified-61.0.3128.0
Tested the issue on Mac 10.12.5 using chrome dev version #61.0.3124.4 and on Win-10 using chrome dev version #61.0.3128.0 as per comment #0. 
Observed that in both OS-Mac and OS-Win, "Ouvrez le Chrome Webstore" appeared as expected in chrome://settings.

As per comment #18 , this is not applicable to Linux.

Attached screen shots for reference.

Adding TE-Verified labels for the same.

Thanks...!!
730025.png
140 KB View Download
Labels: TE-Verified-M60 TE-Verified-60.0.3112.32
Tested the issue on windows 7, Mac 10.12.5 using chrome version 60.0.3112.32 as per the steps mentioned in comment #0.
Observed "Ouvrez le Chrome Webstore" is displayed fine under chrome://settings for French language.
Please find the attached screen shot for the same.
Adding TE-Verified labels

Thanks,
730025.png
99 KB View Download
Labels: TE-Verified-M59 TE-Verified-59.0.3071.104
Tested the issue on windows 7, Mac 10.12.5 using chrome version 59.0.3071.104 as per the steps mentioned in comment #0.
Observed "Ouvrez le Chrome Webstore" is displayed fine under chrome://settings for French language.
Please find the attached screen shot for the same.
Adding TE-Verified labels

Thanks,
730025_stable.png
133 KB View Download
Status: Verified (was: Fixed)
Verified on ChromeOS 9592.71.0, 60.0.3112.80

Sign in to add a comment