Issue metadata
Sign in to add a comment
|
|chrome| build broken with |enable_webrtc=false| |
||||||||||||||||||||||
Issue descriptionSince https://codereview.chromium.org/2801853005, building the chrome target with enable_webrtc=false fails: ../../chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc:318:11: error: no member named 'SetEchoCanceller3' in 'content::RenderProcessHost' host->SetEchoCanceller3(*params->audio_experiments.enable_aec3); ~~~~ ^ 1 error generated.
,
Jun 7 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66e6a51773c74189058e55c8b7e63353b4f469f8 commit 66e6a51773c74189058e55c8b7e63353b4f469f8 Author: hlundin <hlundin@chromium.org> Date: Thu Jun 22 15:06:48 2017 WebrtcAudioPrivateSetAudioExperimentsFunction dummy implementation This change introduces a dummy implementation of WebrtcAudioPrivateSetAudioExperimentsFunction::RunAsync() which is invoked when Chrome is build without support for WebRTC (enable_webrtc=false). BUG= 730019 , 708475 Review-Url: https://codereview.chromium.org/2949563002 Cr-Commit-Position: refs/heads/master@{#481532} [modify] https://crrev.com/66e6a51773c74189058e55c8b7e63353b4f469f8/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
,
Jun 22 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by guidou@chromium.org
, Jun 6 2017Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
Owner: hlundin@chromium.org
Status: Assigned (was: Untriaged)