New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730014 link

Starred by 1 user
Status: Archived
Owner:
isandrk@chromium.org
Closed: Jun 2017
Cc:
█ sduraisamy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add missing aliases for whitelisted permissions

Project Member Reported by isandrk@chromium.org, Jun 6 2017 
Extension permissions can have aliases - add them to the whitelist for already whitelisted permissions.

Two are missing at this moment:
- unlimited_storage (alias for unlimitedStorage);
- alwaysOnTopWindows (alias for app.window.alwaysOnTop).
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bc09844327b56ec4c69b91f893bf939645a3cc4

commit 5bc09844327b56ec4c69b91f893bf939645a3cc4
Author: Ivan Sandrk <isandrk@google.com>
Date: Wed Jun 07 13:31:38 2017

Added missing aliases for whitelisted permissions

Extension permissions can have aliases - add them to the whitelist for already whitelisted permissions.

Added unlimited_storage and alwaysOnTopWindows.

Bug:  730014 
Change-Id: Id1116257a2ed55ae5b3dc010f9fa415e2fce16f4
Reviewed-on: https://chromium-review.googlesource.com/525537
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477625}
[modify] https://crrev.com/5bc09844327b56ec4c69b91f893bf939645a3cc4/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Comment 2 by isandrk@chromium.org, Jun 8 2017

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 8 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e66bf39693e127cbbd45fa19ae949a3537ef9c85

commit e66bf39693e127cbbd45fa19ae949a3537ef9c85
Author: Ivan Sandrk <isandrk@google.com>
Date: Thu Jun 08 13:58:40 2017

[Merge to M60] Added missing aliases for whitelisted permissions

Extension permissions can have aliases - add them to the whitelist for already whitelisted permissions.

Added unlimited_storage and alwaysOnTopWindows.

Bug:  730014 
Change-Id: Id1116257a2ed55ae5b3dc010f9fa415e2fce16f4
Reviewed-on: https://chromium-review.googlesource.com/525537
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#477625}
Review-Url: https://codereview.chromium.org/2930703004 .
Cr-Commit-Position: refs/branch-heads/3112@{#251}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/e66bf39693e127cbbd45fa19ae949a3537ef9c85/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Comment 5 by isandrk@chromium.org, Jun 8 2017

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment