check if: - the playback has the minimum size requirements; - the playback has an audio track; - the playback isn't muted.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d8e0ee39b1c95cf3eae60a221600c3372cb81b7 commit 0d8e0ee39b1c95cf3eae60a221600c3372cb81b7 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Jun 27 20:27:59 2017 Media Engagement: Factor in media size to the Media Engagement Index Listen for when the video frame size changes on WebContents and ignore media that is less than a certain size (in pixels). BUG= 729998 Change-Id: Idc2c86910944ff3bf5e6a374de0009bcde8935d9 Reviewed-on: https://chromium-review.googlesource.com/528156 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#482732} [modify] https://crrev.com/0d8e0ee39b1c95cf3eae60a221600c3372cb81b7/chrome/browser/media/media_engagement_contents_observer.cc [modify] https://crrev.com/0d8e0ee39b1c95cf3eae60a221600c3372cb81b7/chrome/browser/media/media_engagement_contents_observer.h [modify] https://crrev.com/0d8e0ee39b1c95cf3eae60a221600c3372cb81b7/chrome/browser/media/media_engagement_contents_observer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8ef1cd77878dec4b0371c6ec09e541ef24e9d27 commit d8ef1cd77878dec4b0371c6ec09e541ef24e9d27 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Jul 11 10:00:24 2017 Media Engagement: Do not record playback if no sound was made If no sound was made then do not record significant playback BUG= 729998 Change-Id: I348649bfa2fefc2556717e011609ffa7813672a8 Reviewed-on: https://chromium-review.googlesource.com/537253 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#485573} [modify] https://crrev.com/d8ef1cd77878dec4b0371c6ec09e541ef24e9d27/chrome/browser/media/media_engagement_contents_observer.cc [modify] https://crrev.com/d8ef1cd77878dec4b0371c6ec09e541ef24e9d27/chrome/browser/media/media_engagement_contents_observer_unittest.cc [modify] https://crrev.com/d8ef1cd77878dec4b0371c6ec09e541ef24e9d27/content/public/test/web_contents_tester.h [modify] https://crrev.com/d8ef1cd77878dec4b0371c6ec09e541ef24e9d27/content/test/test_web_contents.cc [modify] https://crrev.com/d8ef1cd77878dec4b0371c6ec09e541ef24e9d27/content/test/test_web_contents.h
Comment 1 by beccahughes@chromium.org
, Jun 6 2017