New issue
Advanced search Search tips

Issue 729975 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Dec 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 729546
issue 729544

Blocking:
issue 654990



Sign in to add a comment

Eliminate tests manipulating internals of Identity Service

Project Member Reported by blundell@chromium.org, Jun 6 2017

Issue description

As we convert production code that depends on //components/signin and //google_apis/gaia to use the Identity Service instead, there will be a common pattern of corresponding test code that uses classes like FakeOAuth2TokenService and FakeSigninManager to manipulate the signin state and drive the production code in question. These tests will still work, as the Identity Service is using PO2TS/SigninManager under the hood in its implementation. However, in the long term we should migrate the tests away from manipulating the internals of the Identity Service to manipulating test interfaces provided by the Identity Service (see  crbug.com/729544 ).

This is a tracking bug for this effort; see blocking bugs for individual clients that can be converted once (a)  crbug.com/729544  is fixed and (b) the client's production usage is migrated to the Identity Service.
 
Blockedon: 729546
Components: Services>SignIn
Components: Internals>Services>Identity
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 6

--Chrome Identity automated triaging--

This bug is Available and has gone one year without any activity. If another month passes without any activity, this bug will be closed out. Please provide an update with the latest status for this bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 6

Cc: droger@chromium.org msarda@chromium.org bsazonov@chromium.org ew...@chromium.org tangltom@chromium.org sabineb@chromium.org jlebel@chromium.org
Status: Archived (was: Available)
--Chrome Identity automated triaging--

This available, signin or profiles-related bug has gone at least 30 days since the last automated post without any further update. This bug will be closed out due to inactivity. Please re-open the bug and provide an update if it is still a valid or reproducible bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment