New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729974 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Temperature data is seen missing in suggestion list when searched from omnibox

Project Member Reported by sc00335...@techmahindra.com, Jun 6 2017

Issue description

Chrome Version: 61.0.3122.0 dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome and search for temperaure in omnibox [say Temperature in delhi] and observe suggestion list

Expected: Current temperature along with icon should be seen.
Actual: Instead only icon is seen.. No temperature is recorded.

This is a regression issue broken in M61.

Good Build: 60.0.3112.0 dev
Bad Build: 61.0.3113.0 dev
 
Actual_temperature.png
131 KB View Download
Expected_temperature.png
135 KB View Download
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on Ubuntu 14.04 using chrome latest Dev #61.0.3122.0. This issue is not observed on Mac OS 10.12.5. 
Labels: -Needs-Bisect hasbisect-per-revision ReleaseBlock-Beta
Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)
Using per revision bisect providing information below.

Bisect Information:
--------------------
You are probably looking for a change made after 475118 (known good), but no later than 475119 (first known bad).

Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/fa46590a75919b4892df4d26074cf074bd79b048..26317da136aba1d8f3c46cd8347d396894416c7d
 
From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2901953002

tommycli@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Since this is a recent regression observed on M-61 marking it as RB-Beta please feel free to edit if this is not the case.

Thanks!

Cc: jdonnelly@chromium.org
Components: -UI>Browser>Omnibox UI>Browser>Omnibox>AiS
CC jdonnelly as an FYI because it affects answers in suggest
jdonnelly: I checked the 60 branch (3112) and the CL introducing the regression came after the branch cut.

No merge for the fix needed.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2637fc408350b9cd9fa90cf35bad8c286776b9c

commit f2637fc408350b9cd9fa90cf35bad8c286776b9c
Author: tommycli <tommycli@chromium.org>
Date: Fri Jun 09 16:13:14 2017

Omnibox UI: Fix Answers in Suggest display in Views

Fixes a regression introduced by an Omnibox UI experiment patch.

BUG= 729974 

Review-Url: https://codereview.chromium.org/2929003002
Cr-Commit-Position: refs/heads/master@{#478299}

[modify] https://crrev.com/f2637fc408350b9cd9fa90cf35bad8c286776b9c/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Status: Fixed (was: Assigned)
Labels: TE-Verified-M61 TE-Verified-61.0.3128.0
Tested the issue on Latest Dev# 61.0.3128.0 on Windows and Linux and found the issue to be fixed. Hence adding TE-Verified labels accordingly.
Note: Adding screen shot for reference.
729974.png
63.1 KB View Download

Sign in to add a comment