New issue
Advanced search Search tips

Issue 729951 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task

Blocking:
issue 723233



Sign in to add a comment

Metrics for Loading Dispatcher v0

Project Member Reported by toyoshim@chromium.org, Jun 6 2017

Issue description

Labels: -Type-Bug -Pri-3 M-61 Pri-2 Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa319f6ec07a46c2e9d0b56bb22baad5e407c939

commit aa319f6ec07a46c2e9d0b56bb22baad5e407c939
Author: ksakamoto <ksakamoto@chromium.org>
Date: Fri Jun 09 02:32:38 2017

Add Foreground-to-FirstMeaningfulPaint histogram

This metric measures the time between background tab being foregrounded
and the first meaningful paint. This would help to understand the impact
of loading request throttling for background tabs.

BUG= 729951 

Review-Url: https://codereview.chromium.org/2930583002
Cr-Commit-Position: refs/heads/master@{#478166}

[modify] https://crrev.com/aa319f6ec07a46c2e9d0b56bb22baad5e407c939/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/aa319f6ec07a46c2e9d0b56bb22baad5e407c939/chrome/browser/page_load_metrics/page_load_metrics_util.cc
[modify] https://crrev.com/aa319f6ec07a46c2e9d0b56bb22baad5e407c939/chrome/browser/page_load_metrics/page_load_metrics_util.h
[modify] https://crrev.com/aa319f6ec07a46c2e9d0b56bb22baad5e407c939/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da5f02d5361c2b74bec668ee8e6adcfb42b23a21

commit da5f02d5361c2b74bec668ee8e6adcfb42b23a21
Author: ksakamoto <ksakamoto@chromium.org>
Date: Wed Jun 21 02:55:22 2017

Add PageLoad metrics for multi-tab loading cases

This adds PageLoad histograms targeted for page loads that had other
loading tabs when the navigation started. This would help to understand
the impact of request throttling.

BUG= 729951 

Review-Url: https://codereview.chromium.org/2927283002
Cr-Commit-Position: refs/heads/master@{#481094}

[modify] https://crrev.com/da5f02d5361c2b74bec668ee8e6adcfb42b23a21/chrome/browser/BUILD.gn
[add] https://crrev.com/da5f02d5361c2b74bec668ee8e6adcfb42b23a21/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer.cc
[add] https://crrev.com/da5f02d5361c2b74bec668ee8e6adcfb42b23a21/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer.h
[add] https://crrev.com/da5f02d5361c2b74bec668ee8e6adcfb42b23a21/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer_browsertest.cc
[add] https://crrev.com/da5f02d5361c2b74bec668ee8e6adcfb42b23a21/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/da5f02d5361c2b74bec668ee8e6adcfb42b23a21/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/da5f02d5361c2b74bec668ee8e6adcfb42b23a21/chrome/test/BUILD.gn
[modify] https://crrev.com/da5f02d5361c2b74bec668ee8e6adcfb42b23a21/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa00afae68c5ae7364b91fb1cfd2a4769bc9c863

commit aa00afae68c5ae7364b91fb1cfd2a4769bc9c863
Author: ksakamoto <ksakamoto@chromium.org>
Date: Fri Jun 23 09:42:21 2017

Add UMA that periodically logs number of outstanding requests

This adds UMA to track the peak number of outstanding requests in
ResourceDispatcherHostImpl. The "MultiTabLoading" variant is logged
only when there are outstanding requests from multiple processes.
These metrics are logged periodically every 60 seconds.

BUG= 729951 

Review-Url: https://codereview.chromium.org/2951643003
Cr-Commit-Position: refs/heads/master@{#481838}

[modify] https://crrev.com/aa00afae68c5ae7364b91fb1cfd2a4769bc9c863/content/browser/loader/DEPS
[modify] https://crrev.com/aa00afae68c5ae7364b91fb1cfd2a4769bc9c863/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/aa00afae68c5ae7364b91fb1cfd2a4769bc9c863/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/aa00afae68c5ae7364b91fb1cfd2a4769bc9c863/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b78c75b49b682faa2e9e230e153d211ed234692e

commit b78c75b49b682faa2e9e230e153d211ed234692e
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jul 14 11:02:06 2017

Add UMA for per-frame outstanding resource requests

This adds UMA to track the peak number of requests with "running" state
in ResourceLoadScheduler. The value is reported when the frame is
reached the network 2-quiet state.

Bug:  729951 
Change-Id: I6d2c6f5f5094a0a8071904484cb10d14de087e7c
Reviewed-on: https://chromium-review.googlesource.com/564872
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486727}
[modify] https://crrev.com/b78c75b49b682faa2e9e230e153d211ed234692e/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/b78c75b49b682faa2e9e230e153d211ed234692e/third_party/WebKit/Source/core/loader/NetworkQuietDetector.cpp
[modify] https://crrev.com/b78c75b49b682faa2e9e230e153d211ed234692e/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
[modify] https://crrev.com/b78c75b49b682faa2e9e230e153d211ed234692e/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/b78c75b49b682faa2e9e230e153d211ed234692e/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.h
[modify] https://crrev.com/b78c75b49b682faa2e9e230e153d211ed234692e/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4916ccc25e4ec5509d5de2aa61bad23e29a7cfd

commit d4916ccc25e4ec5509d5de2aa61bad23e29a7cfd
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed Jul 19 10:31:22 2017

Add renderer peak memory metrics during load

This patch adds variants of Memory.Experimental.Renderer.* metrics that
collect peak memory usage during the frame load. This would help us to
understand the renderer-side memory impact of the request throttling.

Bug:  729951 
Change-Id: I3417a8dda5480fddbd830f72dea9c4079c73c3a3
Reviewed-on: https://chromium-review.googlesource.com/569327
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487818}
[modify] https://crrev.com/d4916ccc25e4ec5509d5de2aa61bad23e29a7cfd/content/public/common/content_features.cc
[modify] https://crrev.com/d4916ccc25e4ec5509d5de2aa61bad23e29a7cfd/content/public/common/content_features.h
[modify] https://crrev.com/d4916ccc25e4ec5509d5de2aa61bad23e29a7cfd/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/d4916ccc25e4ec5509d5de2aa61bad23e29a7cfd/content/renderer/render_frame_impl.h
[modify] https://crrev.com/d4916ccc25e4ec5509d5de2aa61bad23e29a7cfd/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment