Issue 729950 link

Starred by 3 users

Issue metadata

Status:	ExternalDependency
Owner:	tzik@chromium.org
Cc:	tzik@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Blocking:
issue 714018

Clean up non-const references around MOCK_METHOD

Project Member Reported by tzik@chromium.org, Jun 6 2017

Issue description

We are currently using non-const references to move-only types around MOCK_METHOD, as GMock currently doesn't support move-only type.
As it violate our coding style, once GMock gets move-only type support, we should clean up them.

This is a bug to keep the progress tracked.

Comment 1 by mfo...@chromium.org, Jun 7 2017

The FR against googletest has been open for six (!) years.

https://github.com/google/googletest/issues/395

Comment 2 by scheib@chromium.org, Jun 8 2017

Blocking: 714018

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e

commit 0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e
Author: tzik <tzik@chromium.org>
Date: Thu Jun 15 01:59:04 2017

Use OnceCallback on Mojo interfaces in Blink public/ interfaces

This CL flips `use_once_callback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
Blink public/BUILD.gn starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

Bug: 714018, 729950, 730593
Change-Id: Ie691ab5d299815cb022bb4e298d4e318c375efec
Reviewed-on: https://chromium-review.googlesource.com/517811
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479580}
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/budget_service/budget_database.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/budget_service/budget_database.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/budget_service/budget_manager.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/budget_service/budget_manager.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/budget_service/budget_service_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/budget_service/budget_service_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/cast_remoting_connector_unittest.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/browser_presentation_connection_proxy.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/browser_presentation_connection_proxy.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/browser_presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/presentation_service_delegate_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/webshare/share_service_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/browser/webshare/share_service_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/background_fetch/background_fetch_service_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/background_sync/background_sync_service_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/background_sync/background_sync_service_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/hyphenation/hyphenation_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/hyphenation/hyphenation_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/installedapp/installed_app_provider_impl_default.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/installedapp/installed_app_provider_impl_default.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/keyboard_lock/keyboard_lock_service_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/keyboard_lock/keyboard_lock_service_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/mime_registry_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/mime_registry_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/permissions/permission_service_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/renderer/presentation/presentation_connection_proxy.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/renderer/presentation/presentation_connection_proxy.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/content/renderer/presentation/presentation_dispatcher_unittest.cc
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/third_party/WebKit/Source/modules/app_banner/AppBannerController.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/third_party/WebKit/Source/modules/document_metadata/CopylessPasteServer.cpp
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/third_party/WebKit/Source/modules/document_metadata/CopylessPasteServer.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/third_party/WebKit/Source/platform/network/mime/MockMimeRegistry.h
[modify] https://crrev.com/0b744b9b42e9b6cf0a5267d1e81f0d345d8a759e/third_party/WebKit/public/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf7bcd65f3716fefd0640fdac12ab172db587a02

commit cf7bcd65f3716fefd0640fdac12ab172db587a02
Author: tzik <tzik@chromium.org>
Date: Thu Jun 15 06:15:18 2017

[Reland] Use OnceCallback on Mojo interfaces in Blink public/ interfaces

This is the reland of https://chromium-review.googlesource.com/c/517811/,
which conflicted to other changes and got reverted.

This CL flips `use_once_callback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
Blink public/BUILD.gn starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

TBR=xhwang@chromium.org, kojii@chromium.org, peter@chromium.org, mfoltz@chromium.org, scheib@chromium.org, mlamouri@chromium.org, haraken@chromium.org, kinuko@chromium.org, jkarlin@chromium.org, imcheng@chromium.org, mgiuca@chromium.org

Bug: 714018, 729950, 730593

Change-Id: I6af43ac56de63ae9fc962f474df8e04b3bfa905a
Reviewed-on: https://chromium-review.googlesource.com/536095
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479622}
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/budget_service/budget_database.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/budget_service/budget_database.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/budget_service/budget_manager.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/budget_service/budget_manager.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/budget_service/budget_service_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/budget_service/budget_service_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/cast_remoting_connector_unittest.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/browser_presentation_connection_proxy.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/browser_presentation_connection_proxy.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/browser_presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/presentation_service_delegate_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/webshare/share_service_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/browser/webshare/share_service_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/background_fetch/background_fetch_service_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/background_sync/background_sync_service_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/background_sync/background_sync_service_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/hyphenation/hyphenation_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/hyphenation/hyphenation_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/installedapp/installed_app_provider_impl_default.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/installedapp/installed_app_provider_impl_default.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/keyboard_lock/keyboard_lock_service_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/keyboard_lock/keyboard_lock_service_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/mime_registry_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/mime_registry_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/payments/payment_manager.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/payments/payment_manager.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/permissions/permission_service_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/renderer/presentation/presentation_connection_proxy.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/renderer/presentation/presentation_connection_proxy.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/content/renderer/presentation/presentation_dispatcher_unittest.cc
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/third_party/WebKit/Source/modules/app_banner/AppBannerController.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/third_party/WebKit/Source/modules/document_metadata/CopylessPasteServer.cpp
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/third_party/WebKit/Source/modules/document_metadata/CopylessPasteServer.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/third_party/WebKit/Source/platform/network/mime/MockMimeRegistry.h
[modify] https://crrev.com/cf7bcd65f3716fefd0640fdac12ab172db587a02/third_party/WebKit/public/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13bcefaf63f78e4425cc031ea436efa19a35c89f

commit 13bcefaf63f78e4425cc031ea436efa19a35c89f
Author: tzik <tzik@chromium.org>
Date: Thu Jun 29 06:45:46 2017

Convert presentation service callbacks to OnceCallback

PresentationConnection{,Error}Callback were aliases of a RepeatingCallback,
but OnceCallback is a good fit to all but one usage of them.
This CL makes PresentationConnectionHandler out of
PresentationConnectionCallback for SetDefaultPresentationUrls, and
converts other PresentationConnectionCallback to a OnceCallback.

Bug: 714018, 729950
Change-Id: I5f9491715bef0ce8091eb63e802bb11395c7b478
Reviewed-on: https://chromium-review.googlesource.com/548516
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483309}
[modify] https://crrev.com/13bcefaf63f78e4425cc031ea436efa19a35c89f/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/13bcefaf63f78e4425cc031ea436efa19a35c89f/chrome/browser/media/router/presentation_service_delegate_impl.h
[modify] https://crrev.com/13bcefaf63f78e4425cc031ea436efa19a35c89f/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/13bcefaf63f78e4425cc031ea436efa19a35c89f/content/public/browser/presentation_service_delegate.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b36228d60c700697620aee096dd215a8b9d40d69

commit b36228d60c700697620aee096dd215a8b9d40d69
Author: tzik <tzik@chromium.org>
Date: Tue Aug 15 02:47:07 2017

Use OnceCallback on Mojo interfaces in //device/usb/public/interfaces

This CL flips `use_once_callback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//device/usb service starts using base::OnceCallback instead of
base::Callback on its return value handling.

Bug: 714018, 729950
Change-Id: I3a806e9e6281909f394d1d3f17a3cc6f90eb1920
Reviewed-on: https://chromium-review.googlesource.com/585041
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494310}
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/android/usb/web_usb_chooser_service_android.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/android/usb/web_usb_chooser_service_android.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/ui/android/usb_chooser_dialog_android.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/ui/android/usb_chooser_dialog_android.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/ui/webui/usb_internals/BUILD.gn
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/ui/webui/usb_internals/usb_internals_page_handler.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/ui/webui/usb_internals/usb_internals_page_handler.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/usb/usb_browsertest.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/usb/usb_chooser_controller.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/usb/usb_chooser_controller.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/usb/usb_chooser_controller_unittest.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/usb/web_usb_chooser_service.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/chrome/browser/usb/web_usb_chooser_service.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/fake_usb_device_handle.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/fake_usb_device_handle.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/mock_usb_device_handle.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/mojo/device_impl.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/mojo/device_impl.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/mojo/device_impl_unittest.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/mojo/device_manager_impl.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/mojo/device_manager_impl.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/public/interfaces/BUILD.gn
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/usb_descriptors.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/usb_descriptors_unittest.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/usb_device_handle.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/usb_device_handle_impl.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/usb_device_handle_impl.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/usb_device_handle_usbfs.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/usb_device_handle_usbfs.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/usb_device_handle_win.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/usb_device_handle_win.h
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/device/usb/webusb_descriptors_unittest.cc
[modify] https://crrev.com/b36228d60c700697620aee096dd215a8b9d40d69/extensions/browser/api/usb/usb_apitest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/403b66267eb4ce35c8cbfd529df473548c574bc1

commit 403b66267eb4ce35c8cbfd529df473548c574bc1
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Nov 28 11:11:20 2017

[u2f] Clean Up U2F Device

This change improves U2fDevice by:
- Migrating to base::BindOnce() and OnceCallbacks
- Using more appropriate datastructures
- Removing dead code
- Fixing #includes to be absolute

Bug: 763303, 714018, 730593, 729950
Change-Id: If577c7f5484896a6115af997fade0c51e555df60
Reviewed-on: https://chromium-review.googlesource.com/787451
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519650}
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/mock_u2f_device.cc
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/mock_u2f_device.h
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/u2f_ble_discovery.cc
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/u2f_device.cc
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/u2f_device.h
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/u2f_hid_device.cc
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/u2f_hid_device.h
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/u2f_hid_device_unittest.cc
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/u2f_register_unittest.cc
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/u2f_request_unittest.cc
[modify] https://crrev.com/403b66267eb4ce35c8cbfd529df473548c574bc1/device/u2f/u2f_sign_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/095c5c0201299a9529f45494904728d4c514403b

commit 095c5c0201299a9529f45494904728d4c514403b
Author: tzik <tzik@chromium.org>
Date: Thu Apr 12 12:28:50 2018

Migrate ResourceCoordinator to OnceCallback

This removes 'use_once_callback = false' flag from BUILD.gn from
services/resource_coordinator, and fixes all implementations of the
interface.

Bug: 714018, 729950
Change-Id: I203b0957fdc12da1829339f79d84210446ebad7e
Reviewed-on: https://chromium-review.googlesource.com/997064
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550156}
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/components/services/heap_profiling/heap_profiling_service.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/components/services/heap_profiling/heap_profiling_service.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/coordination_unit/coordination_unit_base.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/coordinator_impl.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/queued_request.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/queued_request.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/frame_resource_coordinator.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/page_resource_coordinator.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/process_resource_coordinator.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/mojom/BUILD.gn
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/resource_coordinator_service_unittest.cc

Comment 9 by benhenry@google.com, Jan 11

Owner: tzik@chromium.org

ExternalDependency, but no component or owner. Updating to the owner so there's some accountability in tracking/closing.

►

Issue 729950 link

Issue metadata

Clean up non-const references around MOCK_METHOD

Issue description

Comment 1 by mfo...@chromium.org, Jun 7 2017

Comment 1 Deleted

Comment 2 by scheib@chromium.org, Jun 8 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jun 15 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Jun 15 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jun 29 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Aug 15 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Nov 28 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Apr 12 2018

Comment 8 Deleted

Comment 9 by benhenry@google.com, Jan 11

Comment 9 Deleted

Sign in to add a comment