New issue
Advanced search Search tips

Issue 729942 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 717984



Sign in to add a comment

CBD - "Less than X" is used inside a sentence in basic tab

Project Member Reported by dullweber@chromium.org, Jun 6 2017

Issue description

Changing the "less than x" string to upper case created a bug because "less than x" is also used inside a sentence in the basic string. We will need an upper case and a lower case version of the string. 

Because there was already the lower case string before, will adding it again automatically be translated using the old translation?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee6a8849e41e7e43563e32b24f5d949c8c01f015

commit ee6a8849e41e7e43563e32b24f5d949c8c01f015
Author: dullweber <dullweber@chromium.org>
Date: Tue Jun 06 12:29:24 2017

Fix 'Less than 1 MB' used inside a sentence

The string 'Less than 1 MB' is used inside a sentence in CBD.
This is incorrect because of the upper case L.
To fix this we reintroduce the "less than 1 MB" string. It is still in
the translation console, so it shouldn't require translation.

This CL doesn't fix the usage of 'Less than X MB' which is only used
on desktop and the fact that this sentence insertion could go wrong
due to  sentence structure in other languages.

BUG= 729942 

Review-Url: https://codereview.chromium.org/2921423002
Cr-Commit-Position: refs/heads/master@{#477267}

[modify] https://crrev.com/ee6a8849e41e7e43563e32b24f5d949c8c01f015/chrome/browser/browsing_data/browsing_data_counter_utils.cc
[modify] https://crrev.com/ee6a8849e41e7e43563e32b24f5d949c8c01f015/chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc
[modify] https://crrev.com/ee6a8849e41e7e43563e32b24f5d949c8c01f015/components/browsing_data_strings.grdp

Labels: Merge-Request-60
We would like to merge a string to M60. The exact string is already translated (go/pbkjs) but we replaced it recently and now we are adding it back. From what I understand about the translation process, it should get the translation with the next xtb update.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 6 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: There is .grd file changes and we are only 55 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Approved for M60 branch 3112.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10a2061f67a6ca24c511ed05339feae8bf57f6d5

commit 10a2061f67a6ca24c511ed05339feae8bf57f6d5
Author: Martin Sramek <msramek@chromium.org>
Date: Thu Jun 08 08:37:19 2017

Fix 'Less than 1 MB' used inside a sentence

The string 'Less than 1 MB' is used inside a sentence in CBD.
This is incorrect because of the upper case L.
To fix this we reintroduce the "less than 1 MB" string. It is still in
the translation console, so it shouldn't require translation.

This CL doesn't fix the usage of 'Less than X MB' which is only used
on desktop and the fact that this sentence insertion could go wrong
due to  sentence structure in other languages.

BUG= 729942 

Review-Url: https://codereview.chromium.org/2921423002
Cr-Original-Commit-Position: refs/heads/master@{#477267}
Review-Url: https://codereview.chromium.org/2928933002 .
Cr-Commit-Position: refs/branch-heads/3112@{#248}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/10a2061f67a6ca24c511ed05339feae8bf57f6d5/chrome/browser/browsing_data/browsing_data_counter_utils.cc
[modify] https://crrev.com/10a2061f67a6ca24c511ed05339feae8bf57f6d5/chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc
[modify] https://crrev.com/10a2061f67a6ca24c511ed05339feae8bf57f6d5/components/browsing_data_strings.grdp

Status: Fixed (was: Started)

Sign in to add a comment