New issue
Advanced search Search tips

Issue 729930 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 729895



Sign in to add a comment

[HighSierra] Build base_unittests with 10.13.0 SDK

Project Member Reported by tapted@chromium.org, Jun 6 2017

Issue description

OS Version: OS X 10.13.0

-c ../../base/mac/scoped_objc_class_swizzler_unittest.mm -o obj/base/base_unittests/scoped_objc_class_swizzler_unittest.o
../../base/mac/scoped_objc_class_swizzler_unittest.mm:118:65: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
    EXPECT_EQ(expected_result, original(nil, @selector(function)));
                                        ~~~                     ^
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1925:29: note: expanded from macro 'EXPECT_EQ'
                      val1, val2)
                            ^~~~
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:162:40: note: expanded from macro 'EXPECT_PRED_FORMAT2'
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
                                       ^~
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:147:43: note: expanded from macro 'GTEST_PRED_FORMAT2_'
  GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
                                          ^~
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:77:52: note: expanded from macro 'GTEST_ASSERT_'
  if (const ::testing::AssertionResult gtest_ar = (expression)) \
                                                   ^~~~~~~~~~
1 error generated.
 
Status: Started (was: Assigned)
https://codereview.chromium.org/2923593003/

Comment 2 Deleted

Comment 3 Deleted

Status: Fixed (was: Started)
#c1 landed. Dunno why bugdroid didn't visit.

commit	26f8e10cc57a5c1de7dfd2ae8a7ecb8917885d66	[log] [tgz]
author	tapted <tapted@chromium.org>	Tue Jun 06 21:38:09 2017
committer	Commit Bot <commit-bot@chromium.org>	Tue Jun 06 21:38:09 2017
tree	b31f2985c90e3cc96b2f9b6e05dbd638ca971fe9
parent	29f1aed44db7ab831ce7606f57ce46202a46a9d7 [diff]
Get base_unittests building with the macOS 10.13.0 SDK

IMP is now declared in objc.h as

typedef id _Nullable (*IMP)(id _Nonnull, SEL _Nonnull, ...);

previously, it was

typedef id (*IMP)(id, SEL, ...);

BUG= 729930 

Review-Url: https://codereview.chromium.org/2923593003
Cr-Commit-Position: refs/heads/master@{#477417}

Sign in to add a comment