New issue
Advanced search Search tips

Issue 729915 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task

Blocked on:
issue 701005



Sign in to add a comment

Web MIDI: new MidiManager for Chrome OS that supports ARC++ MIDI API

Project Member Reported by toyoshim@chromium.org, Jun 6 2017

Issue description

We need to implement a special backend on Chrome OS so that MIDI device can be shared with ARC++ Android system.
 
Cc: toyoshim@chromium.org agoode@chromium.org
Components: Blink>WebMIDI Platform>ARC
Owner: pmalani@chromium.org
https://bugs.chromium.org/p/chromium/issues/detail?id=701005 is tracking the implementation of that feature.
Blockedon: 701005
Cc: -toyoshim@chromium.org pmalani@chromium.org
Owner: toyoshim@chromium.org
Summary: Web MIDI: new MidiManager for Chrome OS that supports ARC++ MIDI API (was: Web MIDI: ARC++ Android MIDI API support on Chrome OS)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14f64f560efddb256cdb5c39b7c180b34b428df5

commit 14f64f560efddb256cdb5c39b7c180b34b428df5
Author: Takashi Toyoshima <toyoshim@google.com>
Date: Wed Jul 19 08:38:20 2017

Web MIDI: initial commit to have a switch for using Chrome OS MIDI service

Add an initial empty MidiManagerCros class to use experimental
Chrome OS MIDI service to unblock ARC MIDI support.

The class does nothing with this patch, but a server managed flag
can flip a setting to choose the backend from two implementations,
one is the existing ALSA based backend, and the other is brand new
Chrome OS MIDI service based one.

BUG= 729915 

Change-Id: I6279a57c212621c067954794775573ab1540ad02
Reviewed-on: https://chromium-review.googlesource.com/570138
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487794}
[modify] https://crrev.com/14f64f560efddb256cdb5c39b7c180b34b428df5/chrome/browser/about_flags.cc
[modify] https://crrev.com/14f64f560efddb256cdb5c39b7c180b34b428df5/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/14f64f560efddb256cdb5c39b7c180b34b428df5/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/14f64f560efddb256cdb5c39b7c180b34b428df5/media/midi/BUILD.gn
[add] https://crrev.com/14f64f560efddb256cdb5c39b7c180b34b428df5/media/midi/chromeos/midi_manager_cros.cc
[add] https://crrev.com/14f64f560efddb256cdb5c39b7c180b34b428df5/media/midi/chromeos/midi_manager_cros.h
[modify] https://crrev.com/14f64f560efddb256cdb5c39b7c180b34b428df5/media/midi/midi_manager_alsa.cc
[modify] https://crrev.com/14f64f560efddb256cdb5c39b7c180b34b428df5/media/midi/midi_switches.cc
[modify] https://crrev.com/14f64f560efddb256cdb5c39b7c180b34b428df5/media/midi/midi_switches.h
[modify] https://crrev.com/14f64f560efddb256cdb5c39b7c180b34b428df5/tools/metrics/histograms/enums.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38d1a089f59c250e5598549a09077ca6336799e2

commit 38d1a089f59c250e5598549a09077ca6336799e2
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Mon Sep 25 07:37:56 2017

Web MIDI: remove MidiManagerCros

Since this is not our current plan, remove MidiManagerCros and a switch
to enable it. MidiManagerAlsa would always work even on ARC supporting
Chrome OS.

Bug:  729915 
Change-Id: Ie48accec5493360cea518818ffcbf933a67f16cf
Reviewed-on: https://chromium-review.googlesource.com/677905
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504001}
[modify] https://crrev.com/38d1a089f59c250e5598549a09077ca6336799e2/chrome/browser/about_flags.cc
[modify] https://crrev.com/38d1a089f59c250e5598549a09077ca6336799e2/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/38d1a089f59c250e5598549a09077ca6336799e2/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/38d1a089f59c250e5598549a09077ca6336799e2/media/midi/BUILD.gn
[delete] https://crrev.com/dd5c8e73c309f3933dfda716ef351574e35f37f2/media/midi/chromeos/midi_manager_cros.cc
[delete] https://crrev.com/dd5c8e73c309f3933dfda716ef351574e35f37f2/media/midi/chromeos/midi_manager_cros.h
[modify] https://crrev.com/38d1a089f59c250e5598549a09077ca6336799e2/media/midi/midi_manager_alsa.cc
[modify] https://crrev.com/38d1a089f59c250e5598549a09077ca6336799e2/media/midi/midi_switches.cc
[modify] https://crrev.com/38d1a089f59c250e5598549a09077ca6336799e2/media/midi/midi_switches.h

Status: Fixed (was: Started)
Let me close this bug now.
In our new plan, the existing ALSA port should just work even if Chrome OS running ARC MIDI support.

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment