New issue
Advanced search Search tips

Issue 729912 link

Starred by 2 users
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 713891



Sign in to add a comment

color: multiple layout tests crashing in blink::ImageDecoder::Create

Project Member Reported by ccameron@chromium.org, Jun 6 2017 
Multiple layout tests are failing with the stack

blink::ImageDecoder::Create
blink::ImageDecoder::Create
blink::DeferredImageDecoder::Create
blink::ImageSource::CreateFrameAtIndex

It appears that the new image decoder being created doesn't keep alive the data required for decode.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d27758dcb7026312da955a8ba8d01fbaf925882a

commit d27758dcb7026312da955a8ba8d01fbaf925882a
Author: ccameron <ccameron@chromium.org>
Date: Tue Jun 06 07:04:43 2017

color: Remove unneeded ColorBehavior parameters from ImageSource

This is no longer needed, now that we're not supporting parameterizing
the ColorBehavior for images.

This was also causing crashes (presumably because re-creating the
decoder could sometimes fail).

TBR=junov
BUG= 729912 

Review-Url: https://codereview.chromium.org/2925623003
Cr-Commit-Position: refs/heads/master@{#477223}

[modify] https://crrev.com/d27758dcb7026312da955a8ba8d01fbaf925882a/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/d27758dcb7026312da955a8ba8d01fbaf925882a/third_party/WebKit/Source/platform/graphics/ImageSource.cpp
[modify] https://crrev.com/d27758dcb7026312da955a8ba8d01fbaf925882a/third_party/WebKit/Source/platform/graphics/ImageSource.h

Comment 2 by ccameron@chromium.org, Jun 6 2017

Status: Fixed (was: Assigned)

Comment 3 by fmalita@chromium.org, Jun 7 2017 

Issue 730444 has been merged into this issue.
►

Sign in to add a comment