Layout Tests that use mojo time out on Android. |
|||||
Issue descriptionI recently converted a Layout Test in SmokeTests to use Mojo. This caused the test to be run on Android which resulted in the test timing out on bots and locally. I tried running other Mojo tests locally e.g. usb/usb-connection-event.html and they timed out as well. We should get Layout Tests that use Mojo to run on Android. fwiw: The only relevant thing I could see in the logs was: For Web Bluetooth: [mojo_context_state.cc(207)] Failed to fetch source for module "device/bluetooth/public/interfaces/test/fake_bluetooth.mojom" For USB: [mojo_context_state.cc(207)] Failed to fetch source for module "device/usb/public/interfaces/chooser_service.mojom" [mojo_context_state.cc(207)] Failed to fetch source for module "device/usb/public/interfaces/device_manager.mojom" [mojo_context_state.cc(207)] Failed to fetch source for module "device/usb/public/interfaces/device.mojom" Assigning to yzshen@ since he's been working on JS Bindings. fyi these tests only run on KitKat; the command I used was: ninja -C out/Android -j1024 blink_tests && blink/tools/run_layout_tests.py -t Android --android -vvv --no-retry-failures usb/usb-connection-event.html
,
Jun 6 2017
Do you mean ToT fails with the command line above? I think it is probably because those tests try to fetch the mojom.js at a specific location, but you didn't copy them to the device?
,
Jun 6 2017
Both locally and in ToT mojo tests fail. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/65580 If there are any files that needed to be copied I would have expected them to be copied by the layout tests script: run_layout_tests.py
,
Jun 6 2017
After an offline chat, ortuno@ kindly agreed to take a look. Thanks! :) Please feel free to assign it back if / when you feel that you are not the right person .
,
Jun 22 2017
I didn't look into the details, but the following CL may fix the issue: https://codereview.chromium.org/2952223002/
,
Jun 23 2017
We still fail to fetch the source module :( FWIW we are currently looking for the mojom files in: /system/bin/gen/
,
Jul 11 2017
I'm transitioning to another team and will no longer be able to look at this.
,
Oct 17
,
Dec 4
TODO(oksamyt) check recent android try jobs and close if not reproduced.
,
Dec 5
I haven't found a "webkit+android" combination: https://ci.chromium.org/p/chromium/g/chromium.webkit/console https://ci.chromium.org/p/chromium/g/chromium.android/console Also, no references to usb-connection-event.html and device-same-object.html in codesearch, maybe they were renamed? Closing this ticket since the issue doesn't seem to be present anymore.
,
Dec 5
Unless mojom files started being copied to Android bots I don't think this is fixed. This should be reproducible on any Android bot that runs layout tests by adding the tests to SmokeTests. The test mentioned above has been renamed to same-device.https.html[1]. [1] https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/bluetooth/requestDevice/same-device.https.html
,
Dec 5
We no longer rely on the goofy external script to decide what gets copied to boots. We use data_deps. So if the tests work anywhere they should work everywhere. On Tue, Dec 4, 2018, 4:19 PM ortuno via monorail < monorail+v2.3110082124@chromium.org wrote: |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ortuno@chromium.org
, Jun 6 2017