New issue
Advanced search Search tips

Issue 729895 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug


Sign in to add a comment

[HighSierra] Build on SDK 10.13 [tracker]

Project Member Reported by tapted@chromium.org, Jun 6 2017

Issue description

OS Version: OS X 10.13.0

Chrome should build, e.g., with:

$ cat out/gn_1013/args.gn
is_debug = true
is_component_build = true
mac_sdk_path = "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk"
use_system_xcode = true
 
Blockedon: 729896
Blockedon: 729906
Blockedon: crashpad:184
Blockedon: 729930
$ ninja -C out/gn_1013 -k0
ninja: Entering directory `out/gn_1013'
[4943/4943] STAMP obj/All.stamp

That's it \o/

Comment 6 by thakis@chromium.org, Jun 13 2017

Is this done? There are still two open blockers, but comment 5 suggests that things work (?)

Comment 7 by rsesek@chromium.org, Jun 13 2017

No, it's not done yet. I think #5 is with all the outstanding patches applied.

Comment 8 by tapted@chromium.org, Jun 13 2017

Yup - I threw together some hacks for areas of code I'm not familiar with to chase down all the build errors.

crashpad: https://codereview.chromium.org/2924783002/
color profiles: https://codereview.chromium.org/2924743002/

(I'm not actively working on getting these landed).
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b68e6af818b39c8a3617c33ce10ec3d3d7af0eb6

commit b68e6af818b39c8a3617c33ce10ec3d3d7af0eb6
Author: Mark Mentovai <mark@chromium.org>
Date: Wed Jun 21 18:42:59 2017

mac: Deal with CGColorSpaceCopyICCProfile() 10.13 SDK bug

Bug:  729896 ,  729895 
Change-Id: I4d5ba4d5c22fc2b85aa14dcde92e02ef3454b9da
Reviewed-on: https://chromium-review.googlesource.com/541020
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481255}
[modify] https://crrev.com/b68e6af818b39c8a3617c33ce10ec3d3d7af0eb6/ui/gfx/icc_profile_mac.mm
[modify] https://crrev.com/b68e6af818b39c8a3617c33ce10ec3d3d7af0eb6/ui/gfx/mac/io_surface.cc

Comment 10 by mark@chromium.org, Jun 21 2017

Blockedon: -crashpad:184 crashpad:188
Status: Fixed (was: Available)
Should be done now.
Awesome, thanks to everyone helping with this!

Comment 12 by mark@chromium.org, Jul 10 2017

Blockedon: 740712

Comment 13 by mark@chromium.org, Jul 19 2017

Blockedon: 746559

Comment 14 by mark@chromium.org, Jul 19 2017

Status: Available (was: Fixed)
Reopening because of  bug 746559 .

Comment 15 Deleted

Comment 16 Deleted

Comment 17 by mark@chromium.org, Aug 8 2017

Blockedon: 753090
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96b54f923106328e550a513ed1e836de8b93b97a

commit 96b54f923106328e550a513ed1e836de8b93b97a
Author: Mark Mentovai <mark@chromium.org>
Date: Wed Sep 13 21:44:50 2017

mac: Support the 10.13 SDK in Bluetooth adapter metrics

The 10.11 and 10.12 SDKs had CBErrorMaxConnection = 10 in their CBError
enum. This value was never documented, and it’s possible that it was
only intended to serve as a “last” marker. In the 10.13 SDK, this value
has been removed, and three new ones were added: CBErrorConnectonFailed
= 10, CBErrorConnectionLimitReached = 11, and CBErrorUnkownDevice = 12.
(Yes, there’s a typo in the last one.)

Building with the 10.13 SDK produces this error:

../../device/bluetooth/bluetooth_adapter_mac_metrics.mm:50:15: error: use of undeclared identifier 'CBErrorMaxConnection'; did you mean 'CBErrorNotConnected'?
          if (CBErrorMaxConnection == cb_error_code)
              ^~~~~~~~~~~~~~~~~~~~
              CBErrorNotConnected
…/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreBluetooth.framework/Headers/CBError.h:31:2:       'CBErrorNotConnected' declared here
        CBErrorNotConnected NS_ENUM_AVAILABLE(10_9, 6_0)                        = 3,
        ^

This removes CBErrorMaxConnection and adds the three new enum values.
According to UMA, CBErrorMaxConnection has never been hit anyway.

Bug:  729895 
Change-Id: I543ec05679f6cc5ba70d6fbb4ace5e8fb29989b0
Reviewed-on: https://chromium-review.googlesource.com/665497
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501760}
[modify] https://crrev.com/96b54f923106328e550a513ed1e836de8b93b97a/device/bluetooth/bluetooth_adapter_mac_metrics.h
[modify] https://crrev.com/96b54f923106328e550a513ed1e836de8b93b97a/device/bluetooth/bluetooth_adapter_mac_metrics.mm
[modify] https://crrev.com/96b54f923106328e550a513ed1e836de8b93b97a/tools/metrics/histograms/enums.xml

Blocking: 780980
Is this done?
wow, yeah. totally done. building has worked for yonks.
Status: Fixed (was: Available)

Sign in to add a comment