[HighSierra] Build on SDK 10.13 [tracker] |
||||||||
Issue descriptionOS Version: OS X 10.13.0 Chrome should build, e.g., with: $ cat out/gn_1013/args.gn is_debug = true is_component_build = true mac_sdk_path = "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk" use_system_xcode = true
,
Jun 6 2017
,
Jun 6 2017
,
Jun 6 2017
,
Jun 6 2017
$ ninja -C out/gn_1013 -k0 ninja: Entering directory `out/gn_1013' [4943/4943] STAMP obj/All.stamp That's it \o/
,
Jun 13 2017
Is this done? There are still two open blockers, but comment 5 suggests that things work (?)
,
Jun 13 2017
No, it's not done yet. I think #5 is with all the outstanding patches applied.
,
Jun 13 2017
Yup - I threw together some hacks for areas of code I'm not familiar with to chase down all the build errors. crashpad: https://codereview.chromium.org/2924783002/ color profiles: https://codereview.chromium.org/2924743002/ (I'm not actively working on getting these landed).
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b68e6af818b39c8a3617c33ce10ec3d3d7af0eb6 commit b68e6af818b39c8a3617c33ce10ec3d3d7af0eb6 Author: Mark Mentovai <mark@chromium.org> Date: Wed Jun 21 18:42:59 2017 mac: Deal with CGColorSpaceCopyICCProfile() 10.13 SDK bug Bug: 729896 , 729895 Change-Id: I4d5ba4d5c22fc2b85aa14dcde92e02ef3454b9da Reviewed-on: https://chromium-review.googlesource.com/541020 Reviewed-by: ccameron chromium <ccameron@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#481255} [modify] https://crrev.com/b68e6af818b39c8a3617c33ce10ec3d3d7af0eb6/ui/gfx/icc_profile_mac.mm [modify] https://crrev.com/b68e6af818b39c8a3617c33ce10ec3d3d7af0eb6/ui/gfx/mac/io_surface.cc
,
Jun 21 2017
,
Jun 21 2017
Awesome, thanks to everyone helping with this!
,
Jul 10 2017
,
Jul 19 2017
,
Jul 19 2017
,
Aug 8 2017
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96b54f923106328e550a513ed1e836de8b93b97a commit 96b54f923106328e550a513ed1e836de8b93b97a Author: Mark Mentovai <mark@chromium.org> Date: Wed Sep 13 21:44:50 2017 mac: Support the 10.13 SDK in Bluetooth adapter metrics The 10.11 and 10.12 SDKs had CBErrorMaxConnection = 10 in their CBError enum. This value was never documented, and it’s possible that it was only intended to serve as a “last” marker. In the 10.13 SDK, this value has been removed, and three new ones were added: CBErrorConnectonFailed = 10, CBErrorConnectionLimitReached = 11, and CBErrorUnkownDevice = 12. (Yes, there’s a typo in the last one.) Building with the 10.13 SDK produces this error: ../../device/bluetooth/bluetooth_adapter_mac_metrics.mm:50:15: error: use of undeclared identifier 'CBErrorMaxConnection'; did you mean 'CBErrorNotConnected'? if (CBErrorMaxConnection == cb_error_code) ^~~~~~~~~~~~~~~~~~~~ CBErrorNotConnected …/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreBluetooth.framework/Headers/CBError.h:31:2: 'CBErrorNotConnected' declared here CBErrorNotConnected NS_ENUM_AVAILABLE(10_9, 6_0) = 3, ^ This removes CBErrorMaxConnection and adds the three new enum values. According to UMA, CBErrorMaxConnection has never been hit anyway. Bug: 729895 Change-Id: I543ec05679f6cc5ba70d6fbb4ace5e8fb29989b0 Reviewed-on: https://chromium-review.googlesource.com/665497 Reviewed-by: Vincent Scheib <scheib@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#501760} [modify] https://crrev.com/96b54f923106328e550a513ed1e836de8b93b97a/device/bluetooth/bluetooth_adapter_mac_metrics.h [modify] https://crrev.com/96b54f923106328e550a513ed1e836de8b93b97a/device/bluetooth/bluetooth_adapter_mac_metrics.mm [modify] https://crrev.com/96b54f923106328e550a513ed1e836de8b93b97a/tools/metrics/histograms/enums.xml
,
Feb 15 2018
,
Feb 15 2018
wow, yeah. totally done. building has worked for yonks.
,
Feb 15 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tapted@chromium.org
, Jun 6 2017