New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 729859 link

Starred by 1 user
Status: Fixed
Owner:
martis@chromium.org
Closed: Nov 2017
Cc:
ios-bugs@chromium.org
█ ichikawa@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[LanguageModel] Plug in the model for iOS web_view

Project Member Reported by ramyasharma@chromium.org, Jun 6 2017 
LanguageModel currently works only on Android, and is being added in crbug/715447 on iOS, which adds histogram logging of the detected page language. However, ios/web_view doesn't support histogram logging yet hence this is a tracking bug to add this once histogram logging is supported in ios/web_view.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e97e53dd9ec5d78c000a2acb32138350bd7ce40d

commit e97e53dd9ec5d78c000a2acb32138350bd7ce40d
Author: Michael Martis <martis@chromium.org>
Date: Thu Nov 02 03:42:20 2017

Added the URL language histogram factory for iOS WebView.

This allows iOS WebView to store URL languages, which will
eventually be required for the heuristic user language
model.

Bug:  729859 
Change-Id: I4be22e05cda941bb8b8c0dc4c0511ad266acacbb
Reviewed-on: https://chromium-review.googlesource.com/748942
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Renjie Liu <renjieliu@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513396}
[modify] https://crrev.com/e97e53dd9ec5d78c000a2acb32138350bd7ce40d/ios/web_view/BUILD.gn
[modify] https://crrev.com/e97e53dd9ec5d78c000a2acb32138350bd7ce40d/ios/web_view/internal/DEPS
[add] https://crrev.com/e97e53dd9ec5d78c000a2acb32138350bd7ce40d/ios/web_view/internal/language/web_view_url_language_histogram_factory.cc
[add] https://crrev.com/e97e53dd9ec5d78c000a2acb32138350bd7ce40d/ios/web_view/internal/language/web_view_url_language_histogram_factory.h
[modify] https://crrev.com/e97e53dd9ec5d78c000a2acb32138350bd7ce40d/ios/web_view/internal/translate/cwv_translation_controller.mm
[modify] https://crrev.com/e97e53dd9ec5d78c000a2acb32138350bd7ce40d/ios/web_view/internal/web_view_web_main_parts.mm

Comment 2 by martis@chromium.org, Nov 2 2017

Owner: martis@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment