New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729858 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 725786

Blocking:
issue 658980



Sign in to add a comment

[MD Bookmarks] Add keyboard shortcuts for cut/paste

Project Member Reported by tsergeant@chromium.org, Jun 6 2017

Issue description

Cut/paste are useful for power users and screen-reader users, but we don't want to clog up the context menu with these extra options.

We should add a keyboard shortcut for these commands, with a toast to confirm the action.
 
Owner: tsergeant@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7253e9c12c66f12bf67f95be8c6aeea808dce12

commit b7253e9c12c66f12bf67f95be8c6aeea808dce12
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Jul 04 02:59:22 2017

MD Bookmarks: Add full support for cut/copy/paste keyboard shortcuts

This adds keyboard shortcuts for Cut/Paste, and expands the keyboard
shortcut for Copy to work with any selection (not just a single
bookmark).

Copying a bookmark shows a toast indicating how many items were copied,
since there is no other visual indicator that the copy was successful.

BUG= 729858 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2948943002
Cr-Commit-Position: refs/heads/master@{#484043}

[modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/browser/resources/md_bookmarks/constants.js
[modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/browser/resources/md_bookmarks/toast_manager.html
[modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/test/data/webui/md_bookmarks/command_manager_test.js

Status: Fixed (was: Started)
After #2, we have full support for Cut/Copy/Paste as keyboard shortcuts, with a confirmation toast for Copy but not for Cut/Paste.

We've confirmed with bettes@ that this is sufficient.

Sign in to add a comment