[MD Bookmarks] Add keyboard shortcuts for cut/paste |
||
Issue descriptionCut/paste are useful for power users and screen-reader users, but we don't want to clog up the context menu with these extra options. We should add a keyboard shortcut for these commands, with a toast to confirm the action.
,
Jul 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7253e9c12c66f12bf67f95be8c6aeea808dce12 commit b7253e9c12c66f12bf67f95be8c6aeea808dce12 Author: tsergeant <tsergeant@chromium.org> Date: Tue Jul 04 02:59:22 2017 MD Bookmarks: Add full support for cut/copy/paste keyboard shortcuts This adds keyboard shortcuts for Cut/Paste, and expands the keyboard shortcut for Copy to work with any selection (not just a single bookmark). Copying a bookmark shows a toast indicating how many items were copied, since there is no other visual indicator that the copy was successful. BUG= 729858 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2948943002 Cr-Commit-Position: refs/heads/master@{#484043} [modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/app/bookmarks_strings.grdp [modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/browser/resources/md_bookmarks/constants.js [modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/browser/resources/md_bookmarks/toast_manager.html [modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/b7253e9c12c66f12bf67f95be8c6aeea808dce12/chrome/test/data/webui/md_bookmarks/command_manager_test.js
,
Jul 18 2017
After #2, we have full support for Cut/Copy/Paste as keyboard shortcuts, with a confirmation toast for Copy but not for Cut/Paste. We've confirmed with bettes@ that this is sufficient. |
||
►
Sign in to add a comment |
||
Comment 1 by tsergeant@chromium.org
, Jun 8 2017Status: Started (was: Available)