New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 729854 link

Starred by 1 user
Status: Fixed
Owner:
█ kelv...@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Set a timeout for register support host requests.

Project Member Reported by kelv...@chromium.org, Jun 6 2017 
What steps will reproduce the problem?
(1) Open the CRD Chrome App while the signaling channel is down (or
    when we have no internet connection)
(2) Try to generate an access code.

What is the expected result?
The request should timeout and show an error UX.

What happens instead?
The request is stuck.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7e7635584e929a13fbcb2cd87ed4779342e6342

commit e7e7635584e929a13fbcb2cd87ed4779342e6342
Author: kelvinp <kelvinp@chromium.org>
Date: Tue Jun 13 06:04:34 2017

Report signling errors for register-support-host requests.

Summary of changes:
Report an error message if:
1. SignalStrategy->SendStanza() fails.
2. There are no responses from the Bot 10 seconds after the request is
   sent.

BUG= 729854 

Review-Url: https://codereview.chromium.org/2925733003
Cr-Commit-Position: refs/heads/master@{#478912}

[modify] https://crrev.com/e7e7635584e929a13fbcb2cd87ed4779342e6342/remoting/host/it2me/it2me_host_unittest.cc
[modify] https://crrev.com/e7e7635584e929a13fbcb2cd87ed4779342e6342/remoting/host/register_support_host_request.cc
[modify] https://crrev.com/e7e7635584e929a13fbcb2cd87ed4779342e6342/remoting/host/register_support_host_request_unittest.cc

Comment 2 by kelv...@chromium.org, Jun 14 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment