New issue
Advanced search Search tips

Issue 729849 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Sign in to add a comment

Fix layout tests with Network Service

Project Member Reported by jam@chromium.org, Jun 6 2017

Issue description

Tracking bug to fix all remaining failures.
 
Showing comments 13 - 112 of 112 Older
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a5fd69d076e463b6cc1aff59ffea4aae439b71f

commit 1a5fd69d076e463b6cc1aff59ffea4aae439b71f
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jun 14 17:04:32 2017

Make external/wpt both Failure and Timeout for --enable-network-service

TBR=jam@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: I551b923709b91734f370f8f259f13b7845513abd
Reviewed-on: https://chromium-review.googlesource.com/534964
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479427}
[modify] https://crrev.com/1a5fd69d076e463b6cc1aff59ffea4aae439b71f/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2a8eef9c69cb5cccd0fabd74a3f2b7a7862a603

commit b2a8eef9c69cb5cccd0fabd74a3f2b7a7862a603
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jun 14 18:17:35 2017

More external/wpt for --enable-network-service

TBR=jam@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: Ib7c2914365c22f16c5ba9b7adef5048cc9667531
Reviewed-on: https://chromium-review.googlesource.com/535023
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479444}
[modify] https://crrev.com/b2a8eef9c69cb5cccd0fabd74a3f2b7a7862a603/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Cc: scottmg@chromium.org
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98f3a3fb7abb2b0ffc31a065e064fd6ed9ee439d

commit 98f3a3fb7abb2b0ffc31a065e064fd6ed9ee439d
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jun 14 19:45:18 2017

More layout test disable for --enable-network-service

TBR=jam@chromium.org

Bug:  729849 
Change-Id: Ic44d494b0409272d0185c4564617d09fcb4462ec
Reviewed-on: https://chromium-review.googlesource.com/535874
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479472}
[modify] https://crrev.com/98f3a3fb7abb2b0ffc31a065e064fd6ed9ee439d/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e062336432adb699cda43e3cd781c8d1b9cae368

commit e062336432adb699cda43e3cd781c8d1b9cae368
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jun 14 20:59:31 2017

More more layout test disable for --enable-network-service

TBR=jam@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: I8271ee512bfee0861be8bc148cfadcd78662174c
Reviewed-on: https://chromium-review.googlesource.com/535876
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479501}
[modify] https://crrev.com/e062336432adb699cda43e3cd781c8d1b9cae368/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dec5dff0b4a97489c4ff9227696c838cba1c956

commit 6dec5dff0b4a97489c4ff9227696c838cba1c956
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jun 14 21:54:47 2017

More more more layout test disable for --enable-network-service

TBR=jam@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: I1c063f7565d9f4d2063eb8210ad16bc3a442e285
Reviewed-on: https://chromium-review.googlesource.com/535857
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479516}
[modify] https://crrev.com/6dec5dff0b4a97489c4ff9227696c838cba1c956/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d3ba8a1364a6721e3c65889e0a3ae15cf8f075a

commit 9d3ba8a1364a6721e3c65889e0a3ae15cf8f075a
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jun 14 23:28:55 2017

More^4 layout test disable for --enable-network-service

TBR=jam@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: Ib7a1ef4c6eaec452abe18b48e033ebada092052c
Reviewed-on: https://chromium-review.googlesource.com/536154
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479542}
[modify] https://crrev.com/9d3ba8a1364a6721e3c65889e0a3ae15cf8f075a/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/970e8b3350c6984c88b918d778184564cb325fc9

commit 970e8b3350c6984c88b918d778184564cb325fc9
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jun 15 00:26:22 2017

More^5 layout test disable for --enable-network-service

TBR=jam@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: If299e0ad732d496f20cde41b0f14dac71c65de31
Reviewed-on: https://chromium-review.googlesource.com/536453
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479553}
[modify] https://crrev.com/970e8b3350c6984c88b918d778184564cb325fc9/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d83bb4aee55783c8d21dca832fda252ae4aa9fe5

commit d83bb4aee55783c8d21dca832fda252ae4aa9fe5
Author: scottmg <scottmg@chromium.org>
Date: Thu Jun 15 20:30:53 2017

Update --enable-network-service disabled layout tests

TBR=jam@chromium.org
NOTRY=true
Bug= 729849 

Review-Url: https://codereview.chromium.org/2940173002
Cr-Commit-Position: refs/heads/master@{#479814}

[modify] https://crrev.com/d83bb4aee55783c8d21dca832fda252ae4aa9fe5/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a68476194ad9536b44b42d3cdd6fce7ee8581da

commit 9a68476194ad9536b44b42d3cdd6fce7ee8581da
Author: scottmg <scottmg@chromium.org>
Date: Thu Jun 15 21:49:50 2017

Update content_browsertests filter for --enable-network-service bot

BUG= 729849 
TBR=jam@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2936283004
Cr-Commit-Position: refs/heads/master@{#479850}

[modify] https://crrev.com/9a68476194ad9536b44b42d3cdd6fce7ee8581da/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c42f0f2d5976d4e55a3b66fab55b9225f222078a

commit c42f0f2d5976d4e55a3b66fab55b9225f222078a
Author: scottmg <scottmg@chromium.org>
Date: Fri Jun 16 23:47:30 2017

Update test filters for --enable-network-service

WebRtcVideoCaptureBrowserTest.RecoverFromCrashInVideoCaptureProcess started
timing out.

TBR=jam@chromium.org
NOTRY=true
Bug= 729849 

Review-Url: https://codereview.chromium.org/2939023005
Cr-Commit-Position: refs/heads/master@{#480225}

[modify] https://crrev.com/c42f0f2d5976d4e55a3b66fab55b9225f222078a/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef0e8704ab0f6dcfd1d88374ed4495f1c173aa04

commit ef0e8704ab0f6dcfd1d88374ed4495f1c173aa04
Author: yhirano <yhirano@chromium.org>
Date: Wed Jun 21 03:34:50 2017

Revert of update content_browsertests filter for --enable-network-service (patchset #1 id:1 of https://codereview.chromium.org/2949693002/ )

Reason for revert:
It should be fixed by https://chromium-review.googlesource.com/c/540999/.

Original issue's description:
> update content_browsertests filter for --enable-network-service
>
> TBR=rdsmith@chromium.org
> NOTRY=true
> Bug= 729849 
>
> Review-Url: https://codereview.chromium.org/2949693002
> Cr-Commit-Position: refs/heads/master@{#480659}
> Committed: https://chromium.googlesource.com/chromium/src/+/abd930241ad01df52b3f9171f53040ca2c3cb401

TBR=rdsmith@chromium.org,scottmg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Bug= 729849 

Review-Url: https://codereview.chromium.org/2951933002
Cr-Commit-Position: refs/heads/master@{#481103}

[modify] https://crrev.com/ef0e8704ab0f6dcfd1d88374ed4495f1c173aa04/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2d4e7005814881999c77e2ebec9e892c771da43

commit d2d4e7005814881999c77e2ebec9e892c771da43
Author: rdsmith <rdsmith@chromium.org>
Date: Wed Jun 21 18:17:55 2017

Disable broken-in-network-service on creation test.

Test added in https://chromium-review.googlesource.com/536383.

BUG= 729849 
NOTRY=true
TBR=scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2950133002
Cr-Commit-Position: refs/heads/master@{#481244}

[modify] https://crrev.com/d2d4e7005814881999c77e2ebec9e892c771da43/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05a9016533111c44c2a06af7f74f1d9ed41e4eff

commit 05a9016533111c44c2a06af7f74f1d9ed41e4eff
Author: rdsmith <rdsmith@chromium.org>
Date: Wed Jun 21 18:47:56 2017

Disable tests broken-on-creation for --enable-network-service.

Tests created in https://chromium-review.googlesource.com/533953

BUG= 729849 
TBR=scottmg@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2947173002
Cr-Commit-Position: refs/heads/master@{#481260}

[modify] https://crrev.com/05a9016533111c44c2a06af7f74f1d9ed41e4eff/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fa54e0672ef0dd85ef3aa2878cdb80db245a006

commit 2fa54e0672ef0dd85ef3aa2878cdb80db245a006
Author: rdsmith <rdsmith@chromium.org>
Date: Wed Jun 21 19:10:25 2017

Disable tests failing-on-creation under --enable-network-service.

These tests were added in https://chromium-review.googlesource.com/540457

BUG= 729849 
TBR=scottmg@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2947183002
Cr-Commit-Position: refs/heads/master@{#481266}

[modify] https://crrev.com/2fa54e0672ef0dd85ef3aa2878cdb80db245a006/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 29 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d020a950743c3f89f5956951b2a4346c4349bbf

commit 9d020a950743c3f89f5956951b2a4346c4349bbf
Author: rdsmith <rdsmith@chromium.org>
Date: Thu Jun 22 02:18:28 2017

Disable layout tests that stopped working for --enable-network-service.

These tests stopped on test modifications in
https://chromium-review.googlesource.com/c/541156.

BUG= 729849 
NOTRY=true
TBR=scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2947323002
Cr-Commit-Position: refs/heads/master@{#481406}

[modify] https://crrev.com/9d020a950743c3f89f5956951b2a4346c4349bbf/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 30 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d16bada7708d2fff08b0e48608d545621a1e8bef

commit d16bada7708d2fff08b0e48608d545621a1e8bef
Author: rdsmith <rdsmith@chromium.org>
Date: Thu Jun 22 17:44:13 2017

Disable layout tests broken for network service when landed or by test rewrite

These tests were broken by https://chromium-review.googlesource.com/542278

NOTRY=true
TBR=scottmg@chromium.org
BUG= 729849 

Review-Url: https://codereview.chromium.org/2948263002
Cr-Commit-Position: refs/heads/master@{#481589}

[modify] https://crrev.com/d16bada7708d2fff08b0e48608d545621a1e8bef/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b734376f4bb7849baba7ebf00645c58c7a065a6

commit 9b734376f4bb7849baba7ebf00645c58c7a065a6
Author: rdsmith <rdsmith@chromium.org>
Date: Fri Jun 23 02:00:17 2017

Disable layout tests broken for network service when landed.

These tests were broken by https://codereview.chromium.org/2789723003

NOTRY=true
TBR=scottmg@chromium.org
BUG= 729849 

Review-Url: https://codereview.chromium.org/2958443002
Cr-Commit-Position: refs/heads/master@{#481780}

[modify] https://crrev.com/9b734376f4bb7849baba7ebf00645c58c7a065a6/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 32 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fdcb0640ec1d026572df6a7243257fb88f94aa1

commit 5fdcb0640ec1d026572df6a7243257fb88f94aa1
Author: rdsmith <rdsmith@chromium.org>
Date: Fri Jun 23 21:07:49 2017

Disable flaky layout test for network service.

I tried but failed to figure out what was the CL causing this flake.
The earliest bot evidence of it I found was
https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/2402.
The last CL in that blamelist (i.e. the latest CL that might possibly have
caused this problem) was https://chromium-review.googlesource.com/541357.

NOTRY=true
TBR=scottmg@chromium.org
BUG= 729849 

Review-Url: https://codereview.chromium.org/2957673002
Cr-Commit-Position: refs/heads/master@{#482029}

[modify] https://crrev.com/5fdcb0640ec1d026572df6a7243257fb88f94aa1/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 33 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28d381082211e0ba9199c8c8de35ff77cda44066

commit 28d381082211e0ba9199c8c8de35ff77cda44066
Author: mmenke <mmenke@chromium.org>
Date: Mon Jun 26 18:33:40 2017

And Timeout expectations for two new Bluetooth tests.

There are already similar expectations for a bunch of pre-existing ones.

The new ones are:

bluetooth/characteristic/writeValue/write-succeeds.html added in
https://chromium-review.googlesource.com/542755

bluetooth/descriptor/readValue/read-succeeds.html added in
LayoutTests/bluetooth/descriptor/readValue/read-succeeds.html

BUG= 729849 
TBR=scottmg@chromium.org, ortuno@chromium.org

Review-Url: https://codereview.chromium.org/2959783002
Cr-Commit-Position: refs/heads/master@{#482332}

[modify] https://crrev.com/28d381082211e0ba9199c8c8de35ff77cda44066/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 34 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35c6957bd1c669416c951779fe7e1397f2783d34

commit 35c6957bd1c669416c951779fe7e1397f2783d34
Author: mmenke <mmenke@chromium.org>
Date: Mon Jun 26 19:39:29 2017

Add network service suppression for new lofi layout test.

http/tests/previews/client-lofi-sprite.html was added in
https://codereview.chromium.org/2795173002.  Since the network service
does not yet support lofi mode, failures here are not surprising.

TBR=rdsmith@chromium.org
BUG= 729849 

Review-Url: https://codereview.chromium.org/2957863002
Cr-Commit-Position: refs/heads/master@{#482358}

[modify] https://crrev.com/35c6957bd1c669416c951779fe7e1397f2783d34/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 35 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72a60ffce2b4316f706d216520f10d6e68b5f9ea

commit 72a60ffce2b4316f706d216520f10d6e68b5f9ea
Author: mmenke <mmenke@chromium.org>
Date: Tue Jun 27 16:17:07 2017

Add network service suppression for a newly added layout test.

inspector-protocol/dom/dom-request-document-with-child-nodes.js was
added in https://codereview.chromium.org/2955943002, and there are
already a bunch of suppressed inspectory-protocol tests, so doesn't
seem like a regression.

TBR=rdsmith@chromium.org
BUG= 729849 

Review-Url: https://codereview.chromium.org/2959013002
Cr-Commit-Position: refs/heads/master@{#482643}

[modify] https://crrev.com/72a60ffce2b4316f706d216520f10d6e68b5f9ea/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 36 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca8b6e7f69606b7398d6f03390543fdd737a8b6

commit eca8b6e7f69606b7398d6f03390543fdd737a8b6
Author: mmenke <mmenke@chromium.org>
Date: Wed Jun 28 21:16:08 2017

Add NetworkService suppressions for 4 new layout tests.

All are in directories with a number of other suppressions already as
well, so don't think there's any regression here.

TBR=rdsmith@chromium.org
BUG= 729849 

Review-Url: https://codereview.chromium.org/2962973002
Cr-Commit-Position: refs/heads/master@{#483141}

[modify] https://crrev.com/eca8b6e7f69606b7398d6f03390543fdd737a8b6/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 37 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca8b6e7f69606b7398d6f03390543fdd737a8b6

commit eca8b6e7f69606b7398d6f03390543fdd737a8b6
Author: mmenke <mmenke@chromium.org>
Date: Wed Jun 28 21:16:08 2017

Add NetworkService suppressions for 4 new layout tests.

All are in directories with a number of other suppressions already as
well, so don't think there's any regression here.

TBR=rdsmith@chromium.org
BUG= 729849 

Review-Url: https://codereview.chromium.org/2962973002
Cr-Commit-Position: refs/heads/master@{#483141}

[modify] https://crrev.com/eca8b6e7f69606b7398d6f03390543fdd737a8b6/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 38 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2998ecdcb0ab6991e4b8e8c592af24c478ef273

commit e2998ecdcb0ab6991e4b8e8c592af24c478ef273
Author: mmenke <mmenke@chromium.org>
Date: Thu Jun 29 17:12:19 2017

Add layout test suppression for NetworkService

external/wpt/html/semantics/scripting-1/the-script-element/module/credentials.sub.html
was recently added, and is failing, so not a regression.

TBR=rdsmith@chromium.org
BUG= 729849 

Review-Url: https://codereview.chromium.org/2967473002
Cr-Commit-Position: refs/heads/master@{#483402}

[modify] https://crrev.com/e2998ecdcb0ab6991e4b8e8c592af24c478ef273/third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service

Project Member

Comment 39 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1d2ec19fc647fbde62797e1dcdd4d43db68fcc0

commit b1d2ec19fc647fbde62797e1dcdd4d43db68fcc0
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Wed Jul 05 20:59:45 2017

Update test suppression for network service.

Couldn't easily find any CL resulting in the failure.
There were a lot of regressed test cases because of
https://chromium-review.googlesource.com/c/554399/, which was later fixed.
It is possible that some other regressions were introduced during that period,
but hard to tell.

BUG= 729849 
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2970143002 .
Cr-Commit-Position: refs/heads/master@{#484347}

[modify] https://crrev.com/b1d2ec19fc647fbde62797e1dcdd4d43db68fcc0/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
[modify] https://crrev.com/b1d2ec19fc647fbde62797e1dcdd4d43db68fcc0/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 40 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4adfac81062c55ab1733e893c3940f7055c64b0

commit a4adfac81062c55ab1733e893c3940f7055c64b0
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Thu Jul 06 16:29:28 2017

Update test suppression for network service.

A new test was added which failed to run with network service:
vr/requestAnimationFrame_consistentTimestamps.html

BUG= 729849 
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2971173002 .
Cr-Commit-Position: refs/heads/master@{#484624}

[modify] https://crrev.com/a4adfac81062c55ab1733e893c3940f7055c64b0/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 41 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5659a223d638a9acadc0cc264cc0d052cc95df5d

commit 5659a223d638a9acadc0cc264cc0d052cc95df5d
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Fri Jul 07 15:32:34 2017

Update test suppUpdate test suppression for network service.

The following tests were added recently:
PowerMonitorTest.TestGpuProcess
external/wpt/clear-site-data/navigation.https.html

BUG= 729849 
TBR=jam@chromium.org

Change-Id: I66bcbcce8a171ad73c2f65dc15f7649c2cd00418
Reviewed-on: https://chromium-review.googlesource.com/563696
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484934}
[modify] https://crrev.com/5659a223d638a9acadc0cc264cc0d052cc95df5d/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
[modify] https://crrev.com/5659a223d638a9acadc0cc264cc0d052cc95df5d/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 42 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/287591bd8b0165fcabb427ff595d141a9ae89b4b

commit 287591bd8b0165fcabb427ff595d141a9ae89b4b
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jul 20 22:28:30 2017

Add mime sniffing to the network service.

This doesn't handle all the cases (e.g. plugins, downloads) but these don't work
yet with the network service. However it does fix 900 new wpt tests that 
started failing after r487304 since these generated *worker.html files weren't
being served with a mime type which was causing their load to fail.

BUG= 746144 , 729849 

Change-Id: I232c9af1dca32f1c641736c8ccd61978096559ef
Reviewed-on: https://chromium-review.googlesource.com/577507
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488445}
[modify] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/browser/loader/mime_sniffing_resource_handler.h
[modify] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/child/resource_dispatcher.cc
[modify] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/common/BUILD.gn
[add] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/common/loader_util.cc
[add] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/common/loader_util.h
[modify] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/network/DEPS
[modify] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/network/url_loader_impl.cc
[modify] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/network/url_loader_impl.h
[modify] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/network/url_loader_unittest.cc
[modify] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/public/common/url_loader_factory.mojom
[add] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/test/data/content-sniffer-test4.html
[add] https://crrev.com/287591bd8b0165fcabb427ff595d141a9ae89b4b/content/test/data/content-sniffer-test4.html.mock-http-headers

Project Member

Comment 43 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c3e7702454d1bde12eb650ca84ad0c5d0d044ce

commit 7c3e7702454d1bde12eb650ca84ad0c5d0d044ce
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Jul 26 11:23:34 2017

Gardening: network service: Add flaky test embed-image-load-outlives-gc-without-crashing.html

Bug:  729849 
Change-Id: Ibde747f07f97df02ad4b4bb10d323b301b736955
Reviewed-on: https://chromium-review.googlesource.com/584657
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489608}
[modify] https://crrev.com/7c3e7702454d1bde12eb650ca84ad0c5d0d044ce/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 44 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fcf487ab0aaf6a93151ef44d36cd48e23145b70

commit 3fcf487ab0aaf6a93151ef44d36cd48e23145b70
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Jul 27 06:00:05 2017

Gardening: network service: Add failing some external/wpt/fetch tests.

request-upload.* tests were always failing but were fixed in r489659 and
hence the generic TestExpectations failures were removed, but it still
is failing for network service.

cors-cookies.* tests recently became flaky for network service only.

TBR=kinuko
NOTRY

Bug:  729849 
Change-Id: Icae3769870fdf59137832f2443d99dda9fad1c92
Reviewed-on: https://chromium-review.googlesource.com/587515
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489869}
[modify] https://crrev.com/3fcf487ab0aaf6a93151ef44d36cd48e23145b70/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 45 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b727846dfb6662085158ad4a5fe0e3c24a8434b

commit 6b727846dfb6662085158ad4a5fe0e3c24a8434b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Jul 28 08:43:46 2017

Gardening: network service: inspector-protocol/cachestorage/read-cached-response.js

Update expectation from Crash to Timeout, after r490305 fixed
the DCHECK failure in ServiceWorkerVersion::OnScriptLoaded().

TBR=kinuko
NOTRY=true

Bug:  715640 ,  729849 
Change-Id: Ibe75c1ef35f417ea66001a272626be617bb2d387
Reviewed-on: https://chromium-review.googlesource.com/590395
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490322}
[modify] https://crrev.com/6b727846dfb6662085158ad4a5fe0e3c24a8434b/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 46 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9aaad30826711122cef9d45c22aae48a7a06df9c

commit 9aaad30826711122cef9d45c22aae48a7a06df9c
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Aug 01 23:26:35 2017

Add NetworkService LayoutTest suppressions.

In particular, add suppressions for some new bluetooth/characteristic/
tests, an inspector-protocol test that's seen recent work, and a
scrollbar test that's falking for unknown reasons.

TBR=rdsmith@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: Ib26bad25b705c9e05c57f588362bcbc9233f5ae5
Reviewed-on: https://chromium-review.googlesource.com/596795
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491151}
[modify] https://crrev.com/9aaad30826711122cef9d45c22aae48a7a06df9c/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 47 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3e39f7f6a46722df37e18750af55ad17ee4b196

commit a3e39f7f6a46722df37e18750af55ad17ee4b196
Author: Matt Menke <mmenke@chromium.org>
Date: Fri Aug 04 20:37:56 2017

Add suppressions for two new layout tests when using the network service

One of them tests clear-site-data, which isn't supportred by the network
service yet, and the other tests ServiceWorker, which is still under
construction.

TBR=rdsmith@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: I4d416a291b6d012ce5b1371b3cf0cdc3c6770faa
Reviewed-on: https://chromium-review.googlesource.com/602769
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492116}
[modify] https://crrev.com/a3e39f7f6a46722df37e18750af55ad17ee4b196/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 48 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2cf2248018da319ffe557f8c709f138b6577f0d

commit b2cf2248018da319ffe557f8c709f138b6577f0d
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Aug 08 16:22:27 2017

Update network service layout test filters.

These are all tests that pass locally now.

BUG= 729849 
TBR=yzshen@chromium.org

Change-Id: Ic449954db7f0bea80a57fb632836bf7ca366c870
Reviewed-on: https://chromium-review.googlesource.com/602598
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492649}
[modify] https://crrev.com/b2cf2248018da319ffe557f8c709f138b6577f0d/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 49 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09e7db5fb9a079996caa62e7ec6e4f53faa9d9ce

commit 09e7db5fb9a079996caa62e7ec6e4f53faa9d9ce
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Aug 08 19:46:33 2017

Fix some resource timing layout tests with network service.

BUG= 729849 

Change-Id: I9e8c9110a02a014bf820de7cab73912fef33f4f2
Reviewed-on: https://chromium-review.googlesource.com/606687
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492732}
[modify] https://crrev.com/09e7db5fb9a079996caa62e7ec6e4f53faa9d9ce/content/network/url_loader_impl.cc
[modify] https://crrev.com/09e7db5fb9a079996caa62e7ec6e4f53faa9d9ce/content/network/url_loader_impl.h
[modify] https://crrev.com/09e7db5fb9a079996caa62e7ec6e4f53faa9d9ce/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 50 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe0ad0d05b38aebdf7e0170ec1c09c29d3810e6e

commit fe0ad0d05b38aebdf7e0170ec1c09c29d3810e6e
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Aug 11 17:45:27 2017

Run external/wpt/offscreen-canvas tests with network service after fix in r493675.

BUG= 729849 
TBR=yzshen@chromium.org

Change-Id: I8b580eb51556ad1f925a96bdf52892ddd6a9b28a
Reviewed-on: https://chromium-review.googlesource.com/612369
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493790}
[modify] https://crrev.com/fe0ad0d05b38aebdf7e0170ec1c09c29d3810e6e/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 51 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1a3148cd4944198ad48453c72dcd0c425e2ddca

commit f1a3148cd4944198ad48453c72dcd0c425e2ddca
Author: John Abd-El-Malek <jam@chromium.org>
Date: Sat Aug 12 00:35:55 2017

Update network service layout test filter with now-passing tests.

BUG= 729849 
NOTRY=true
TBR=yzshen@chromium.org

Change-Id: I29b3172b64eac3a9072094133524f0522c134976
Reviewed-on: https://chromium-review.googlesource.com/612136
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493903}
[modify] https://crrev.com/f1a3148cd4944198ad48453c72dcd0c425e2ddca/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 52 by bugdroid1@chromium.org, Aug 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88250ead34d7102de4f53faf8ea48749e6f675c7

commit 88250ead34d7102de4f53faf8ea48749e6f675c7
Author: John Abd-El-Malek <jam@chromium.org>
Date: Sun Aug 13 04:45:08 2017

More updates to network service layout test expectations.

BUG= 729849 
TBR=yzshen@chromium.org
NOTRY=true

Change-Id: I2da305f45a6816beaea966eb56e3929f4f1147e5
Reviewed-on: https://chromium-review.googlesource.com/612326
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493991}
[modify] https://crrev.com/88250ead34d7102de4f53faf8ea48749e6f675c7/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 53 by bugdroid1@chromium.org, Aug 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bd2a66bac6680691e7422654d415841c9cd0ff3

commit 9bd2a66bac6680691e7422654d415841c9cd0ff3
Author: John Abd-El-Malek <jam@chromium.org>
Date: Sun Aug 13 23:41:27 2017

More updates to network service layout test expectations.

BUG= 729849 
TBR=yzshen@chromium.org
NOTRY=true

Change-Id: Id32f99bb5ed0a7716117b1d46fa3bb0d8e6f795a
Reviewed-on: https://chromium-review.googlesource.com/612751
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494002}
[modify] https://crrev.com/9bd2a66bac6680691e7422654d415841c9cd0ff3/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 54 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8b979cf239c9912d73db887d8d81fb26e455b8d

commit d8b979cf239c9912d73db887d8d81fb26e455b8d
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Aug 14 14:20:45 2017

More updates to network service layout test expectations.

BUG= 729849 
TBR=yzshen@chromium.org
NOTRY=true

Change-Id: If957c4f28fb4fe9a0663e42d36cdfadd382471bb
Reviewed-on: https://chromium-review.googlesource.com/613460
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494046}
[modify] https://crrev.com/d8b979cf239c9912d73db887d8d81fb26e455b8d/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 55 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2da9dade6f32e245ae78cc788086ea7087b2c7b8

commit 2da9dade6f32e245ae78cc788086ea7087b2c7b8
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Aug 18 20:33:00 2017

Implement document.cookie with network service.

This fixes a bunch of external/wpt/content-security-policy layout tests.

BUG= 729849 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ib179b66c5e5006797acce55a9996082a065825aa
Reviewed-on: https://chromium-review.googlesource.com/614387
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495671}
[modify] https://crrev.com/2da9dade6f32e245ae78cc788086ea7087b2c7b8/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/2da9dade6f32e245ae78cc788086ea7087b2c7b8/content/browser/frame_host/render_frame_message_filter.h
[modify] https://crrev.com/2da9dade6f32e245ae78cc788086ea7087b2c7b8/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 56 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68036ba8ede0cebdc9d743175bb1cc654e8d5bf3

commit 68036ba8ede0cebdc9d743175bb1cc654e8d5bf3
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Tue Aug 22 10:21:19 2017

LayoutTest expectation updates for enable-featulres=NetworkService

New external/wpt/WebCryptoAPI/generateKey tests start to fail.

TBR=jam@chromium.org

Bug:  729849 
Change-Id: Ie25f38af78de3c7b4e18233dea3bdd3552c712cc
Reviewed-on: https://chromium-review.googlesource.com/625611
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496270}
[modify] https://crrev.com/68036ba8ede0cebdc9d743175bb1cc654e8d5bf3/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 57 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be1651f243a9dbe2404dc37b705adb090478749d

commit be1651f243a9dbe2404dc37b705adb090478749d
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Wed Aug 23 08:44:26 2017

LayoutTest expectation updates for enable-featulres=NetworkService

- Add http/tests/xmlhttprequest/simple-cross-origin-progress-events.html,
  which started around r496602-r496604 but no obvious culprit
  (The console ouput that differs comes from
  DocumentThreadableLoader.cpp)

- Looks like it's flaky, adding 'Failure Pass' expectation

TBR=jam@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: I44f0bd48e989dd8f2ba17ccf10a39d1cffe56ee9
Reviewed-on: https://chromium-review.googlesource.com/627948
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496631}
[modify] https://crrev.com/be1651f243a9dbe2404dc37b705adb090478749d/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 58 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b97f5f9b5a737742f658a15e2e021fc02ae1f302

commit b97f5f9b5a737742f658a15e2e021fc02ae1f302
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Aug 23 21:35:12 2017

Enable network service layout test that now pass.

BUG= 729849 
TBR=kinuko@chromium.org
NOTRY=true

Change-Id: Ia72534f4bf0a8caa912307af5750d97769f45e21
Reviewed-on: https://chromium-review.googlesource.com/629779
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496812}
[modify] https://crrev.com/b97f5f9b5a737742f658a15e2e021fc02ae1f302/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 59 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44a809385f9798f2ee87441f30e40bee67f43366

commit 44a809385f9798f2ee87441f30e40bee67f43366
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Aug 24 05:33:49 2017

Enable more network service layout test that now pass.

BUG= 729849 
TBR=kinuko@chromium.org
NOTRY=true

Change-Id: I6cfd9abc1fa1fc8a1bb45e12015271c3933ab364
Reviewed-on: https://chromium-review.googlesource.com/630563
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496958}
[modify] https://crrev.com/44a809385f9798f2ee87441f30e40bee67f43366/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 60 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24f2f03086473b4d7303e2933a06ca032ddfda33

commit 24f2f03086473b4d7303e2933a06ca032ddfda33
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Thu Aug 24 14:42:00 2017

Re-add http/tests/payments/payment-request-event.html to NetworkService test filter

This was enabled in r496958 but it looks this one's still super flaky among others.

TBR=jam@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: Ia3f8ed37b163d0e3a7316215f2469c3079fc7166
Reviewed-on: https://chromium-review.googlesource.com/632756
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497038}
[modify] https://crrev.com/24f2f03086473b4d7303e2933a06ca032ddfda33/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 61 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/570164f481bbcbfc14733adf2fed19876a84e160

commit 570164f481bbcbfc14733adf2fed19876a84e160
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Aug 24 15:52:22 2017

Disable a few layout tests with network service that are flaky.

BUG= 729849 
TBR=kinuko@chromium.org
NOTRY=true

Change-Id: I1dbef605ea5c0602c1bedcfbe80a85d485908d01
Reviewed-on: https://chromium-review.googlesource.com/633017
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497062}
[modify] https://crrev.com/570164f481bbcbfc14733adf2fed19876a84e160/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 62 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8fe68ef4a32327c35681eb1eb88874e0884d0ec

commit f8fe68ef4a32327c35681eb1eb88874e0884d0ec
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Aug 24 19:42:29 2017

Revert "LayoutTest expectation updates for enable-featulres=NetworkService"

This reverts commit 68036ba8ede0cebdc9d743175bb1cc654e8d5bf3.

Reason for revert: these fail without network service and are disabled in that file as well

Original change's description:
> LayoutTest expectation updates for enable-featulres=NetworkService
> 
> New external/wpt/WebCryptoAPI/generateKey tests start to fail.
> 
> TBR=jam@chromium.org
> 
> Bug:  729849 
> Change-Id: Ie25f38af78de3c7b4e18233dea3bdd3552c712cc
> Reviewed-on: https://chromium-review.googlesource.com/625611
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496270}

TBR=kinuko@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: I584641ba1f8a309a656d433c7b0c6693f23a45f6
Reviewed-on: https://chromium-review.googlesource.com/634063
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497158}
[modify] https://crrev.com/f8fe68ef4a32327c35681eb1eb88874e0884d0ec/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 63 by jam@chromium.org, Aug 24 2017

Blockedon: 758675
Project Member

Comment 64 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/864c0cdc8ba5a2239ec1fc4ee92fede872d3aebe

commit 864c0cdc8ba5a2239ec1fc4ee92fede872d3aebe
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Fri Aug 25 07:57:10 2017

Add a devtools test that fails with NetworkService to the filter

http/tests/devtools/console/console-uncaught-promise.html
This was renamed from http/tests/inspector/console in r497249,
but doesn't pass with NetworkService. (Will look a little further
but disabling for now)

TBR=jam@chromium.org
NOTRY=true

Bug:  721408 ,  729849 
Change-Id: I53d6474af5764844281a6eb4209884ba1b4ec776
Reviewed-on: https://chromium-review.googlesource.com/634964
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497351}
[modify] https://crrev.com/864c0cdc8ba5a2239ec1fc4ee92fede872d3aebe/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 65 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7efd31459287e43e63aaca6e8e7cb97712fc043f

commit 7efd31459287e43e63aaca6e8e7cb97712fc043f
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Aug 25 16:35:17 2017

Disable new layout test that fails with network service.

This got added in r497419

BUG= 729849 
TBR=kinuko@chromium.org
NOTRY=true

Change-Id: Ib099cd2cd29d841113e97b6fec67fcb491c62370
Reviewed-on: https://chromium-review.googlesource.com/635944
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497436}
[modify] https://crrev.com/7efd31459287e43e63aaca6e8e7cb97712fc043f/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 66 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bee4014906cb2fcecffdd38fcec2e55b71d17d1

commit 3bee4014906cb2fcecffdd38fcec2e55b71d17d1
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Aug 30 09:04:00 2017

Gardening: Mark two failing tests on NetworkService

* properties.serviceworker.https.html is a new test that is failing.

* methods-lower-case.html was passing but started failing today, and there
is no clear culprit. It sometimes crashes with:
[28212:28238:0830/001951.964346:5141811333:FATAL:url_loader_impl.cc(446)] Check failed: result == MOJO_RESULT_OK (9 vs. 0)

Example build: https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/4755

NOTRY=true
TBR=kinuko

Bug:  729849 
Change-Id: I3ce4d7ae6902463df0b9da91a5d74d3c92d5ed92
Reviewed-on: https://chromium-review.googlesource.com/642866
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498404}
[modify] https://crrev.com/3bee4014906cb2fcecffdd38fcec2e55b71d17d1/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Blockedon: 760831
Project Member

Comment 68 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/381b682f0f3d3d42935b5792b6871b73c46a34c5

commit 381b682f0f3d3d42935b5792b6871b73c46a34c5
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Sep 08 15:45:33 2017

Disable layout tests broken for network service when landed or by test rewrite

These tests believed broken by https://chromium-review.googlesource.com/651134.

NOTRY=true
TBR=mmenke@chromium.org

Bug:  729849 
Change-Id: I4d4a2c1365e7ea28903cd82d06e9ea3367c89165
Reviewed-on: https://chromium-review.googlesource.com/655837
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500598}
[modify] https://crrev.com/381b682f0f3d3d42935b5792b6871b73c46a34c5/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 69 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e28a5add1470df291bf21f2658849fe959e1d13f

commit e28a5add1470df291bf21f2658849fe959e1d13f
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Sep 08 17:24:42 2017

Disable mojo bot flakily failing streams/serviceworker test.

The
external/wpt/streams/readable-byte-streams/brand-checks.serviceworker.https.html
layout test has been failing sporadically since
https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/5002
(spanning pseudo-revisions 499938 - 499943).  The problem is believed
caused by http://crrev.com/1c1f284d841949925f1bda049cc9a89bbdc2f9c7 /
p499939, which changed that file.

TBR=mmenke@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: I898fe7aab7a1121919651f4bdfa2e33e2de13191
Reviewed-on: https://chromium-review.googlesource.com/658099
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500616}
[modify] https://crrev.com/e28a5add1470df291bf21f2658849fe959e1d13f/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 70 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80053630268784301e1cb50678f5e1c340d0cc30

commit 80053630268784301e1cb50678f5e1c340d0cc30
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Sep 08 20:57:51 2017

Disable sporadically failing tests on the Mojo bot without any obvious
triggering CLs:

external/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html
started failing in
https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/5080,
which ranged between pseudo revisions 500577 - 500578.

http/tests/devtools/sources/debugger-ui/source-frame-count.html
started failing in
https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/5037
which ranged between psuedo revisions 500279 - 500282.

TBR=mmenke@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: Iab6e34cf12a490de4804532eb7e480e03e7ed67d
Reviewed-on: https://chromium-review.googlesource.com/658222
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500656}
[modify] https://crrev.com/80053630268784301e1cb50678f5e1c340d0cc30/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 71 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27177110e12118cae81f65fd0e2250b417acf9f8

commit 27177110e12118cae81f65fd0e2250b417acf9f8
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Sep 08 21:25:40 2017

Disable sporadically failing test on Mojo FYI bot.

The test
fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html
is sporadically failing on the Mojo FYI bot.  It was first seen in
https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/5045.
I suspect root cause is
http://crrev.com/15fd3f0688b8ff96119b89a7f655b425b8fca3d9 (500314) as
that changed modified a set of WebKit layout tests, including this
one, and that change was in
https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/5044.

NOTRY=true
TBR=mmenke@chromium.org

Bug:  729849 
Change-Id: Idd4e0fc133e1d9a96434da74a5cb5a6b355a59a8
Reviewed-on: https://chromium-review.googlesource.com/658279
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500681}
[modify] https://crrev.com/27177110e12118cae81f65fd0e2250b417acf9f8/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 72 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/673c29ef93dea06e623048e42f96f26c44081117

commit 673c29ef93dea06e623048e42f96f26c44081117
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Sep 08 21:46:17 2017

Disable bluetooth device tests failing on the Mojo FYI bot.

The following tests started failing in
https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/5089,
almost certainly due to
http://crrev.com/101c6038ed5ff103977081bde8fdd2025633553a, which
was one of the CLs in that build and modified exactly these four
tests.

bluetooth/device/gattserverdisconnected-event/disconnected.html
bluetooth/device/gattserverdisconnected-event/disconnected_gc.html
bluetooth/device/gattserverdisconnected-event/one-event-per-disconnection.html
bluetooth/device/gattserverdisconnected-event/reconnect-during-disconnected-event.html

NOTRY=true
TBR=mmenke@chromium.org

Bug:  729849 
Change-Id: Icbcacdc74c726b2d1f9c2c809d058c04b605e94e
Reviewed-on: https://chromium-review.googlesource.com/658281
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500703}
[modify] https://crrev.com/673c29ef93dea06e623048e42f96f26c44081117/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 73 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b205f7d5359bbf7703a878bf5bbfdb17e644be5e

commit b205f7d5359bbf7703a878bf5bbfdb17e644be5e
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Sep 08 23:56:18 2017

Disable test inconsistently failing on the Mojo FYI bot.

The test
http/tests/media/video-buffered-range-contains-currentTime.html is
sporadically failing on the Mojo FYI bot starting in
https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/5046.
The two possible CLs that might have caused this behavior are:

* http://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30: Touched
  the expectations for this test, but it landed two builds before the one
  that the failure first appeared in.  I suspect this is root cause.
* http://crrev.com/f144ed8ee752b61f0607e458ba1a6427219c021b  adds
  retry logic to media, and hence might be related; it landed in the
  same build as the failure first appeared.

TBR=mmenke@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: Ib03bcef038a2d1ecd7b503d0563c90ea611515c7
Reviewed-on: https://chromium-review.googlesource.com/658224
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500745}
[modify] https://crrev.com/b205f7d5359bbf7703a878bf5bbfdb17e644be5e/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Blockedon: 766239
Blockedon: 766240
Project Member

Comment 76 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bdf1625e816838b2a545f6a4e845770f4613e3e

commit 0bdf1625e816838b2a545f6a4e845770f4613e3e
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Tue Sep 19 21:53:32 2017

Update layout test filter for network service.

Mark the following test with Timeout:
http/tests/appcache/local-content.html

BUG= 729849 
TBR=mmenke@chromium.org

Change-Id: I52c4c9c91c6dc0d68c520fbe5e47ed3e7f8e9345
Reviewed-on: https://chromium-review.googlesource.com/673803
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502962}
[modify] https://crrev.com/0bdf1625e816838b2a545f6a4e845770f4613e3e/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 77 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb3def99716b6a07ba9a0cfb532575be2d8d6db

commit fbb3def99716b6a07ba9a0cfb532575be2d8d6db
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Thu Sep 28 22:06:29 2017

Network service: update layout test filter

Suppress failure of
paint/invalidation/video-paint-invalidation.html

This seems likely to be related to the recent change in the main failure
suppression file:
https://chromium-review.googlesource.com/c/chromium/src/+/690624

BUG= 729849 
TBR=jam@chromium.org

Change-Id: I656f6f318b4b850c21682bfaf52a299e6346dd4f
Reviewed-on: https://chromium-review.googlesource.com/691066
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505181}
[modify] https://crrev.com/fbb3def99716b6a07ba9a0cfb532575be2d8d6db/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 78 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3067f7bb98c64b1548ac6ec2c3aa6fb8d32db898

commit 3067f7bb98c64b1548ac6ec2c3aa6fb8d32db898
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Oct 17 23:24:09 2017

Enable virtual tests in Network Service LayoutTests

These tests were blanket disabled when the number of failing LayoutTests
with the Network Service enabled was very high. Now that the number of
failures is more under control we should enable them.

The mojo-loading virtual tests are explicitly skipped since enabling the
Network Service also enables Mojo Loading and so the test coverage is
redundant.

TBR=jam@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: I33abad9d8a7cfe6cf498985d786dcc4294ae5229
Reviewed-on: https://chromium-review.googlesource.com/724081
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509586}
[modify] https://crrev.com/3067f7bb98c64b1548ac6ec2c3aa6fb8d32db898/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 79 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0036dfe09c6e86da7865e32de36cfade1341d9c8

commit 0036dfe09c6e86da7865e32de36cfade1341d9c8
Author: Reilly Grant <reillyg@chromium.org>
Date: Wed Oct 18 21:09:39 2017

Skip mojo-blobs virtual test suite on Network Service builder

Like mojo-loading, the mojo-blobs virtual test suite is redundant when
running LayoutTests on the Network Service builder because the MojoBlobs
flag is implied by enabling the Network Service.

TBR=jam@chromium.org

Bug:  729849 
Change-Id: I6a9d1a7ca6a019fff49994d104da0379627f9644
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/726699
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509874}
[modify] https://crrev.com/0036dfe09c6e86da7865e32de36cfade1341d9c8/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 80 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8efc9dab96dae0426d8e42f343a2ca3c9ef42d6

commit c8efc9dab96dae0426d8e42f343a2ca3c9ef42d6
Author: Reilly Grant <reillyg@chromium.org>
Date: Wed Oct 18 23:44:39 2017

Enable a lot more LayoutTests with Network Service

These tests appear to be passing and should be enabled.

TBR=jam@chromium.org

Bug:  729849 , 721408 ,611935
Change-Id: I163023024f2f94c8b6031f7f2c3a4ec85f2f2ada
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/724282
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509932}
[modify] https://crrev.com/c8efc9dab96dae0426d8e42f343a2ca3c9ef42d6/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 81 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3

commit 0cb50f7d34bd099ab044e62efe20706a0ddb0bb3
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Oct 20 05:06:44 2017

Hook up upload progress events when the network service is used.

BUG= 729849 

Change-Id: I7d047b9f88ec36e6d4f54bda10a08ce5deaa0198
Reviewed-on: https://chromium-review.googlesource.com/728409
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510347}
[modify] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/browser/BUILD.gn
[delete] https://crrev.com/4feb7f8f6b91a36f23c727bc90f83f826ef62fec/content/browser/loader/DEPS
[modify] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/browser/loader/async_resource_handler.cc
[modify] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/browser/loader/mojo_async_resource_handler.h
[modify] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/network/BUILD.gn
[rename] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/network/upload_progress_tracker.cc
[rename] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/network/upload_progress_tracker.h
[rename] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/network/upload_progress_tracker_unittest.cc
[modify] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/network/url_loader_impl.cc
[modify] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/network/url_loader_impl.h
[modify] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/content/test/BUILD.gn
[modify] https://crrev.com/0cb50f7d34bd099ab044e62efe20706a0ddb0bb3/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 82 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5625b2a54a34749667cb2136e9f45a27bcdb1cd1

commit 5625b2a54a34749667cb2136e9f45a27bcdb1cd1
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Oct 20 18:02:35 2017

Disable new LayoutTests failing with Network Service

These tests are new and fail or timeout.

TBR=jam@chromium.org

Bug:  729849 , 721408 
Change-Id: Id40c1e246aedb8a68ebb1fac67573f6edc7529f0
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/731108
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510487}
[modify] https://crrev.com/5625b2a54a34749667cb2136e9f45a27bcdb1cd1/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 83 by dougt@chromium.org, Oct 20 2017

Components: Internals>Network>Service
Project Member

Comment 84 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a04d01befbf4544aa4363bd3be8616875a2de65

commit 8a04d01befbf4544aa4363bd3be8616875a2de65
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Oct 24 01:13:01 2017

Update network service layout tests filter with now-succeededing tests.

BUG= 729849 

Change-Id: I7ea4d4a50bd2eecc15ed70412f2318db9d1c862d
Reviewed-on: https://chromium-review.googlesource.com/734021
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510970}
[modify] https://crrev.com/8a04d01befbf4544aa4363bd3be8616875a2de65/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Blockedon: 778721
Project Member

Comment 86 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b02ff578db5d29306155c50354a3ecaab41d31b

commit 0b02ff578db5d29306155c50354a3ecaab41d31b
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Tue Oct 31 09:27:27 2017

NetworkService: Add some flaky layout tests to FlagExpectations

From flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&showFlaky=true&builder=chromium.fyi%3AMojo%20Linux

There're more, but adding a few ones that often show flakes (which is
confusing while looking into other flaky issues)

TBR=jam@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: I1d862a944f7e1c3a5b792f9783ae56b31ddfdeed
Reviewed-on: https://chromium-review.googlesource.com/746053
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512787}
[modify] https://crrev.com/0b02ff578db5d29306155c50354a3ecaab41d31b/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 87 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5734f6cffa1a71c25043ee82ec7e67c0f3e06756

commit 5734f6cffa1a71c25043ee82ec7e67c0f3e06756
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Oct 31 09:41:55 2017

Disable failing tests when the network service is enabled.

SafeBrowsingTriggeredInterceptingBrowserTest.AbusiveMetadata: new test.
SSLUITestCommittedInterstitials.ErrorPageType: new test.

virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html:
old test, flaking a lot (And did my last shift, too).

TBR=mmenke@chromium.org

Bug:  729849 , 756009 , 756089 , 778857 
Change-Id: I08ef0853db0d709e57ce2eb4ca1d3ac3960b6bcc
Reviewed-on: https://chromium-review.googlesource.com/746363
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512791}
[modify] https://crrev.com/5734f6cffa1a71c25043ee82ec7e67c0f3e06756/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/5734f6cffa1a71c25043ee82ec7e67c0f3e06756/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Project Member

Comment 88 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3afe31c1ce2fdf0b7981d3a7e73d2031dbd2d02c

commit 3afe31c1ce2fdf0b7981d3a7e73d2031dbd2d02c
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Oct 31 13:41:48 2017

Mark external/wpt/beacon/headers/header-content-type.html as Slow

Bug:  779965 , 626703,  729849 
Change-Id: I795f9a2a22b886bc70301452adbab626ab324b99
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/746487
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512820}
[modify] https://crrev.com/3afe31c1ce2fdf0b7981d3a7e73d2031dbd2d02c/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/3afe31c1ce2fdf0b7981d3a7e73d2031dbd2d02c/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/3afe31c1ce2fdf0b7981d3a7e73d2031dbd2d02c/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 89 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d6eacfc0a32b1b9060e637ec2d7e0539d3abfbb

commit 8d6eacfc0a32b1b9060e637ec2d7e0539d3abfbb
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Thu Nov 02 13:06:54 2017

NetworkService: suppress more failing tests

New failing tests:
virtual/mouseevent_fractional/fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
(I haven't looked into the details for this one)

A new test in the same existing category:
NavigationHandleImplBrowserTest.ThrottleFailureWithErrorPageContent
Added in
https://chromium.googlesource.com/chromium/src/+/a15d3fccbc47ad0f54c5f24c135e5b1918007499

TBR=jam@chromium.org
NOTRY=true

Bug:  729848 ,  729849 
Change-Id: I769bec8c7415d0c66bf96bd3e19125cffe40d246
Reviewed-on: https://chromium-review.googlesource.com/750923
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513471}
[modify] https://crrev.com/8d6eacfc0a32b1b9060e637ec2d7e0539d3abfbb/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
[modify] https://crrev.com/8d6eacfc0a32b1b9060e637ec2d7e0539d3abfbb/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 90 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7ca6e7465a6c7bf802d551b9575ce067fa8de57

commit a7ca6e7465a6c7bf802d551b9575ce067fa8de57
Author: Matt Menke <mmenke@chromium.org>
Date: Mon Nov 06 23:07:12 2017

Mark a layout test as failing when the network service is enabled.

http/tests/devtools/sources/compile-javascript.js is failing maybe
15-20% of the time on the bot.

TBR=rdsmith@chromium.org
NOTRY=true

Bug:  729849 
Change-Id: Ie65afe4eec2a40b24aa8c5185500294e79166db3
Reviewed-on: https://chromium-review.googlesource.com/755795
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514276}
[modify] https://crrev.com/a7ca6e7465a6c7bf802d551b9575ce067fa8de57/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 92 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44542fba7e29f76987cec86748f48b512b3f97bf

commit 44542fba7e29f76987cec86748f48b512b3f97bf
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Nov 27 07:36:47 2017

Gardening: NetworkService: flaky external/wpt/XMLHttpRequest/anonymous-mode-unsupported.htm

This test is flaky recently on the flakiness dashboard but I'm not sure why. It fails
locally only when running the whole XMLHttpRequest suite many times:
run-webkit-tests  --target=Default  --additional-driver-flag="--enable-features=NetworkService" --iterations=100  external/wpt/XMLHttpRequest

Bug:  729849 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iba2471e5e181a3ae0d1abeb13f76e815bd696f9a
TBR: kinuko
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/790191
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519237}
[modify] https://crrev.com/44542fba7e29f76987cec86748f48b512b3f97bf/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 93 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f325c595e959728ee5258327ca33aa17c1c440b

commit 1f325c595e959728ee5258327ca33aa17c1c440b
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Mon Dec 18 21:54:04 2017

Network service layout tests: Update filter to mark a test as flaky.

external/wpt/service-workers/service-worker/skip-waiting-using-registration.https.html

BUG= 729849 
TBR=jam@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3f17e6f0cee0e088a6a3aab58f2b693d80f0296b
Reviewed-on: https://chromium-review.googlesource.com/833230
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524816}
[modify] https://crrev.com/1f325c595e959728ee5258327ca33aa17c1c440b/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 94 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c77ef3d1e3597ae1082e6925a343667e9b42ea1

commit 3c77ef3d1e3597ae1082e6925a343667e9b42ea1
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Fri Dec 22 00:55:22 2017

Add missing interface in service manifest.

This fixes the following layout tests with Network Service:
 external/wpt/credential-management/federatedcredential-framed-get.sub.https.html
 external/wpt/credential-management/passwordcredential-framed-get.sub.https.html

BUG= 729849 

Change-Id: Ib61abb8650bf262d2bf7532c6998b42ab1fcf392
Reviewed-on: https://chromium-review.googlesource.com/841124
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525879}
[modify] https://crrev.com/3c77ef3d1e3597ae1082e6925a343667e9b42ea1/content/public/app/mojo/content_browser_manifest.json

Project Member

Comment 95 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86de00c81525df46df206f525fca1463a18fea1f

commit 86de00c81525df46df206f525fca1463a18fea1f
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Mon Jan 08 18:26:03 2018

Network service: update layout test filter.

This CL marks a few new tests as timeout:
*
external/wpt/fetch/api/request/destination/fetch-destination-iframe.https.html
*
external/wpt/fetch/api/request/destination/fetch-destination-no-load-event.https.html
*
external/wpt/fetch/api/request/destination/fetch-destination-worker.https.html

And also marks an existing test as flaky:
* external/wpt/websockets/opening-handshake/003.html?wss

BUG= 729849 
TBR=jam@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6d7237990331874ff3b2db757db99a90513cca11
Reviewed-on: https://chromium-review.googlesource.com/854756
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527676}
[modify] https://crrev.com/86de00c81525df46df206f525fca1463a18fea1f/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 96 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11781e63dad7018e36e54bb7770b94dc7915c380

commit 11781e63dad7018e36e54bb7770b94dc7915c380
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Mon Jan 08 20:00:11 2018

Network service: update layout test filter.

This CL change the cause from Timeout to Failure for:
*
external/wpt/fetch/api/request/destination/fetch-destination-iframe.https.html

BUG= 729849 
TBR=jam@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib71efe04c269181e86d4fd7eec10bdf6428db63e
Reviewed-on: https://chromium-review.googlesource.com/854752
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527723}
[modify] https://crrev.com/11781e63dad7018e36e54bb7770b94dc7915c380/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 97 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60e77b2755aea7ffcdabe450c85c2af0e770a3c2

commit 60e77b2755aea7ffcdabe450c85c2af0e770a3c2
Author: Randy Smith <rdsmith@chromium.org>
Date: Wed Jan 17 00:25:38 2018

Adding webkit_layout_test failing on the mojo.fyi bot to the exlusion list.

Failing test is virtual/layout_ng/fast/inline/positioned-object-between-replaced-elements.html.  Started failing at r529490.

TBR=kinuko@chromium.org

Bug:  729849 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic563d266389f9c1137f8d90378c01da4deb435e2
Reviewed-on: https://chromium-review.googlesource.com/868242
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529526}
[modify] https://crrev.com/60e77b2755aea7ffcdabe450c85c2af0e770a3c2/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 98 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e77b68f03ad0e2d1aac08c2c67dcf7f11ae88605

commit e77b68f03ad0e2d1aac08c2c67dcf7f11ae88605
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Mar 07 02:25:47 2018

Enable now-passing layout tests with the network service.

Bug:  729849 ,  783982 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I245aeff1ca10a77da6debb62fbae4b2dbd0fcd4e
Reviewed-on: https://chromium-review.googlesource.com/952480
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541292}
[modify] https://crrev.com/e77b68f03ad0e2d1aac08c2c67dcf7f11ae88605/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 99 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2edfb0cafc9cd5d498be391b412c97f3f46df460

commit 2edfb0cafc9cd5d498be391b412c97f3f46df460
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Apr 26 00:01:55 2018

Enable now-passing layout tests with network service.

Bug:  729849 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I28f621849bbc3260df2cd818a1daf58c5969755f
Reviewed-on: https://chromium-review.googlesource.com/1029009
Reviewed-by: Chong Zhang <chongz@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553833}
[modify] https://crrev.com/2edfb0cafc9cd5d498be391b412c97f3f46df460/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 100 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c62b80416339ebdccc010a422962e682adb9c0c0

commit c62b80416339ebdccc010a422962e682adb9c0c0
Author: Helen Li <xunjieli@chromium.org>
Date: Thu May 03 13:51:29 2018

Update test filters for --enable-network-service

This CSP test fails when network service flag is on.
wpt/content-security-policy/inside-worker/dedicated-inheritance.html

TBR=jam@chromium.org

Bug:  729849 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5488b1eb50040792f84d0cbf9efd3c1d68fcaf2d
Reviewed-on: https://chromium-review.googlesource.com/1041405
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555711}
[modify] https://crrev.com/c62b80416339ebdccc010a422962e682adb9c0c0/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 101 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78e55869cab987a696341ea4d955561fbe9aa195

commit 78e55869cab987a696341ea4d955561fbe9aa195
Author: Chong Zhang <chongz@chromium.org>
Date: Wed May 16 17:43:23 2018

Update test filter for --enable-network-service

The test times out randomly (~10%) since Build #13171:
http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html

TBR=jam@chromium.org

Bug:  729849 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2eec60a97836aff470894faaaebc2e3260cce996
Reviewed-on: https://chromium-review.googlesource.com/1062073
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559169}
[modify] https://crrev.com/78e55869cab987a696341ea4d955561fbe9aa195/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 102 by dxie@chromium.org, May 22 2018

Labels: Proj-Servicification-Canary OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)
Labels: -Proj-Servicification-Canary Proj-Servicification
Project Member

Comment 105 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9ae176893a79142db9851d24ee2a9133419d5b1

commit f9ae176893a79142db9851d24ee2a9133419d5b1
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Aug 14 15:08:55 2018

Fix pages with feed mime types not being rendered as plain text with network service.

This matches the old path's mime_sniffing_resource_handler.cc.

Bug:  729849 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I7afd5ac3d595ddcea5b061dd064e4413eab590df
Reviewed-on: https://chromium-review.googlesource.com/1173764
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582916}
[modify] https://crrev.com/f9ae176893a79142db9851d24ee2a9133419d5b1/services/network/url_loader.cc
[modify] https://crrev.com/f9ae176893a79142db9851d24ee2a9133419d5b1/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Labels: Hotlist-KnownIssue
Blockedon: 910011
Blockedon: 910212
Project Member

Comment 109 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b9928ad2b2b1c8b4b146d6f03abc0b134a9eac7

commit 0b9928ad2b2b1c8b4b146d6f03abc0b134a9eac7
Author: Eric Roman <eroman@chromium.org>
Date: Thu Nov 29 19:59:08 2018

Update web_tests expectations with bug numbers.

Bug:  910212 , 729849 
Change-Id: Iff0a02015b4b6dabfeff5b3865468df70748ddd6
Reviewed-on: https://chromium-review.googlesource.com/c/1355492
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612329}
[modify] https://crrev.com/0b9928ad2b2b1c8b4b146d6f03abc0b134a9eac7/third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 110 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4dd1ebf87c73c1d1995142afa6698ce600a32c9

commit e4dd1ebf87c73c1d1995142afa6698ce600a32c9
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Dec 03 05:39:19 2018

Gardening: Followup on NetworkService and virtual tests

FlagExpectations for NetworkService had failing expectations for
"cors-rfc1918" (including both non-virtual and virtual suites), but
this is already Skipped in the root TestExpectations
directory. Therefore the expectations had no effect, so remove
them.

Also, skip virtual/outofblink-cors entirely, since
these are intended to be run with NetworkService off.

Note that virtual tests were never actually run
with NetworkService on on the NetworkService bot until
last week (see  https://crbug.com/908654 ).

Bug:  729849 
Change-Id: I34f502f23fe026869daacbaf6cacf771195a6910
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1356736
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613007}
[modify] https://crrev.com/e4dd1ebf87c73c1d1995142afa6698ce600a32c9/third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService

Status: Fixed (was: Available)
Project Member

Comment 112 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf5d7cd68ffbca492b82d21388aa0f2fed428b5

commit cdf5d7cd68ffbca492b82d21388aa0f2fed428b5
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Jan 07 23:44:54 2019

Remove a passing layout test from network service filter and add a comment to not add any more entries.

Bug:  729849 
Change-Id: I2473334c07986b12879c25145ef6fdaf4a06cf04
Reviewed-on: https://chromium-review.googlesource.com/c/1399522
Reviewed-by: Doug Turner <dougt@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620528}
[modify] https://crrev.com/cdf5d7cd68ffbca492b82d21388aa0f2fed428b5/third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService

Showing comments 13 - 112 of 112 Older

Sign in to add a comment