New issue
Advanced search Search tips

Issue 729848 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 760831
issue 841557

Blocking:
issue 598073



Sign in to add a comment

Fix content_browsertests with Network Service

Project Member Reported by jam@chromium.org, Jun 6 2017

Issue description

Tracking bug to fix all remaining failures.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd6fde27bfccfa78dccea610c81fec38de27a1a2

commit dd6fde27bfccfa78dccea610c81fec38de27a1a2
Author: mmenke <mmenke@chromium.org>
Date: Mon Jun 26 17:55:45 2017

Disable two PowerMonitorTests when using the NetworkService.

One of two content_browsertests was broken in
https://chromium-review.googlesource.com/c/535057/, and the other test
was added in that same CL.

TBR=jam@chromium.org

BUG= 729848 

Review-Url: https://codereview.chromium.org/2959773002
Cr-Commit-Position: refs/heads/master@{#482315}

[modify] https://crrev.com/dd6fde27bfccfa78dccea610c81fec38de27a1a2/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b98b8c85d3bb5969c3d3c17851acc40e032e2dca

commit b98b8c85d3bb5969c3d3c17851acc40e032e2dca
Author: jam <jam@chromium.org>
Date: Wed Jun 28 01:08:42 2017

Cache the NetworkService interface pointer in the browser.

The NetworkService interface is meant to be used as a signleton, so rather than have it contain a BindingSet just cache the pointer in the browser.

This fixes
DOMStorageBrowserTest.SanityCheckIncognito
DatabaseTest.OffTheRecordCannotReadRegularDatabase
DatabaseTest.OffTheRecordDBPersistentAcrossWindows
when run in debug or release-with-asserts.

BUG= 729848 

Review-Url: https://codereview.chromium.org/2958173002
Cr-Commit-Position: refs/heads/master@{#482834}

[modify] https://crrev.com/b98b8c85d3bb5969c3d3c17851acc40e032e2dca/content/browser/storage_partition_impl.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c626f896305f75baf70b6a8dd141fd12bca4345

commit 5c626f896305f75baf70b6a8dd141fd12bca4345
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Jul 24 19:15:11 2017

Fix the host resolver with out of process network service.

This started failing after r488800 since some rules are now kResolverTypeIPLiteral. Proxy those over as well.

BUG= 729848 

Change-Id: I2a8d9974f5e7cacfc1e4c2031ccfb5a6629edbfa
Reviewed-on: https://chromium-review.googlesource.com/583511
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489042}
[modify] https://crrev.com/5c626f896305f75baf70b6a8dd141fd12bca4345/content/public/test/browser_test_base.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/462f2d60403f3269cbd4f343698bdacd760be0d7

commit 462f2d60403f3269cbd4f343698bdacd760be0d7
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Aug 11 22:59:07 2017

Disable 2 new content_browsertests with network service.

They failed since they got added today.

BUG= 729848 
TBR=yzshen@chromium.org
NOTRY=true

Change-Id: I2f6516ffff261b6b10e8dc7b00d5470b6183e596
Reviewed-on: https://chromium-review.googlesource.com/612052
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493877}
[modify] https://crrev.com/462f2d60403f3269cbd4f343698bdacd760be0d7/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e4722e5e15f806ae7f7eeafd9b480fae87dc879

commit 9e4722e5e15f806ae7f7eeafd9b480fae87dc879
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Aug 16 00:38:20 2017

Disable DevToolsProtocolTest.CertificateExplanations with network service.

It failed since it was added in r494478

BUG= 729848 
TBR=yzshen@chromium.org
NOTRY=true

Change-Id: Ibeef76a549afd8ba0ae43e21d55c343e51fc81c1
Reviewed-on: https://chromium-review.googlesource.com/615787
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494635}
[modify] https://crrev.com/9e4722e5e15f806ae7f7eeafd9b480fae87dc879/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a624c6cf6ab03d9c760c052698d5bbba0edd55e

commit 5a624c6cf6ab03d9c760c052698d5bbba0edd55e
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Aug 23 00:53:07 2017

Enable more content_browsertests that now pass with network service.

BUG= 729848 
TBR=yzshen@chromium.org

Change-Id: I23d6f6313309668abe5ea510a1b4055dabf519c4
Reviewed-on: https://chromium-review.googlesource.com/627383
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496531}
[modify] https://crrev.com/5a624c6cf6ab03d9c760c052698d5bbba0edd55e/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd7d7ee4485b71260e44fb68bd922f130ae8c84d

commit bd7d7ee4485b71260e44fb68bd922f130ae8c84d
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Aug 23 06:12:20 2017

Update content_browsertests filter.

r496531 renabled a test that flaked. Also disable some new failing tests added in r496577.

BUG= 729848 
TBR=kinuko@chromium.org
NOTRY=true

Change-Id: I5a59f687df52f65441c7ff03c0ac45920ff2e081
Reviewed-on: https://chromium-review.googlesource.com/628016
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496596}
[modify] https://crrev.com/bd7d7ee4485b71260e44fb68bd922f130ae8c84d/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 9 by falken@chromium.org, Aug 31 2017

Blockedon: 760831
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e0df1325d84eea029d2d6d08458965553780c0a

commit 5e0df1325d84eea029d2d6d08458965553780c0a
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Oct 13 07:17:11 2017

Network Service: Disable two new MemlogBrowserTests.

-AllProcesses/MemlogBrowserTest.EndToEndTracing/0
-BrowserOnly/MemlogBrowserTest.EndToEndTracing/0

These were added today and are failing on Network Service, looks similar to
existing disabled MemlogBrowserTests tests.

Bug:  729848 
Change-Id: I739e91bd57b970e182ca4e03ea6caed7900475e0
TBR: yzshen
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/718296
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508632}
[modify] https://crrev.com/5e0df1325d84eea029d2d6d08458965553780c0a/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ba8f3e8babdd97a60b27483a69e406554ca34ac

commit 4ba8f3e8babdd97a60b27483a69e406554ca34ac
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Oct 16 03:51:09 2017

Network Service: Disable InstantThemeTest.ThemeBackgroundAccess

This started failing with https://crrev.com/508695 which introduced
the test (moved the test from interactive_ui test to browser_test).

Bug:  729848 
Change-Id: I7b20273117b9957d9abb8d522924313959009876
TBR: yzshen
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/720593
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508978}
[modify] https://crrev.com/4ba8f3e8babdd97a60b27483a69e406554ca34ac/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 12 by dougt@chromium.org, Oct 20 2017

Components: Internals>Network>Service
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cebb7407213a82d17de1531036c195520bce904

commit 0cebb7407213a82d17de1531036c195520bce904
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Tue Oct 31 09:35:23 2017

NetworkService: Suppress two browsertests that are always failing

These tests almost never succeeded:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_browser_tests&tests=SSLUITestCommittedInterstitials.ErrorPageType%2CSafeBrowsingTriggeredInterceptingBrowserTest.AbusiveMetadata

SSLUITestCommittedInterstitials.ErrorPageType
SafeBrowsingTriggeredInterceptingBrowserTest.AbusiveMetadata

TBR=jam@chromium.org
NOTRY=true

Bug:  729848 
Change-Id: Icc2f009f2825f72e49c9fcbc87eb5843258d0b6a
Reviewed-on: https://chromium-review.googlesource.com/746624
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512789}
[modify] https://crrev.com/0cebb7407213a82d17de1531036c195520bce904/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d6eacfc0a32b1b9060e637ec2d7e0539d3abfbb

commit 8d6eacfc0a32b1b9060e637ec2d7e0539d3abfbb
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Thu Nov 02 13:06:54 2017

NetworkService: suppress more failing tests

New failing tests:
virtual/mouseevent_fractional/fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
(I haven't looked into the details for this one)

A new test in the same existing category:
NavigationHandleImplBrowserTest.ThrottleFailureWithErrorPageContent
Added in
https://chromium.googlesource.com/chromium/src/+/a15d3fccbc47ad0f54c5f24c135e5b1918007499

TBR=jam@chromium.org
NOTRY=true

Bug:  729848 ,  729849 
Change-Id: I769bec8c7415d0c66bf96bd3e19125cffe40d246
Reviewed-on: https://chromium-review.googlesource.com/750923
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513471}
[modify] https://crrev.com/8d6eacfc0a32b1b9060e637ec2d7e0539d3abfbb/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
[modify] https://crrev.com/8d6eacfc0a32b1b9060e637ec2d7e0539d3abfbb/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d02cdc58fc41a056086c4a6ebeb8711c89a91968

commit d02cdc58fc41a056086c4a6ebeb8711c89a91968
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Dec 06 08:11:26 2017

Network Service: Sheriffing: Some new SiteIsolation tests are failing.

These tests were added/changed in r522016.
-SiteIsolationStatsGathererBrowserTest/SiteIsolationStatsGathererBrowserTest.CrossSiteDocumentBlockingForMimeType/0
-SiteIsolationStatsGathererBrowserTest/SiteIsolationStatsGathererBrowserTest.CrossSiteDocumentBlockingForMimeType/1
-CrossSiteDocumentBlockingTest.BlockDocuments
-CrossSiteDocumentBlockingIsolatedOriginTest.BlockDocumentsFromIsolatedOrigin
-CrossSiteDocumentBlockingTest.RangeRequest

Most failures (even the non-StatsGatherer ones) seem to be about histograms.

Bug:  786505 ,  729848 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2302d55d5de41c904c38c675fc57122316ceec15
NOTRY: true
TBR: jam
Reviewed-on: https://chromium-review.googlesource.com/810247
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522041}
[modify] https://crrev.com/d02cdc58fc41a056086c4a6ebeb8711c89a91968/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bd8aef4d81b7a524e37e6965be84dc2600e7edb

commit 3bd8aef4d81b7a524e37e6965be84dc2600e7edb
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Mar 01 20:10:42 2018

Fix browser tests that use host_resolver() and navigate in SetUpOnMainThread with the network service.

These currently silently fail, as we only sync the host_resolver() rules after SetUpOnMainThread returns. Improve this by watching the main window's WebContents for navigations and syncing the rules immediately.

This won't cover all corner cases, i.e. if a test navigates a new tab or window. However it should cover the majority of cases.

Bug:  729848 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie14daf47582d187f6d4aa6bf0a36885997fee6c8
Reviewed-on: https://chromium-review.googlesource.com/940165
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540264}
[modify] https://crrev.com/3bd8aef4d81b7a524e37e6965be84dc2600e7edb/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/3bd8aef4d81b7a524e37e6965be84dc2600e7edb/content/public/test/browser_test_base.cc
[modify] https://crrev.com/3bd8aef4d81b7a524e37e6965be84dc2600e7edb/content/public/test/browser_test_base.h
[modify] https://crrev.com/3bd8aef4d81b7a524e37e6965be84dc2600e7edb/content/public/test/content_browser_test.cc
[modify] https://crrev.com/3bd8aef4d81b7a524e37e6965be84dc2600e7edb/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f31b1d9022784ea9f59bc7b520462b71220db58e

commit f31b1d9022784ea9f59bc7b520462b71220db58e
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Mar 02 19:09:13 2018

Enable now passing content_browsertests with network service.

TBR=chongz@chromium.org

Bug:  729848 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id4534f30e439cd4505e24df2abef3ae8403a9798
Reviewed-on: https://chromium-review.googlesource.com/946527
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540578}
[modify] https://crrev.com/f31b1d9022784ea9f59bc7b520462b71220db58e/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 19 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30edc2dbcbfacfd9a681a44f4c8f8f46878b4e83

commit 30edc2dbcbfacfd9a681a44f4c8f8f46878b4e83
Author: Chong Zhang <chongz@chromium.org>
Date: Wed Mar 07 23:28:51 2018

Fix RenderThreadImplBrowserTest by adding ScopedIPCSupport

Removed 2 tests from the filter:
-RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler
  * Fixed by adding |ScopedIPCSupport| after |InitializeMojo()|.
-RenderThreadImplBrowserTest.ResourceDispatchIPCTasksGoThroughScheduler
  * This test no longer exists.

-- Note: the first test used to crash with log:
[91028:91028:0307/112240.705814:2593896751430:FATAL:scoped_refptr.h(219)] Check failed: ptr_.
#0 0x7f69ce3986ad base::debug::StackTrace::StackTrace()
#1 0x7f69ce396b9c base::debug::StackTrace::StackTrace()
#2 0x7f69ce41ebca logging::LogMessage::~LogMessage()
#3 0x7f69d0131b42 scoped_refptr<>::operator->()
#4 0x7f69d016d49b mojo::edk::NodeController::SendBrokerClientInvitation()
#5 0x7f69d013becf mojo::edk::Core::SendBrokerClientInvitation()
#6 0x7f69d01c06ea mojo::edk::OutgoingBrokerClientInvitation::Send()
#7 0x7f69c9cb0df8 content::internal::ChildProcessLauncherHelper::PostLaunchOnLauncherThread()
#8 0x7f69c9cb08cd content::internal::ChildProcessLauncherHelper::LaunchOnLauncherThread()


Bug:  729848 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I18d85b91b5db78087c7e507df3d38da767327e1b
Reviewed-on: https://chromium-review.googlesource.com/953248
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541638}
[modify] https://crrev.com/30edc2dbcbfacfd9a681a44f4c8f8f46878b4e83/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/30edc2dbcbfacfd9a681a44f4c8f8f46878b4e83/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbbd7543f9713f37effea6b6849bce3f4e83c9b4

commit cbbd7543f9713f37effea6b6849bce3f4e83c9b4
Author: Chong Zhang <chongz@chromium.org>
Date: Fri Mar 09 18:32:14 2018

NetworkService: Fix 7 DevToolsDownloadContentTest cases

This CL:
1. Replaced |URLRequestInterceptor| usages with
   |embedded_test_server()| as the former is not supported in
   NetworkService.
2. Introduced |DownloadManager::Observer::OnDownloadDropped()| which is
   called when the download manager intercepted a download navigation
   but didn't create a download item.
3. Removed the following test cases from the filter:
-DevToolsDownloadContentTest.MultiDownload
-DevToolsDownloadContentTest.DefaultDownload
-DevToolsDownloadContentTest.ResetDownloadState
-DevToolsDownloadContentTest.DownloadCancelled
-DevToolsDownloadContentTest.DeniedDownload
-DevToolsDownloadContentTest.DefaultDownloadHeadless
-DevToolsDownloadContentTest.SingleDownload

Bug:  729848 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9da96982ea8b5d0b4848f438a1f3a5bd8418dd72
Reviewed-on: https://chromium-review.googlesource.com/956560
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542173}
[modify] https://crrev.com/cbbd7543f9713f37effea6b6849bce3f4e83c9b4/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/cbbd7543f9713f37effea6b6849bce3f4e83c9b4/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/cbbd7543f9713f37effea6b6849bce3f4e83c9b4/content/public/browser/download_manager.h
[modify] https://crrev.com/cbbd7543f9713f37effea6b6849bce3f4e83c9b4/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef7a3da76c687a0263f3b42f884ddd7842c1f7c8

commit ef7a3da76c687a0263f3b42f884ddd7842c1f7c8
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Apr 25 13:40:08 2018

Fix power monitor tests with network service.

Bug:  729848 
Change-Id: Ic1fc3f01184585c79f75cd060d4ce94226affb29
Reviewed-on: https://chromium-review.googlesource.com/1027205
Reviewed-by: Han Leon <leon.han@intel.com>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553530}
[modify] https://crrev.com/ef7a3da76c687a0263f3b42f884ddd7842c1f7c8/content/browser/power_monitor_browsertest.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d2173737d071f674aa8c624b9033f4eadd71f15

commit 2d2173737d071f674aa8c624b9033f4eadd71f15
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Apr 25 13:40:51 2018

Convert RequestDataResourceDispatcherHostBrowserTest tests to work with network service.

Bug:  729848 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7bafe16cda83030209f357340c6503154e9b55cf
Reviewed-on: https://chromium-review.googlesource.com/1027121
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553531}
[modify] https://crrev.com/2d2173737d071f674aa8c624b9033f4eadd71f15/content/browser/loader/resource_dispatcher_host_browsertest.cc
[modify] https://crrev.com/2d2173737d071f674aa8c624b9033f4eadd71f15/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/2d2173737d071f674aa8c624b9033f4eadd71f15/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 23 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63607bc1db205d1222f51b01a2ef183fce3e5cbe

commit 63607bc1db205d1222f51b01a2ef183fce3e5cbe
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Apr 25 13:55:30 2018

Update network service content_browsertests filter after r553530.

I forgot to update the filter in that fix.

TBR=leon.han@intel.com
NOTRY=true

Bug:  729848 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I50456a8a863277c06d054a7ba9a5f5834be5057c
Reviewed-on: https://chromium-review.googlesource.com/1027993
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553535}
[modify] https://crrev.com/63607bc1db205d1222f51b01a2ef183fce3e5cbe/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 24 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81a63dfba6fb07fdbf6e00cae2f257920651b1bc

commit 81a63dfba6fb07fdbf6e00cae2f257920651b1bc
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Apr 27 23:08:35 2018

Reenable a content browser test with network service

Reenables the contentc browser test
GetUserMediaVideoCaptureBrowserTest.
RecoverFromCrashInVideoCaptureProcess with the network service as it
seems to be passing now.

Tbr: dpranke@chromium.org
Bug:  729848 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iac6246c6f7205dee0791da39f1e08da39a62af47
Reviewed-on: https://chromium-review.googlesource.com/1033955
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554551}
[modify] https://crrev.com/81a63dfba6fb07fdbf6e00cae2f257920651b1bc/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 25 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17689c85bbf7c80e14f0a5552f936339c2f104af

commit 17689c85bbf7c80e14f0a5552f936339c2f104af
Author: Jay Civelli <jcivelli@google.com>
Date: Mon Apr 30 18:35:42 2018

Associate a bug with a test failure in network service filter file

Associates a bug in the fyi filter file for a content browser test
failure for test:
NavigationHandleImplBrowserTest.RedirectToRendererDebugUrl

Also changes some bug URL from http:// to https://

Tbr: dpranke@chromium.org
Bug:  729848 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id0afb2630912f86ef21c13af434e8d366f798744
Reviewed-on: https://chromium-review.googlesource.com/1033018
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554819}
[modify] https://crrev.com/17689c85bbf7c80e14f0a5552f936339c2f104af/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 26 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6bb2dcc13ac5d402d5f3bbcf8106cd3f2c7f1f0

commit d6bb2dcc13ac5d402d5f3bbcf8106cd3f2c7f1f0
Author: Matt Menke <mmenke@chromium.org>
Date: Tue May 08 21:43:46 2018

Disable some service-worker and a fetch test with the network service.

I believe these most likely broken by
https://chromium-review.googlesource.com/1048133

TBR=japhet@chromium.org, jam@chromium.org
NOTRY=true

Bug:  729848 ,  706331 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I4b3525af8d2f06fbccf311e40a9f64e7af70ffcd
Reviewed-on: https://chromium-review.googlesource.com/1049831
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556972}
[modify] https://crrev.com/d6bb2dcc13ac5d402d5f3bbcf8106cd3f2c7f1f0/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 27 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9aa30376941de5eccd1375675cb6b3dbedbeacaf

commit 9aa30376941de5eccd1375675cb6b3dbedbeacaf
Author: Nate Chapin <japhet@chromium.org>
Date: Tue May 08 23:19:41 2018

Revert "Disable some service-worker and a fetch test with the network service."

This reverts commit d6bb2dcc13ac5d402d5f3bbcf8106cd3f2c7f1f0.

Reason for revert: offending CL reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1050847

Original change's description:
> Disable some service-worker and a fetch test with the network service.
> 
> I believe these most likely broken by
> https://chromium-review.googlesource.com/1048133
> 
> TBR=japhet@chromium.org, jam@chromium.org
> NOTRY=true
> 
> Bug:  729848 ,  706331 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I4b3525af8d2f06fbccf311e40a9f64e7af70ffcd
> Reviewed-on: https://chromium-review.googlesource.com/1049831
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556972}

TBR=falken@chromium.org,jam@chromium.org,japhet@chromium.org,mmenke@chromium.org

Change-Id: Ib6b665dba5810a5c50f2c7081a0647bcd22e58bc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  729848 ,  706331 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1050500
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557001}
[modify] https://crrev.com/9aa30376941de5eccd1375675cb6b3dbedbeacaf/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 28 by jam@chromium.org, May 9 2018

Blockedon: 841557
Project Member

Comment 29 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c253c4ebb76f9e6e01cbcd3d11174c57a7cf59a

commit 3c253c4ebb76f9e6e01cbcd3d11174c57a7cf59a
Author: Jay Civelli <jcivelli@google.com>
Date: Wed May 09 23:20:44 2018

Fix one NavigationHandleImplBrowserTest test with the network service

Bug:  729848 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Idf1dd6a663f154b291e42444c0f5f48eaf5f0277
Reviewed-on: https://chromium-review.googlesource.com/1031388
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557371}
[modify] https://crrev.com/3c253c4ebb76f9e6e01cbcd3d11174c57a7cf59a/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/3c253c4ebb76f9e6e01cbcd3d11174c57a7cf59a/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/3c253c4ebb76f9e6e01cbcd3d11174c57a7cf59a/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 30 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96b2dc99265861c5b66d3273d647ff1489d6c474

commit 96b2dc99265861c5b66d3273d647ff1489d6c474
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon May 21 23:47:33 2018

Fix BlockedSchemeNavigationBrowserTest.*/1 flake with network service on Windows.

The file system writing would race with the reading, leading to tests timing out on Win Mojo bot. The fix is to wait on the file being written first.

Bug:  729848 
Change-Id: If24fbe0b47ca8d62e54769374904bbc5e574ea6c
Reviewed-on: https://chromium-review.googlesource.com/1068061
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560411}
[modify] https://crrev.com/96b2dc99265861c5b66d3273d647ff1489d6c474/content/browser/frame_host/blocked_scheme_navigation_browsertest.cc

Comment 31 by dxie@chromium.org, May 22 2018

Labels: -Pri-2 Proj-Servicification-Canary OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1

Comment 32 by dxie@chromium.org, Jun 8 2018

Status: Available (was: Untriaged)
Project Member

Comment 33 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbc88a0b9ff466901baad9ebc1b5f545b368cd81

commit fbc88a0b9ff466901baad9ebc1b5f545b368cd81
Author: Clark DuVall <cduvall@chromium.org>
Date: Wed Aug 08 20:57:56 2018

Cleanup some passing tests in mojo.fyi.network_content_browsertests.filter

Bug:  729848 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I47030b560c2187c6cb48217338f071400539cd08
Reviewed-on: https://chromium-review.googlesource.com/1167801
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581686}
[modify] https://crrev.com/fbc88a0b9ff466901baad9ebc1b5f545b368cd81/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Labels: -Proj-Servicification-Canary Proj-Servicification
removing Proj-Servicification-Canary as everything that remains has a canary blocking bug
Labels: Hotlist-KnownIssue
Status: Fixed (was: Available)

Sign in to add a comment