Add sizes step to an Android builder |
||||
Issue descriptionChrome Version: https://chromium.googlesource.com/chromium/src/+/f5f0bccb0526f845360270c68cdaf0aa991a8ed5 OS: Android What steps will reproduce the problem? (1) Add Android-only code that causes a lot of static initializers. What is the expected result? The build fails the sizes-step. What happens instead? A lot of static initializers are checked in. For example, bug 729791 could've been avoided had there been a bot running the sizes step on Android.
,
Jun 6 2017
Also - looks like Android has ~60 SIs, whereas linux has only ~10: https://chromeperf.appspot.com/report?sid=c64ba93e0a8bf806b6e6ce6ab646e3c963f03ea8dcff4a70efaf8bd9e3ab62ad&num_points=5000
,
Jun 6 2017
,
Jun 7 2017
Thanks. Lead me right to: https://cs.chromium.org/chromium/src/testing/scripts/sizes.py?type=cs Looks like we just have a .json file with the number of expected SIs: https://cs.chromium.org/chromium/src/tools/perf_expectations/perf_expectations.json From its history, it looks like it used to also have limits for ELF section sizes, but they were removed due since people just updated them whenever limits were hit. Having the script fail when SIs increase wouldn't actually be the useful at the moment, since resource_sizes.py is not run by any trybots. For now, it's probably just as easy to add a perf alert for SIs increasing. I've noted that we should add this to the bug on adding a resource_sizes trybot: bug 702625
,
Jun 7 2017
Filed monitoring bug 730274. Note: Another alternative would be to add checking of SIs to linux_android_rel_ng. I hope to be able to work on bug 702625 next quarter though, so easier to just wait on that for now.
,
Jun 7 2017
Monitoring set up, and better trybot-time failures tracked by bug 702625 . Closing.
,
Jun 14 2017
FYI - The move to clang got rid of a lot of SIs! https://bugs.chromium.org/p/chromium/issues/detail?id=729847 https://chromeperf.appspot.com/report?sid=e0a3413f2dc96f8600f045642abbbab6691b110b976ba2136bf38eaed02c8aa0&start_rev=477987&end_rev=479207 |
||||
►
Sign in to add a comment |
||||
Comment 1 by agrieve@chromium.org
, Jun 6 2017Owner: agrieve@chromium.org
Status: Available (was: Untriaged)