New issue
Advanced search Search tips

Issue 729847 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Add sizes step to an Android builder

Project Member Reported by nyquist@chromium.org, Jun 6 2017

Issue description

Chrome Version: https://chromium.googlesource.com/chromium/src/+/f5f0bccb0526f845360270c68cdaf0aa991a8ed5
OS: Android

What steps will reproduce the problem?
(1) Add Android-only code that causes a lot of static initializers.

What is the expected result?
The build fails the sizes-step.

What happens instead?
A lot of static initializers are checked in.


For example, bug 729791 could've been avoided had there been a bot running the sizes step on Android.
 
Cc: estevenson@chromium.org
Owner: agrieve@chromium.org
Status: Available (was: Untriaged)
Related: we do actually measure the SI count for android:
https://chromeperf.appspot.com/report?sid=2e1421013ce75306cdc0974cbd058b84083ef684dabed256879bacb31613b326&num_points=5000

The missing step here is making it fail when the number increases. I'm not sure how this is implemented for sizes (is there a whitelist of existing SIs somewhere?).

Tommy - do you happen to have a link to a bot that shows a failing sizes step?
Cc: thakis@chromium.org
Status: Assigned (was: Available)
Thanks. Lead me right to:
https://cs.chromium.org/chromium/src/testing/scripts/sizes.py?type=cs

Looks like we just have a .json file with the number of expected SIs:
https://cs.chromium.org/chromium/src/tools/perf_expectations/perf_expectations.json

From its history, it looks like it used to also have limits for ELF section sizes, but they were removed due since people just updated them whenever limits were hit.

Having the script fail when SIs increase wouldn't actually be the useful at the moment, since resource_sizes.py is not run by any trybots. For now, it's probably just as easy to add a perf alert for SIs increasing. I've noted that we should add this to the bug on adding a resource_sizes trybot:  bug 702625 

Comment 6 Deleted

Filed monitoring bug 730274.

Note: Another alternative would be to add checking of SIs to linux_android_rel_ng. I hope to be able to work on  bug 702625  next quarter though, so easier to just wait on that for now.
Status: Fixed (was: Assigned)
Monitoring set up, and better trybot-time failures tracked by  bug 702625 . Closing.

Sign in to add a comment