[Linux] Ctrl+Shift+Delete does not open "clear browsing data" when omnibox has focus
Reported by
zapahj...@gmail.com,
Jun 5 2017
|
|||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.86 Safari/537.36 Steps to reproduce the problem: 1. open a new tab 2. notice how the URL input-field has focus 3. press Ctrl+Shift+Delete intending to open the Clear Browsing Data window 4. nothing happens What is the expected behavior? Pressing Ctrl+Shift+Delete should open the Clear Browsing Data window What went wrong? The Ctrl+Shift+Delete keyboard shortcut does not work when an input-field has focus Did this work before? No Chrome version: 59.0.3071.86 Channel: stable OS Version: Flash Version:
,
Jun 6 2017
,
Jun 6 2017
Able to reproduce this issue on Ubuntu 14.04 using chrome latest beta #59.0.3071.86 by following steps mentioned in the original comment. Observed the Clear Browsing Data window is not opened by pressing Ctrl+Shift+Delete. This issue is observed on older version of chrome #47.0.2499.0, Hence marking it as untriaged. Note: This issue is not observed on windows and Mac OS. Thanks!
,
May 10 2018
triage routing to pkasting :)
,
May 10 2018
Linux-only omnibox bug; ->jdonnelly for triage
,
Jun 14 2018
,
Jun 14 2018
,
Aug 27
,
Aug 27
Issue 877631 has been merged into this issue.
,
Aug 31
Any chance this bug will get some attention once the new material design UI lands?
,
Sep 17
manukh: krb has experience dealing with our keyboard event handling code, reach out to him for pointers if it's not obvious.
,
Sep 17
,
Sep 18
Linux textfields bind the ctr + shift + delete to the `DELETE_TO_END_OF_PARAGRAPH`. jdonnelly@, I'm not certain how to handle this conflict of bindings: 1. keep as is, ctrl+shift+del deletes from cursor to end of omnibox text when omnibox is focused 2. disregard the linux binding, ctrl+shift+del opens clear browsing history 3. conditionally select which binding. e.g. if the omnibox popup is closed, then open "clear browsing history", else delete omnibox text starting from cursor. #2 sounds least appealing to me. https://cs.chromium.org/chromium/src/ui/views/controls/textfield/textfield.cc?l=881&rcl=01c5b2d23d17b2fbae2002cf41bf38cf1935b282 https://cs.chromium.org/chromium/src/ui/base/ime/text_edit_commands.h?l=17&rcl=9cfe75d93bcc5c92c1cba598a024b93b74d28adf
,
Sep 20
talked with jdonnelly@, unless someone argues otherwise, we'll retain linux's behavior (#1 in c#13)
,
Sep 20
manukh@, in other words, you'll only fix the ChromeOS part of this, and leave the Linux part as WontFix?
,
Sep 21
@mpearson, Apparently ChromeOS uses `ctrl+shift+backspace` rather than `delete` for clear browsing history. The omnibox consumes backspace shortcuts (except when in read-only mode). https://cs.chromium.org/chromium/src/ui/views/controls/textfield/textfield.cc?l=897&rcl=01c5b2d23d17b2fbae2002cf41bf38cf1935b282 More importantly, ChromeOS "seems" to use `ctrl+shift+backspace` as `delete to beginning of paragraph`, resulting in the same conflict as mentioned in c#13. I tested by building and running ChromeOS target on linux (using the instructions below), so I'm not sure if the `ctrl+shift+backspace` system shortcut is actually a ChromeOS shortcut, or only apparent when running ChromeOS on linux. https://chromium.googlesource.com/chromium/src/+/HEAD/docs/chromeos_build_instructions.md
,
Sep 21
I'm not sure if this helps, but Chromebooks don't have a delete key, just backspace, but: - shift-backspace is delete - ctrl-backspace is erase to beginning of line So it would appear that ctrl-shift-backspace is "available". (I'm guessing that the code isn't terribly strict about modifier checking.)
,
Sep 21
For the record, there is no clear browsing history shortcut listed on the official page of support shortcuts on ChromeOS: https://support.google.com/chromebook/answer/183101?hl=en It is on the list for other desktop platforms: https://support.google.com/chrome/answer/157179?hl=en
,
Sep 25
> ctrl-backspace is erase to beginning of line I just tried and I don't think this is accurate. When I tried it, ctrl-backspace deleted word-at-a-time, while ctrl-shift-backspace deletes all. So I don't think that's an option, either. Both Linux and Chrome OS appear to have defined behaviors for text fields that conflict with the clear browsing data shortcuts so I don't think we should make any changes on either platform.
,
Oct 14
Guys, might a different keyboard shortcut be created/implemented for activating the Clear Browsing Data window? On linux, Chrome uses CTRL+SHIFT+O to open the Bookmarks Manager. Other browsers historically used CTRL+B or CTRL+SHIFT+B or something with B in it, but Chrome changed it to use O instead of B. So there is precedent for slightly changing keyboard shortcuts on linux. Might changing the Clear Browsing Data window shortcut be considered so as to "fix" this bug while avoiding the issues that led to this bug being a Won't Fix? Then users can get a functional keyboard shortcut that works 100% of the time for opening the Clear Browsing Data window? Please advise if this can be considered and if it needs a new bug created for its consideration.
,
Jan 14
Issue 921280 has been merged into this issue. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by nyerramilli@chromium.org
, Jun 6 2017