New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729816 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 677843

Blocking:
issue 729231
issue 729232
issue 729738
issue 729760



Sign in to add a comment

android bisect bots seem to need infra attention

Project Member Reported by m...@chromium.org, Jun 5 2017

Issue description

Doing my daily perf sheriffing check, and found a few bugs where bisects seem not to be running due to infra issues:

https://bugs.chromium.org/p/chromium/issues/detail?id=729231 -- android_nexus5x_perf_bisect / INFRA_FAILURE

https://bugs.chromium.org/p/chromium/issues/detail?id=729232 -- android_one_perf_bisect / INFRA_FAILURE

https://bugs.chromium.org/p/chromium/issues/detail?id=729738 -- clankium-tablet-perf-bisect / INFRA_FAILURE

 

Comment 1 by m...@chromium.org, Jun 5 2017

Blocking: 729738 729231 729232
Cc: eakuefner@chromium.org benjhayden@chromium.org simonhatch@chromium.org
Ethan - could this be related to things I heard you and Ben talking about today?
re: #c2

Responded to each of these, nexus 5x issue (or at least one of them) was the p0 from last week where all the bisects were failiong. The android one failure seemed to be a gclient sync issue, and the last the device was unresponsive.

Comment 4 by m...@chromium.org, Jun 6 2017

Blocking: 729760
Another one (android_nexus6_perf_bisect <-- new bot):

https://bugs.chromium.org/p/chromium/issues/detail?id=729760

Comment 5 by m...@chromium.org, Jun 6 2017

Blocking: 729220

Comment 6 by m...@chromium.org, Jun 6 2017

Blocking: 729736

Comment 7 by m...@chromium.org, Jun 6 2017

Blocking: 729217

Comment 8 by m...@chromium.org, Jun 6 2017

Blocking: 729767

Comment 9 by m...@chromium.org, Jun 6 2017

Blocking: 729735

Comment 10 by pasko@chromium.org, Jun 21 2017

Cc: sullivan@chromium.org
Owner: simonhatch@chromium.org
Status: Started (was: Available)
I _think_ simonhatch@ is working on it, so updating the bug status accordingly. Let me know if this is incorrect.

What I see in Android bisect is a few retires like:
devtools_client_backend._IsInspectorWebsocketAvailable:57  Websocket at port 35552 not yet available: [Errno 104] Connection reset by peer

should it maybe retry for longer than 1sec? websocket is known to start up slowly at times
Blocking: -729736
Blocking: -729217
Blocking: -729767
Blocking: -729735
Blocking: -729220
re: #c10

pasko@ which runs were you seeing those errors?


I removed a bunch of the blocking issues, as they were either the bisect not repro'ing or specifying chromium revisions for non chromium bisects.

Comment 17 by pasko@chromium.org, Jun 23 2017

Cc: pasko@chromium.org
I was looking at issue 729738, lemme try to start new bisects there.

Comment 18 by pasko@chromium.org, Jun 26 2017

All bisects I started there failed with "tests failed to produce values". Example log: https://uberchromegw.corp.google.com/i/internal.tryserver.clankium/builders/clankium-phone-perf-bisect/builds/461

Please take a look.

Comment 19 by pasko@chromium.org, Jun 26 2017

Summary: android bisect bots seem to need infra attention (was: android biscet bots seem to need infra attention)
So in those runs it looks like there are no values generated:

Here's an example json output from one of the runs:
https://uberchromegw.corp.google.com/i/internal.tryserver.clankium/builders/clankium-phone-perf-bisect/builds/461/steps/Gathering%20reference%20values.Reading%20chartjson%20results%20%288%29/logs/json.output

It's nearly empty, and has no perf data in there.

There are seemingly no errors during the run, and the output seems to indicate the pages ran successfully.

Comment 21 by pasko@chromium.org, Jun 27 2017

this is strange, just a couple of days ago the same benchmark generated nice chartjson results with messageloop_start_time in my local test runs.
When you ran it, did you use pageset-repeat=1? I vaguely recall there being a bug with startup tests not producing metrics in that case, no idea if that's been fixed or not.

Comment 23 by pasko@chromium.org, Jun 28 2017

Cc: lizeb@chromium.org agrieve@chromium.org
oh, you are right, I ran with pageset-repeat=20 and got 18 results. Sounds like badness on the benchmark side. If it does not work with pageset-repeat=1, we need to fix the benchmark.

Huge thanks for the insight!!

Do you know how to send a bisect with extra commandline parameters from the per dashboard UI? 

I wanted to start a bisect manually using tools/auto_bisect/bisect.cfg, did something, but not sure I succeeded. I then wrote some feedback on documentation in issue 737557.
Blockedon: 677843
We have a hack on the dashboard specifically for that startup bug (crbug.com/677843), might have to extend it to cover this benchmark until the benchmark itself is fixed.

Comment 25 by pasko@chromium.org, Jun 28 2017

nice hack! though I would set something around 20-40, since startup metrics are quite noisy and small amount of runs would likely lead bisect in wrong directions
Sure, although the bisect runs the test a minimum of 6 times, so seems like I'd only need to set the repeat to a few to get 20-40 total samples.

Comment 27 by pasko@chromium.org, Jun 28 2017

do you mean that each revision is benchmarked 6 times? I was worried that one noisy datapoint may diverge bisection into a sub-range of commits that does not have a regression, hence the bisect won't be useful. Glad that it's not the case.

Is it ready for another triple of bisects or you launched them already?
Yeah each revision is run a min of 6 times.

Let me put up a cl first with the hack to change the repeat, and then deploy that dashbaord. I'll post back here once that's done.

Comment 29 by pasko@chromium.org, Jun 29 2017

thank you, will wait for dashboard update
New dashboard is up, go for it.

Comment 31 by pasko@chromium.org, Jun 29 2017

thanks! Done.
Can I close this? Seems like the issues here are covered by individual bugs.
Status: Fixed (was: Started)
Closing in favor of more specific bugs.

Sign in to add a comment