check_gn_headers step fails on linux_chromium_rel_ng on LUCI |
|||
Issue descriptionhttps://codereview.chromium.org/2904073003 seems to be the reason why all builds on experimental "LUCI linux_chromium_rel_ng" fail: https://luci-milo.appspot.com/buildbucket/luci.chromium.try/LUCI%20linux_chromium_rel_ng example of a failure: https://luci-milo.appspot.com/swarming/task/369321eb4492a210 it seems to assume ninja to be in $PATH, but depot_tools dir is not in $PATH. In the previous successful builds check_gn_headers step was not present. This can be fixed by landing https://chromium-review.googlesource.com/c/522802/ and changing check_gn_headers.py to use src.git-relative ninja
,
Jun 5 2017
Dirk, you said you plan to land https://chromium-review.googlesource.com/c/522802/ today?
,
Jun 5 2017
time permitting, yes, though it's getting a bit late in the day now.
,
Jun 6 2017
ok, it's too late in the day today for me to be happy about landing that CL. Let's plan to land it first thing in the morning instead.
,
Jun 6 2017
to be clear, for luci-eng@ this is P0 because we estimate correctness based on past builds and this mini-outage plummets LUCI correctness. Feel free to ping me if you need assistance. I will prepare a patch to update check_gn_headers.py
,
Jun 6 2017
,
Jun 6 2017
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a40e94018f930fd154f12a309b0a211e9e5f915 commit 6a40e94018f930fd154f12a309b0a211e9e5f915 Author: nodir <nodir@chromium.org> Date: Wed Jun 07 05:49:03 2017 check_gn_headers: use pinned depot_tools build/check_gn_headers.py currently assumes depot_tools is in $PATH. This is false on some systems. Use the DEPS-pinned depot_tools instead. Bug: 729811 Review-Url: https://codereview.chromium.org/2925863002 Cr-Commit-Position: refs/heads/master@{#477559} [modify] https://crrev.com/6a40e94018f930fd154f12a309b0a211e9e5f915/build/check_gn_headers.py
,
Jun 7 2017
,
Jun 9 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by no...@chromium.org
, Jun 5 2017