Remove mash_unittests |
|||||
Issue descriptionCurrently we are running ash unittests against mash twice. One by way of ash_unittests --mash, and another by way of mash_unittests. To make matters worse one use a filter file (--mash), the other doesn't. We should fold the remaining mash_unittests into ash_unittests. Some of the tests against mash specific code can be filtered out for for non-mash as appropriate.
,
Jun 22 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/452f0fd1a8564e39ca732c1818083ec53959aa6f commit 452f0fd1a8564e39ca732c1818083ec53959aa6f Author: jonross <jonross@chromium.org> Date: Thu Jun 22 18:46:00 2017 Remove Redundant common ash_unittests from mash_unittests We can now run the mash version of ash_unittests via ash_unittests --mash The mash_unittests target brings in a redundant set of tests via ash:common_unittets. This change removes that import. There are still some ash/mus specific tests in this test suite, however they rely on additional setup work which is not yet available in ash_unittests --mash TEST=mash_unittests BUG= 729810 Review-Url: https://codereview.chromium.org/2947303003 Cr-Commit-Position: refs/heads/master@{#481613} [modify] https://crrev.com/452f0fd1a8564e39ca732c1818083ec53959aa6f/mash/BUILD.gn
,
Dec 8 2017
This is mildly tricky because ash_test_suite is the one looking for --mash and setting things up for all tests (Env, Env::Config...). One option is to make the tests early out if the config isn't mash. I don't think Jon is working on this anymore, so marking available.
,
Mar 9 2018
Un-cc-ing me from all bugs on my final day.
,
Aug 14
mash_unittests don't exist anymore. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sky@chromium.org
, Jun 5 2017