New issue
Advanced search Search tips

Issue 729805 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
FullscreenActivityBugs


Sign in to add a comment

Entering/exiting fullscreen video 3 times causes "Unsupported number of chrome instances"

Project Member Reported by tguilbert@chromium.org, Jun 5 2017

Issue description

Chrome Version: 61.0.3119.0
OS: Android

What steps will reproduce the problem?
(1) Open Chrome
(2) Start playing a video (http://storage.googleapis.com/watk/v used in repro video)
(3) Fullscreen and unfullscreen element 3 times.

What is the expected result? We can enter/exit fullscreen as much as we want.

What happens instead? A "Unsupported number of Chrome instances" message pops up, and it is impossible to open the page on which the video is playing.
 
Labels: M-61
Tried on Canary (same version as initial comment) but couldn't reproduce.

What Android OS did you use?
6.0.1 on a nexus 5
This also repros on Canary on Android 5.1.1 on a Nexus 7
Cc: liber...@chromium.org
Status: Assigned (was: Untriaged)
@tguilbert - this is probably to do with my change.
i've noticed another behavor that might be related.

1. navigate to http://storage.googleapis.com/watk-public/v
2. pick the upper left button (small mp4).  play it, enter full screen.
2. return to the home screen via the android home button while in full screen.
3. launch chrome
4. notice that you're back at the chrome home screen, rather than the url in 1.

do that enough, and you'll also get the "unsupported number of chrome instances" message.
This bug now only happens when FullscreenActivity is manually enabled.
Cc: mlamouri@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3ebd9d7dbc3e6c716ce0b454c087a9a221f44a2

commit a3ebd9d7dbc3e6c716ce0b454c087a9a221f44a2
Author: Peter E Conn <peconn@chromium.org>
Date: Thu Jul 06 15:23:03 2017

📺 Launch FullscreenWebContentsActivity in current Task.

Launching FullscreenWebContentsActivity with FLAG_ACTIVITY_NEW_TASK
causes multiple instances of ChromeTabbedActivity to be created on
some devices.

Bug:  729805 , 729932
Change-Id: I3edde02865b8e07bc4f3bb0e3d021db37b0c3916
Reviewed-on: https://chromium-review.googlesource.com/561516
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484601}
[modify] https://crrev.com/a3ebd9d7dbc3e6c716ce0b454c087a9a221f44a2/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/a3ebd9d7dbc3e6c716ce0b454c087a9a221f44a2/chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java
[modify] https://crrev.com/a3ebd9d7dbc3e6c716ce0b454c087a9a221f44a2/chrome/android/javatests/src/org/chromium/chrome/browser/FullscreenWebContentsActivityTest.java

Status: Fixed (was: Assigned)

Sign in to add a comment