New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729798 link

Starred by 5 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

mushrome mouse cursor doesn't update

Project Member Reported by rjkroege@chromium.org, Jun 5 2017

Issue description

When running on ozone/drm devices in the mushrome configuration, the mouse cursor bitmap image is not updated as the mouse cursor moves over different areas of the screen. Mustash configuration does not have this issue.
 

Comment 1 by e...@chromium.org, Jun 6 2017

This reproduces on local builds; you don't need a device to be hit by this.

This happens because mushrome mode doesn't have a cursor manager. In classic mode, an AshNativeCursorManager is made which collaborates deeply with the ozone platform object. In mus mode, the views layer installs its own NativeCursorManagerMus which proxies calls to the WindowPortMus (and therefore across the mus boundary).
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36cfb953ea04dac15159b516cd9ce741c6b7384b

commit 36cfb953ea04dac15159b516cd9ce741c6b7384b
Author: erg <erg@chromium.org>
Date: Wed Jun 21 19:41:45 2017

Implement cursor changing on Mushrome.

This splits AshNativeCursorManager into an interface and creates two
implementations: one for classic ash (the original code), and one for
mushrome. The new mushrome implementation forwards to the mus window
manager interface instead of the individual windows due to how mus gets
cursors only from windows which have event handlers.

This leaves some features unimplemented, such as cursor sets, but
implements the core interface.

BUG= 729798 , 734807 , 734809 

Review-Url: https://codereview.chromium.org/2932563002
Cr-Commit-Position: refs/heads/master@{#481278}

[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/BUILD.gn
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/shell.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/shell.h
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/test/cursor_manager_test_api.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/test/shell_test_api.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/test/shell_test_api.h
[delete] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/ash/wm/ash_native_cursor_manager.h
[add] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash.h
[rename] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_classic.cc
[add] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_classic.h
[rename] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_interactive_uitest.cc
[add] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_mus.cc
[add] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_mus.h
[rename] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_unittest.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/chrome/test/BUILD.gn
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/extensions/shell/browser/shell_desktop_controller_aura.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/testing/buildbot/filters/ash_unittests_mus.filter
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ui/views/widget/desktop_aura/desktop_native_cursor_manager.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8

commit c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8
Author: erg <erg@chromium.org>
Date: Fri Jun 23 21:37:47 2017

Implement large cursors in Mushrome.

This transitions a ui enum to an enum class, and adds support for
sending it across mojo pipes. The window manager now has an API to
change which cursor set is used on the window server.

BUG= 729798 

Review-Url: https://codereview.chromium.org/2949353003
Cr-Commit-Position: refs/heads/master@{#482038}

[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/aura/shell_port_classic.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/aura/shell_port_classic.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/display/cursor_window_controller.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/display/cursor_window_controller.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/mus/bridge/shell_port_mash.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/shell_port.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/test/cursor_manager_test_api.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/test/cursor_manager_test_api.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/utility/screenshot_controller_unittest.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/wm/native_cursor_manager_ash_classic.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/wm/native_cursor_manager_ash_classic.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/wm/native_cursor_manager_ash_mus.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/wm/native_cursor_manager_ash_mus.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/wm/native_cursor_manager_ash_unittest.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ash/wm/window_manager_unittest.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/components/exo/pointer.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/components/exo/pointer.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/components/exo/wm_helper.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/components/exo/wm_helper.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/components/exo/wm_helper_ash.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/components/exo/wm_helper_ash.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/components/exo/wm_helper_mus.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/components/exo/wm_helper_mus.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/extensions/shell/browser/shell_desktop_controller_aura.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/public/interfaces/cursor/cursor.mojom
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/public/interfaces/cursor/cursor.typemap
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/public/interfaces/cursor/cursor_struct_traits.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/public/interfaces/cursor/cursor_struct_traits.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/ws/cursor_state.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/ws/cursor_state.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/ws/display.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/ws/display.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/ws/platform_display.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/ws/platform_display_default.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/ws/platform_display_default.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/ws/test_utils.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/ws/window_tree.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/services/ui/ws/window_tree.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/testing/buildbot/filters/ash_unittests_mus.filter
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/aura/client/cursor_client.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/aura/client/cursor_client_observer.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/aura/test/mus/test_window_manager_client.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/aura/test/mus/test_window_manager_client.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/aura/test/test_cursor_client.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/aura/test/test_cursor_client.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/base/BUILD.gn
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/base/cursor/cursor.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/base/cursor/cursor_loader_x11.cc
[add] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/base/cursor/cursor_type.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/base/cursor/cursors_aura.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/base/cursor/cursors_aura.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/base/cursor/image_cursors.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/base/cursor/image_cursors.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/views/widget/desktop_aura/desktop_native_cursor_manager.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/wm/core/cursor_manager.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/wm/core/cursor_manager.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/wm/core/cursor_manager_unittest.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/wm/core/native_cursor_manager.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/wm/core/native_cursor_manager_delegate.h
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/wm/test/testing_cursor_client_observer.cc
[modify] https://crrev.com/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8/ui/wm/test/testing_cursor_client_observer.h

Comment 4 by e...@chromium.org, Jun 23 2017

Status: Fixed (was: Assigned)

Comment 5 by e...@chromium.org, Aug 11 2017

Cc: e...@chromium.org
 Issue 705592  has been merged into this issue.

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment