New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729797 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature


Participants' hotlists:
OWP-Storage-DevTools


Sign in to add a comment

[DevTools] [IndexedDB] Per-item deletion, right click and/or grid button

Project Member Reported by dmu...@chromium.org, Jun 5 2017

Issue description

Create a button or right click item for per-row deletion for indexeddb.
 

Comment 1 by dmu...@chromium.org, Jun 26 2017

Owner: kristip...@chromium.org

Comment 2 by dmu...@chromium.org, Jul 11 2017

The c++ side of this should only involve the IDBInspectorAgent - it will be similar to clearObjectStore:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp?dr=CSs&l=969

But instead of calling 'clear' we'll be calling 'delete' on a single key.

Note: for Indexes, we can still delete from the object store, but we have to make sure we use the primary key given from the index crawl? Or just go through the index.
Status: Started (was: Available)
Selected item color was changed for readability.
Screenshot from 2017-09-27 15:46:02.png
62.3 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f249e41fef643bb8de115ba0363d1c18cb91a0d1

commit f249e41fef643bb8de115ba0363d1c18cb91a0d1
Author: Eugene Ostroukhov <eostroukhov@chromium.org>
Date: Fri Dec 08 02:44:28 2017

[DevTools] Single item deletion for IndexedDB

Added grid button and right click for object store/index item deletion.

This CL is a rebased and updated version of the
https://chromium-review.googlesource.com/c/chromium/src/+/688755 by
kristipark@chromium.org

Bug:  729797 
Change-Id: I6720b0fde77a25c4f8839d3d1929ec41f88e2585
Reviewed-on: https://chromium-review.googlesource.com/804599
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522687}
[add] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/delete-entry-expected.txt
[add] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/delete-entry.js
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/devtools/front_end/application_test_runner/IndexedDBTestRunner.js
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/devtools/front_end/resources/indexedDBViews.css
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
[modify] https://crrev.com/f249e41fef643bb8de115ba0363d1c18cb91a0d1/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h

Owner: eostroukhov@chromium.org
Status: Assigned (was: Started)
Thanks for taking care of these Eugene! :)
Status: Fixed (was: Assigned)

Sign in to add a comment