New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729796 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

WiFi hotspot appears in Settings when Tether network is connected

Project Member Reported by lesliewatkins@chromium.org, Jun 5 2017

Issue description

Chrome Version: 61.0.3120.0
OS: Chrome

What steps will reproduce the problem?
(1) Connect to a Tether network
(2) Open chrome://settings/network

What is the expected result?
The name of the mobile device will be listed under the Mobile data section, and no network will be listed under WiFi

What happens instead?
The name of the underlying WiFi hotspot is listed under the WiFi section.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Screenshot 2017-06-05 at 2.58.03 PM.png
14.0 KB View Download
Cc: steve...@chromium.org
Owner: khorimoto@chromium.org
Status: Assigned (was: Untriaged)
I'm not going to be able to look at it this week, it should be a pretty easy fix at this point. We should be excluding Tether networks from the WiFi list in netwrokingPrivate.

This is where we get the list of networks:
https://cs.chromium.org/chromium/src/extensions/browser/api/networking_private/networking_private_chromeos.cc?q=networking_private_chromeos+package:%5Echromium$&l=527

Which calls network_util::TranslateNetworkListToONC()
Which calls NetworkHandler::Get()->network_state_handler()->GetNetworkListByType()

Which should already be filtering out tether wifi networks.


Cc: lesliewatkins@chromium.org
 Issue 733424  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a0eba4b0089554977fde98d3a30d3ca74a750a0

commit 5a0eba4b0089554977fde98d3a30d3ca74a750a0
Author: khorimoto <khorimoto@chromium.org>
Date: Thu Jun 22 19:17:00 2017

[CrOS Tether] Sort Tether network lists.

With this change, Tether networks in the networking UI (i.e., settings and quick settings) are sorted in the same order that the Tether component prioritizes them when performing a host scan.

The sorting rules are as follows:
(1) The device which has most recently sent a successful ConnectTetheringResponse is always at the front of the queue.
(2) Devices which have most recently sent a successful TetherAvailabilityResponse are next in the order, as long as they do not violate the first rule.
(3) All other devices are left in the order they are passed.

This CL also updates the GetNetworkListByType() logic in NetworkStateHandler; after this change, all connected/connecting networks are listed before non-active networks, and Wi-Fi networks associated with Tether networks are no longer returned since they are supposed to be obscured behind their associated Tether networks.

BUG=672263, 729796 , 729801 

Review-Url: https://codereview.chromium.org/2945643002
Cr-Commit-Position: refs/heads/master@{#481621}

[modify] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/components/tether/BUILD.gn
[delete] https://crrev.com/acdd2a4349f0316bcc5f6c09a5fce64d92e82aaa/chromeos/components/tether/host_scan_device_prioritizer.cc
[modify] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/components/tether/host_scan_device_prioritizer.h
[add] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/components/tether/host_scan_device_prioritizer_impl.cc
[add] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/components/tether/host_scan_device_prioritizer_impl.h
[add] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/components/tether/host_scan_device_prioritizer_impl_unittest.cc
[delete] https://crrev.com/acdd2a4349f0316bcc5f6c09a5fce64d92e82aaa/chromeos/components/tether/host_scan_device_prioritizer_unittest.cc
[modify] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/components/tether/host_scanner_operation_unittest.cc
[modify] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/components/tether/host_scanner_unittest.cc
[modify] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/components/tether/initializer.cc
[modify] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/components/tether/initializer.h
[delete] https://crrev.com/acdd2a4349f0316bcc5f6c09a5fce64d92e82aaa/chromeos/components/tether/mock_host_scan_device_prioritizer.cc
[delete] https://crrev.com/acdd2a4349f0316bcc5f6c09a5fce64d92e82aaa/chromeos/components/tether/mock_host_scan_device_prioritizer.h
[modify] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/network/network_state_handler.cc
[modify] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/network/network_state_handler.h
[modify] https://crrev.com/5a0eba4b0089554977fde98d3a30d3ca74a750a0/chromeos/network/network_state_handler_unittest.cc

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment