New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729795 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocked on:
issue 612287
issue 756676


Participants' hotlists:
OWP-Storage-DevTools


Sign in to add a comment

[DevTools] [CacheStorage] Live update cache storage in devtools

Project Member Reported by dmu...@chromium.org, Jun 5 2017

Issue description

It would be great to live-update the cache storage views in devtools. This will require piping (there are no observers on cache storage) from the browser to the renderer.
 
Cc: allada@chromium.org
This would be great for local and session storage as well!
created  issue 730190 

Comment 4 by dmu...@chromium.org, Jun 26 2017

Blockedon: 612287
Owner: kristip...@chromium.org
Status: Assigned (was: Available)
Kristi will be picking this up after the mojo refactor
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99d361aa7f06affc8b3dd0483163d863ce45e17e

commit 99d361aa7f06affc8b3dd0483163d863ce45e17e
Author: kristipark <kristipark@chromium.org>
Date: Mon Aug 14 20:27:33 2017

[DevTools] [CacheStorage] Live update cache storage list

Automatically adds/removes caches from the sidebar when they are created/deleted.
End to end plumbing to raise events when items are added and removed from individual caches is in place but not yet in use (will come in a later CL).

Bug:  729795 
Change-Id: Ia63046f91396a9cd5192f042171d73e43b120080
Reviewed-on: https://chromium-review.googlesource.com/580390
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494167}
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/content/browser/cache_storage/cache_storage_context_impl.cc
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/content/browser/cache_storage/cache_storage_context_impl.h
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/content/browser/cache_storage/cache_storage_manager.h
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/content/browser/devtools/protocol/storage_handler.cc
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/content/browser/devtools/protocol/storage_handler.h
[add] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-list-expected.txt
[add] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-list.html
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/99d361aa7f06affc8b3dd0483163d863ce45e17e/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js

Here's the cache list live updating in action
cache-list-live.ogv
761 KB View Download
Here's the initial look of the dirty marker for cache content
dirty-marker.png
44.3 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa26f619fd32e61e564acf00b5513efe9cb73d69

commit aa26f619fd32e61e564acf00b5513efe9cb73d69
Author: kristipark <kristipark@chromium.org>
Date: Thu Aug 17 20:25:51 2017

[DevTools] [CacheStorage] Live update cache storage content

Marks the cache content view as dirty if entries are
out-of-date.

Bug:  729795 
Change-Id: I3600f8b196f5ca350768e6e75e82f18ecb88afb6
Reviewed-on: https://chromium-review.googlesource.com/616222
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Blaise Bruer <allada@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495301}
[modify] https://crrev.com/aa26f619fd32e61e564acf00b5513efe9cb73d69/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/aa26f619fd32e61e564acf00b5513efe9cb73d69/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/aa26f619fd32e61e564acf00b5513efe9cb73d69/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/aa26f619fd32e61e564acf00b5513efe9cb73d69/content/browser/cache_storage/cache_storage_manager_unittest.cc
[add] https://crrev.com/aa26f619fd32e61e564acf00b5513efe9cb73d69/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-cache-content-expected.txt
[add] https://crrev.com/aa26f619fd32e61e564acf00b5513efe9cb73d69/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-cache-content.html
[modify] https://crrev.com/aa26f619fd32e61e564acf00b5513efe9cb73d69/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/aa26f619fd32e61e564acf00b5513efe9cb73d69/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
[modify] https://crrev.com/aa26f619fd32e61e564acf00b5513efe9cb73d69/third_party/WebKit/Source/devtools/front_end/resources/serviceWorkerCacheViews.css

Comment 9 by kbr@chromium.org, Aug 18 2017

Blockedon: 756676

Comment 10 by kbr@chromium.org, Aug 18 2017

The new layout test from aa26f619fd32e61e564acf00b5513efe9cb73d69 is failing reliably on the linux_chromium_rel_ng tryserver; caused  Issue 756676 . Reverting it.

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ef6d0a065cbaae2129bb196706b58884bbd6a80

commit 4ef6d0a065cbaae2129bb196706b58884bbd6a80
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Aug 18 00:45:52 2017

Revert "[DevTools] [CacheStorage] Live update cache storage content"

This reverts commit aa26f619fd32e61e564acf00b5513efe9cb73d69.

Reason for revert: new layout test failing reliably on linux_chromium_rel_ng, blocking the CQ:  http://crbug.com/756676  .

Original change's description:
> [DevTools] [CacheStorage] Live update cache storage content
> 
> Marks the cache content view as dirty if entries are
> out-of-date.
> 
> Bug:  729795 
> Change-Id: I3600f8b196f5ca350768e6e75e82f18ecb88afb6
> Reviewed-on: https://chromium-review.googlesource.com/616222
> Commit-Queue: Kristi Park <kristipark@chromium.org>
> Reviewed-by: Blaise Bruer <allada@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Michael Nordman <michaeln@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#495301}

TBR=dgozman@chromium.org,michaeln@chromium.org,allada@chromium.org,kristipark@chromium.org

Change-Id: I8361cd9810c7a9ccc7cb688b813d5aed647adc68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  729795 
Reviewed-on: https://chromium-review.googlesource.com/620070
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495398}
[modify] https://crrev.com/4ef6d0a065cbaae2129bb196706b58884bbd6a80/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/4ef6d0a065cbaae2129bb196706b58884bbd6a80/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/4ef6d0a065cbaae2129bb196706b58884bbd6a80/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/4ef6d0a065cbaae2129bb196706b58884bbd6a80/content/browser/cache_storage/cache_storage_manager_unittest.cc
[delete] https://crrev.com/b96dcc112f56bf4a48ca7ede5e7a03cb965a045b/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-cache-content-expected.txt
[delete] https://crrev.com/b96dcc112f56bf4a48ca7ede5e7a03cb965a045b/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-cache-content.html
[modify] https://crrev.com/4ef6d0a065cbaae2129bb196706b58884bbd6a80/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/4ef6d0a065cbaae2129bb196706b58884bbd6a80/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
[modify] https://crrev.com/4ef6d0a065cbaae2129bb196706b58884bbd6a80/third_party/WebKit/Source/devtools/front_end/resources/serviceWorkerCacheViews.css

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97

commit ae7d71ccd1e4925796b8bf2829067fb2b95a2f97
Author: kristipark <kristipark@chromium.org>
Date: Fri Aug 18 21:00:29 2017

Reland "[DevTools] [CacheStorage] Live update cache storage content"

This is a reland of aa26f619fd32e61e564acf00b5513efe9cb73d69
Original change's description:
> [DevTools] [CacheStorage] Live update cache storage content
> 
> Marks the cache content view as dirty if entries are
> out-of-date.
> 
> Bug:  729795 
> Change-Id: I3600f8b196f5ca350768e6e75e82f18ecb88afb6
> Reviewed-on: https://chromium-review.googlesource.com/616222
> Commit-Queue: Kristi Park <kristipark@chromium.org>
> Reviewed-by: Blaise Bruer <allada@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Michael Nordman <michaeln@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#495301}

Bug:  756676 ,  729795 
Change-Id: I922e818ac106cb5a482151032452795f9ddaa910
Reviewed-on: https://chromium-review.googlesource.com/620308
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495678}
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage_manager_unittest.cc
[add] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-cache-content-expected.txt
[add] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-cache-content.html
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/Source/devtools/front_end/resources/serviceWorkerCacheViews.css

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2981bc9ffdca689dcbc21a515d24f72ebadd3a4d

commit 2981bc9ffdca689dcbc21a515d24f72ebadd3a4d
Author: kristipark <kristipark@chromium.org>
Date: Wed Aug 23 02:38:23 2017

[DevTools] Throttle cache storage list live updates

Creating/deleting a large number of caches at once causes
noticeable slowdowns due to the large number of cache tree
nodes added. Added a time delay between list refreshes to
soften the performance hit.

Also switched to _loadCacheNames since refreshCacheNames
visually removes all caches in the list before re-adding
them.

Bug:  729795 
Change-Id: I28edf17671627f90f6d4bb4962cd91028c37f38e
Reviewed-on: https://chromium-review.googlesource.com/625160
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496568}
[modify] https://crrev.com/2981bc9ffdca689dcbc21a515d24f72ebadd3a4d/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/2981bc9ffdca689dcbc21a515d24f72ebadd3a4d/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js

Status: Fixed (was: Assigned)
Cc: tjsavage@chromium.org addyo@chromium.org
 Issue 753421  has been merged into this issue.

Comment 16 Deleted

Has making the "Refresh needed" indicator clickable been discussed?

I kept finding myself clicking it, then having to remember to click the ↻ button on the other side of the panel instead. I can file a new tracking bug if this idea hasn't already been discussed/rejected.

The refresh indicator is going to be removed here (https://chromium-review.googlesource.com/c/chromium/src/+/627716), and the entries will be live updated instead.

Comment 19 by kayce@google.com, Oct 6 2017

Labels: DevTools-Release-Notes-62 DevTools-Release-Notes-Change

Sign in to add a comment