New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 729793 link

Starred by 3 users
Status: Fixed
Owner:
█ eostroukhov@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
█ allada@chromium.org
cmumford@chromium.org
kristip...@chromium.org
█ eostroukhov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature


Participants' hotlists:
OWP-Storage-DevTools


Sign in to add a comment

[DevTools] [IndexedDB] Live update IndexedDB view

Project Member Reported by dmu...@chromium.org, Jun 5 2017 
This can use the observer API - see
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h?q=IDBObserver&dr=CSs&l=28
for the observer object. Because DevTools needs to specify the security origin, we can't really write plain javascript, so we'll probably need to create all of the objects from CPP.

Important note - we'll need to throttle our changes to devtools, and perhaps set up some polling model - so a site can't DOS devtools.

Another note - we'll have to carefully think about how this will change the view when we're looking at the data grid. Do we keep the same 'position'? Do we pin to the top key?

Comment 1 by dmu...@chromium.org, Jun 5 2017

Components: Platform>DevTools

Comment 2 by dmu...@chromium.org, Jun 5 2017

Cc: allada@chromium.org

Comment 3 by dmu...@chromium.org, Jun 26 2017

Owner: kristip...@chromium.org

Comment 4 by kristip...@chromium.org, Sep 12 2017

Status: Started (was: Available)

Comment 5 by kristip...@chromium.org, Sep 15 2017 

Current look of the dirty marker for the data views.
Screenshot from 2017-09-14 17:40:07.png
80.9 KB View Download

Comment 6 by dmu...@chromium.org, Sep 15 2017 

thanks for the screenshot! looks great!
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92

commit 5e4cbe034c8a74ccbdd62777291ba4dea37c3a92
Author: kristipark <kristipark@chromium.org>
Date: Fri Sep 29 00:24:53 2017

[DevTools] [IndexedDB] Live update IndexedDB

Refreshes the IDB tree and table data if IDB is modified.

Bug:  729793 
Change-Id: I806e44ea6b5db884a2ab8ce9279745e023ac2732
Reviewed-on: https://chromium-review.googlesource.com/658486
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505227}
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/content/browser/devtools/protocol/storage_handler.cc
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/content/browser/devtools/protocol/storage_handler.h
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/content/browser/indexed_db/indexed_db_context_impl.h
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/content/browser/indexed_db/indexed_db_factory.h
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/content/browser/indexed_db/indexed_db_factory_impl.cc
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/content/browser/indexed_db/indexed_db_factory_impl.h
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/content/browser/indexed_db/mock_indexed_db_factory.h
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/5e4cbe034c8a74ccbdd62777291ba4dea37c3a92/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/935ce418e4497d827e58db17a34917b8f9ca8c10

commit 935ce418e4497d827e58db17a34917b8f9ca8c10
Author: Eugene Ostroukhov <eostroukhov@chromium.org>
Date: Tue Dec 05 17:48:08 2017

[DevTools] Hooking up IndexedDB live updating

Frontend for IndexedDB live updating.
Based on https://chromium-review.googlesource.com/676273 by Kristi Park.

Bug:  729793 
Change-Id: I8be1c8fafa0377c22eee261b0f00ab62f4bb6cc8
Reviewed-on: https://chromium-review.googlesource.com/798211
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521737}
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-names-expected.txt
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-refresh-view-expected.txt
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-refresh-view.js
[add] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-content-expected.txt
[add] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-content.html
[add] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-list-expected.txt
[add] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-list.html
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/resources-panel-expected.txt
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/resources-panel.js
[add] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/track-valid-origin-expected.txt
[add] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/track-valid-origin.html
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/upgrade-events-expected.txt
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/Source/devtools/front_end/application_test_runner/IndexedDBTestRunner.js
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
[modify] https://crrev.com/935ce418e4497d827e58db17a34917b8f9ca8c10/third_party/WebKit/Source/devtools/front_end/resources/indexedDBViews.css

Comment 9 by eostroukhov@chromium.org, Dec 5 2017

Labels: -Pri-3 Pri-2
Owner: eostroukhov@chromium.org

Comment 10 by eostroukhov@chromium.org, Dec 13 2017 

 Issue 678470  has been merged into this issue.

Comment 11 by dmu...@chromium.org, Dec 14 2017 

Thanks for picking this up Eugene!

Comment 12 by dmu...@chromium.org, May 15 2018

Status: Fixed (was: Started)
f
►

Sign in to add a comment