New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 729783 link

Starred by 2 users
Status: Verified
Owner:
█ cweakliam@google.com
Email to this user bounced
Closed: Jun 2017
Cc:
█ kateso...@chromium.org
wittman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[Predator] Use the builtin python mock module for all mocking.

Project Member Reported by cweakliam@google.com, Jun 5 2017 
Many Predator test cases use ``self.mock`` when mocking methods. This approach is outdated and should be replaced with python's builtin mock module.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bd723b22b2abedd3bd65ccd3b7305822e2da6059

commit bd723b22b2abedd3bd65ccd3b7305822e2da6059
Author: Cathal Weakliam <cweakliam@google.com>
Date: Mon Jun 05 23:34:03 2017

Replace use of self.mock with python mock module

R=katesonia@google.com

Bug:  729783 
Change-Id: I8777864ebad0f04ef887b39ef29ba4b7503e1e91
Reviewed-on: https://chromium-review.googlesource.com/523813
Commit-Queue: Cathal Weakliam <cweakliam@google.com>
Reviewed-by: Sharu Jiang <katesonia@chromium.org>

[modify] https://crrev.com/bd723b22b2abedd3bd65ccd3b7305822e2da6059/appengine/predator/frontend/handlers/test/result_feedback_test.py
[modify] https://crrev.com/bd723b22b2abedd3bd65ccd3b7305822e2da6059/appengine/predator/common/test/findit_test.py
[modify] https://crrev.com/bd723b22b2abedd3bd65ccd3b7305822e2da6059/appengine/predator/common/model/test/crash_analysis_test.py
[modify] https://crrev.com/bd723b22b2abedd3bd65ccd3b7305822e2da6059/appengine/predator/common/model/test/clusterfuzz_analysis_test.py
[modify] https://crrev.com/bd723b22b2abedd3bd65ccd3b7305822e2da6059/appengine/predator/common/model/test/chrome_crash_analysis_test.py
[modify] https://crrev.com/bd723b22b2abedd3bd65ccd3b7305822e2da6059/appengine/predator/common/test/crash_pipeline_test.py
[modify] https://crrev.com/bd723b22b2abedd3bd65ccd3b7305822e2da6059/appengine/predator/analysis/test/changelist_classifier_test.py
[modify] https://crrev.com/bd723b22b2abedd3bd65ccd3b7305822e2da6059/appengine/predator/common/test/findit_for_chromecrash_test.py
[modify] https://crrev.com/bd723b22b2abedd3bd65ccd3b7305822e2da6059/appengine/predator/frontend/handlers/test/crash_handler_test.py

Comment 2 by cweakliam@google.com, Jun 26 2017

Status: Verified (was: Started)
►

Sign in to add a comment