[DevTools] [Quota] Surface per-storage usage information in devtools |
|||
Issue descriptionWhen QuotaManager is expanded to surface per-storage-type usage (like IndexedDB usage, CacheStorage usage, etc), this can be surfaced in DevTools. Note: Other than legacy FileSystem, all storage apis should be applying to the Temporary storage type.
,
Jun 21 2017
Here's the current look of the change
,
Jun 21 2017
,
Jun 21 2017
Awesome! We should make sure to use consistent terminology e.g. "Database" (in the Usage section) should be "Web SQL" (in the Storage) section And can we tweak the string "X storage quota used out of Y" -> "X used out of Y storage quota" ?
,
Jun 21 2017
Thanks for the suggestions! I have a patch going for this change here https://chromium-review.googlesource.com/c/541981/ Let me know if there's other terms that need tweeking.
,
Jun 21 2017
The storage types currently correspond with QuotaClient::ID, so the terms right now: kUnknown -> "Unknown" kFileSystem -> "File System" kDatabase -> "Web SQL" kAppcache -> "Application Cache" kIndexedDatabase -> "IndexedDB" kServiceWorkerCache -> "Service Worker Cache" kServiceWorker -> "Service Worker"
,
Jun 21 2017
kServiceWorkerCache -> "Cache Storage" (this is what's used in the left side panel) Interesting that the "clear" options do not include File System, but we also don't display that in the left panel. It's on the list of APIs we'd like to eliminate, but given that it is used *and* we show the quota contribution, we should probably at least have a checkbox to clear it. Separate bug?
,
Jun 21 2017
Made a bug for that https://bugs.chromium.org/p/chromium/issues/detail?id=735618
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19f69e905f6158f2d22afd25ec20b52b36916639 commit 19f69e905f6158f2d22afd25ec20b52b36916639 Author: kristipark <kristipark@chromium.org> Date: Thu Jun 22 23:19:17 2017 [DevTools] [Quota] Display usage per storage type Bug: 729772 Change-Id: I34b16707b790f65faba01bdcc44bbd98c911b93b Reviewed-on: https://chromium-review.googlesource.com/541981 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#481713} [modify] https://crrev.com/19f69e905f6158f2d22afd25ec20b52b36916639/content/browser/devtools/protocol/storage_handler.cc [modify] https://crrev.com/19f69e905f6158f2d22afd25ec20b52b36916639/third_party/WebKit/LayoutTests/http/tests/inspector/application-panel/storage-view-reports-quota-expected.txt [modify] https://crrev.com/19f69e905f6158f2d22afd25ec20b52b36916639/third_party/WebKit/LayoutTests/http/tests/inspector/application-panel/storage-view-reports-quota.html [modify] https://crrev.com/19f69e905f6158f2d22afd25ec20b52b36916639/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/19f69e905f6158f2d22afd25ec20b52b36916639/third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js [modify] https://crrev.com/19f69e905f6158f2d22afd25ec20b52b36916639/third_party/WebKit/Source/devtools/front_end/resources/clearStorageView.css [modify] https://crrev.com/19f69e905f6158f2d22afd25ec20b52b36916639/third_party/WebKit/Source/devtools/front_end/resources/module.json
,
Jun 22 2017
,
Jun 22 2017
Playing with it now - this is awesome!
,
Jun 22 2017
Great to hear! :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by kristip...@chromium.org
, Jun 19 2017