New issue
Advanced search Search tips

Issue 729771 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.6% regression in scheduler.tough_scheduling_cases at 475685:475831

Project Member Reported by m...@chromium.org, Jun 5 2017

Issue description

See the link to graphs below.
 

Comment 1 by m...@chromium.org, Jun 5 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=729771

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-u2wggkM


Bot(s) for this bug's original alert(s):

win-high-dpi

=== BISECT JOB RESULTS ===
Bisect was unable to run to completion

The bisect was able to narrow the range, you can try running with:
  good_revision: 8e4d09ab6b864897d8399ccda555a61b030ceb84
  bad_revision : e437543b5a4c01773a489e26659a9b05b7d7c365

If failures persist contact the team (see below) and report the error.


Bisect Details
  Configuration: winx64_high_dpi_perf_bisect
  Benchmark    : scheduler.tough_scheduling_cases
  Metric       : queueing_durations/queueing_durations
  Change       : 6.58% | 0.138806392698 -> 0.147939359841

Revision             Result                      N
chromium@475684      0.138806 +- 0.00696823      6      good
chromium@475689      0.138313 +- 0.00511582      6      good
chromium@475692      0.147566 +- 0.00930578      6      bad
chromium@475694      0.146655 +- 0.00671125      6      bad
chromium@475703      0.148207 +- 0.00748684      6      bad
chromium@475721      0.149452 +- 0.0111052       6      bad
chromium@475758      0.149467 +- 0.00694232      6      bad
chromium@475831      0.147939 +- 0.00819499      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests scheduler.tough_scheduling_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8977590334214794656

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6499515034501120


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: sadrul@chromium.org
Owner: sadrul@chromium.org

=== Auto-CCing suspected CL author sadrul@chromium.org ===

Hi sadrul@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : sadrul
  Commit : e437543b5a4c01773a489e26659a9b05b7d7c365
  Date   : Tue May 30 23:39:32 2017
  Subject: input: Immediately start timer for synthetic event dispatch.

Bisect Details
  Configuration: winx64_high_dpi_perf_bisect
  Benchmark    : scheduler.tough_scheduling_cases
  Metric       : queueing_durations/queueing_durations
  Change       : 5.79% | 0.141899583581 -> 0.149000251485

Revision             Result                      N
chromium@475684      0.1419 +- 0.00926645        9       good
chromium@475689      0.141197 +- 0.00356072      9       good
chromium@475691      0.140504 +- 0.00546062      9       good
chromium@475692      0.146383 +- 0.0102578       9       bad       <--
chromium@475694      0.147197 +- 0.0129723       9       bad
chromium@475703      0.145453 +- 0.0118709       14      bad
chromium@475721      0.147733 +- 0.0158329       9       bad
chromium@475758      0.147278 +- 0.0187742       14      bad
chromium@475831      0.149 +- 0.0093725          9       bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests scheduler.tough_scheduling_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8977540373068082496

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6499515034501120


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.

Comment 7 by m...@chromium.org, Jul 27 2017

Cc: -m...@chromium.org
sadrul: any update on this bug? Is it a metrics change that should be WontFixed?
Status: WontFix (was: Assigned)
Wontfix due to inaction over several months.

Sign in to add a comment