New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 729749 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: Jun 2017
Cc:
█ jennschen@chromium.org
thestig@chromium.org
█ kuscher@chromium.org
█ brajkumar@chromium.org
pkasting@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Message boxes and blue buttons

Project Member Reported by afakhry@chromium.org, Jun 5 2017 
Why are the message boxes (for example the profile error dialog) are currently displayed without the blue button? Doesn't the blue button match our MD? Or is the current view WAI?

Actual: dialog_1.png
Expected: dialog_2.png
dialog_1.png
521 KB View Download
dialog_2.png
516 KB View Download

Comment 1 by afakhry@chromium.org, Jun 5 2017

Description: Show this description

Comment 2 by pkasting@chromium.org, Jun 5 2017 

This is the sort of inconsistency we hope to fix as part of Harmony.

Comment 3 by afakhry@chromium.org, Jun 5 2017 

Ok, if this is actually a bug, then let me upload a fix for it. It's a one-liner.

Comment 4 by pkasting@chromium.org, Jun 5 2017 

I'm happy to take a look.

Comment 5 by pkasting@chromium.org, Jun 5 2017 

(At your CL)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfb873220a103ccee2cd0480782a7a238c55c95d

commit bfb873220a103ccee2cd0480782a7a238c55c95d
Author: afakhry <afakhry@chromium.org>
Date: Fri Jun 09 18:48:05 2017

Fix style of profile error dialog.

Profile error dialog should show a blue button to match a material
design look.

BUG= 729749 

Review-Url: https://codereview.chromium.org/2922263002
Cr-Commit-Position: refs/heads/master@{#478352}

[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/autofill/card_unmask_prompt_views.h
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/chrome_cleaner_dialog_win.h
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/global_error_bubble_view.h
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/ime/ime_warning_bubble_view.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/ime/ime_warning_bubble_view.h
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/passwords/account_chooser_dialog_view.h
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/settings_reset_prompt_dialog.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/chrome/browser/ui/views/settings_reset_prompt_dialog.h
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/ui/base/models/dialog_model.h
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/ui/views/window/dialog_client_view.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/ui/views/window/dialog_delegate.cc
[modify] https://crrev.com/bfb873220a103ccee2cd0480782a7a238c55c95d/ui/views/window/dialog_delegate.h

Comment 7 by afakhry@chromium.org, Jun 9 2017

Status: Fixed (was: Assigned)

Comment 8 by brajkumar@chromium.org, Jun 13 2017

Cc: brajkumar@chromium.org
Labels: Needs-Feedback
afakhry@ Could you please let us know is there any manual repro steps available for this issue? I have tested this issue by over installing multiple times to latest builds and older builds unable to see the profile error dialog box for thew new builds but able to see in the older builds .

Comment 9 by afakhry@chromium.org, Jun 13 2017

Labels: -Needs-Feedback
I can manually invoke it on chromeos by doing the following as su:

echo "hakjshdfaksjdhkjshdkajsdhaksjdh" > /home/chronos/Default/History

But there is another bug ( Issue 729701 ) which will prevent you from seeing the profile error dialog altogether. Wait until that is fixed.
►

Sign in to add a comment