VR elements hard code colors in various locations making it hard to keep them up to date and adjust them when the mode changes for fullscreen etc.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9189aa4473f6915826d070f6e3fb008a2904d8f commit f9189aa4473f6915826d070f6e3fb008a2904d8f Author: amp <amp@chromium.org> Date: Tue Jun 06 21:33:07 2017 [VrShell] Centralize color handling and enable close button on fullscreen This updates all of the existing hard coded colors to use colors from the scheme instead of hardcoding (so they can change with the mode). The naming of colors in the scheme was also updated for better consistency and to differentiate from world environment colors. BUG= 719997 , 729729 Review-Url: https://codereview.chromium.org/2914623003 Cr-Commit-Position: refs/heads/master@{#477411} [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/color_scheme.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/color_scheme.h [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/button_texture.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/button_texture.h [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/close_button_texture.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/exit_warning_texture.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/ui_texture.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/ui_texture.h [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/url_bar_texture.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/url_bar_texture.h [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_elements/textured_element.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_scene.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_scene.h [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_scene_manager.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_scene_manager.h [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc [modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/vr_shell_gl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed05197a31887a41b469403b2b497e21bff20c54 commit ed05197a31887a41b469403b2b497e21bff20c54 Author: amp <amp@chromium.org> Date: Wed Jun 07 17:24:55 2017 [VrShell] Centralize color handling and enable close button on fullscreen This updates all of the existing hard coded colors to use colors from the scheme instead of hardcoding (so they can change with the mode). The naming of colors in the scheme was also updated for better consistency and to differentiate from world environment colors. BUG= 719997 , 729729 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2914623003 Cr-Original-Commit-Position: refs/heads/master@{#477411} Review-Url: https://codereview.chromium.org/2926643003 Cr-Commit-Position: refs/branch-heads/3112@{#225} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/color_scheme.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/color_scheme.h [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/button_texture.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/button_texture.h [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/close_button_texture.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/exit_warning_texture.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/ui_texture.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/ui_texture.h [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/url_bar_texture.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/url_bar_texture.h [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_elements/textured_element.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_scene.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_scene.h [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_scene_manager.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_scene_manager.h [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc [modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/vr_shell_gl.cc
Comment 1 by bugdroid1@chromium.org
, Jun 6 2017