Issue metadata
Sign in to add a comment
|
Drag and drop file into the same folder shows "Moving.. " progress message indefinitely |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 60.0.3112.10 (Official Build) dev (64-bit) Revision 0 Platform 9592.8.0 (Official Build) dev-channel caroline What steps will reproduce the problem? 1. Open Downloads folder. 2. Select a file, drag and drop it into the same folder What is the expected result? Nothing should happen What happens instead? "Moving.. " progress message is shown indefinitely Attached screenshot.
,
Jun 6 2017
This happens since eab6fcca575e4781af96c9f1b81265e05f370744.
,
Jun 6 2017
yamaguchi@, thank you for the investigation! tetsui@, could you take a look? If the fix is not going to be simple enough for a merge to M60, let's revert the original change in M60 and master, and reconsider the fix on master.
,
Jun 6 2017
,
Jun 6 2017
I think the progress center should be updated after de-duplicating same entries. Especially when it results 0 copies, there'll be no further update to the progress center, thus results in this issue. https://codereview.chromium.org/2846763002/diff/1/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
,
Jun 6 2017
Sorry, it should be my mistake. I will investigate that.
,
Jun 6 2017
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4167dd7b647e54785386b1eebf66a94c3c5ce6db commit 4167dd7b647e54785386b1eebf66a94c3c5ce6db Author: tetsui <tetsui@chromium.org> Date: Tue Jun 06 06:46:30 2017 Remove early progress center item when no files are copied. Early progress center feedback for copy / move task were added in eab6fcca575e4781af96c9f1b81265e05f370744, but there was a regression which progress center item remains in a case where no files are copied or moved. BUG= 729726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2923123002 Cr-Commit-Position: refs/heads/master@{#477218} [modify] https://crrev.com/4167dd7b647e54785386b1eebf66a94c3c5ce6db/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
,
Jun 6 2017
yamaguchi@: thank you for the investigation! #3 fukino@: Can I add Merge-Request-60 label?
,
Jun 6 2017
Merge request label added!
,
Jun 7 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02fc96ad503355e0f4d1988f12dab6f56508d9d6 commit 02fc96ad503355e0f4d1988f12dab6f56508d9d6 Author: tetsui <tetsui@chromium.org> Date: Fri Jun 09 04:19:43 2017 Remove early progress center item when no files are copied. Early progress center feedback for copy / move task were added in eab6fcca575e4781af96c9f1b81265e05f370744, but there was a regression which progress center item remains in a case where no files are copied or moved. BUG= 729726 NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2923123002 Cr-Original-Commit-Position: refs/heads/master@{#477218} Review-Url: https://codereview.chromium.org/2923953002 Cr-Commit-Position: refs/branch-heads/3112@{#272} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/02fc96ad503355e0f4d1988f12dab6f56508d9d6/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
,
Jun 16 2017
9592.22.0, 60.0.3112.34 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by weifangsun@chromium.org
, Jun 5 2017Owner: yamaguchi@chromium.org
Status: Assigned (was: Untriaged)