New issue
Advanced search Search tips

Issue 729721 link

Starred by 1 user
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Refactor VR Java Tests

Project Member Reported by bsheedy@chromium.org, Jun 5 2017 
The tests and test framework in chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell could use some refactoring, as there currently isn't much consistency about where utility functions and tests are placed.

The basic steps of the refactor are:
1. Split up tests/utils/mocks into different directories.
2. Group utility functions by type in separate files instead of having them all over the place
3. Get rid of generic WebVrTest and VrShellTest files, breaking them up into smaller, more specific files like the current VrShellNavigationTest and VrFeedbackInfoBarTest.

More detailed plans can be found at https://docs.google.com/document/d/1xhpQx2IHUAt50gI6IHPov-sZs22JFHhKejiyDpRmahM/edit
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/651d12dca852b4abb5e01f18a8bd950e52705605

commit 651d12dca852b4abb5e01f18a8bd950e52705605
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Jun 07 19:48:27 2017

VR Java Test Refactor Part 1: Move Files

This is the first part of the VR Java/end-to-end test refactor. All this
CL does is move the *Utils.java and Mock*.java files into subdirectories +
change bits of code to work with the new directory structure.

Two follow-up CLs will refactor the utility/framework code and test files.

Bug:  729721 
Change-Id: Ia02fd396c0d4e3775592c0bd500cc861aaa9ac70
Reviewed-on: https://chromium-review.googlesource.com/523945
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477734}
[modify] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/BUILD.gn
[modify] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrFeedbackInfoBarTest.java
[modify] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java
[modify] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[modify] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestRule.java
[modify] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
[rename] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/mock/MockVrCoreVersionCheckerImpl.java
[rename] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/mock/MockVrDaydreamApi.java
[modify] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/nfc_apk/SimNfcActivity.java
[rename] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/NfcSimUtils.java
[rename] https://crrev.com/651d12dca852b4abb5e01f18a8bd950e52705605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrUtils.java
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42dec6f21e3cece9d3e6448f832b1331751180f9

commit 42dec6f21e3cece9d3e6448f832b1331751180f9
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Jun 09 23:24:32 2017

VR Java Test Refactor Part 2: Utility Code

This is the second part of the VR Java/end-to-end test refactor. This CL
moves various existing utility functions into better categorized files.

One more follow-up CL will refactor the test files themselves.

Bug:  729721 
Change-Id: I51b64e47a09043a4a660df26de939bb9805d5d3a
Reviewed-on: https://chromium-review.googlesource.com/527535
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478449}
[modify] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/BUILD.gn
[modify] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrFeedbackInfoBarTest.java
[modify] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java
[modify] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[modify] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestRule.java
[modify] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
[add] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/CardboardUtils.java
[modify] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/NfcSimUtils.java
[add] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrInfoBarUtils.java
[add] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrShellDelegateUtils.java
[add] https://crrev.com/42dec6f21e3cece9d3e6448f832b1331751180f9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrTransitionUtils.java
[delete] https://crrev.com/d626453911a21cc606c9e6688da109291aecf25f/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrUtils.java
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4abd1664c3858b0bccf0520871dd2bb86fcad0a2

commit 4abd1664c3858b0bccf0520871dd2bb86fcad0a2
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Jun 13 19:37:01 2017

VR Java Test Refactor Part 3: Test Classes

This is the third and final part of the VR Java/end-to-end test refactor.
This CL moves various existing tests from generic test classes into more
specific ones.

Bug:  729721 
Change-Id: I2527b2d580efe0e517ee25e2531ca911e57a1285
Reviewed-on: https://chromium-review.googlesource.com/532273
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479098}
[modify] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/BUILD.gn
[add] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrInstallUpdateInfoBarTest.java
[add] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellCompositorViewHolderTest.java
[add] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellControllerInputTest.java
[modify] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java
[delete] https://crrev.com/115c560f5886afd3c512d054c988439893974f24/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[add] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTransitionTest.java
[modify] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestRule.java
[add] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrDeviceTest.java
[add] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java
[add] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTabTest.java
[delete] https://crrev.com/115c560f5886afd3c512d054c988439893974f24/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
[add] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
[modify] https://crrev.com/4abd1664c3858b0bccf0520871dd2bb86fcad0a2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrTransitionUtils.java

Comment 4 by bsheedy@chromium.org, Jun 13 2017

Status: Fixed (was: Started)
►

Sign in to add a comment