increase size of keyword hint view text |
||||
Issue descriptionthe size and layout of the keyword hint view should be adjusted. Hwi, can you attack the mock? AFAICT there's no way to extract an image from a google doc if it's only a suggested change.
,
Jun 5 2017
ha, "attack" the mock. Thanks!
,
Jun 5 2017
It worked anyway =) Thanks!
,
Jun 5 2017
+maxwalker fyi
,
Jun 6 2017
ahhh so I think the problem is that we have a bug where the text is super tiny in touch hybrid mode. In normal mode the text is already 11 and we can't make it much bigger or match the above mocks because the above mocks seem to assume hybrid mode (i.e. the location bar is 30dp tall, as opposed to 25dp in normal mode).
,
Jun 6 2017
- What's the current text size of "Tab"? - Could we try "-2pt" and "-1pt" from the sounded text's size for "Tab" and see how they look?
,
Jun 6 2017
the text size depends on your font face. We derive the largest font that will fit within the given bounds. That comes out to 11 on my machine but could be different for a different platform or font. I'm working on fixing the touch hybrid version.
,
Jun 6 2017
how does this look?
,
Jun 6 2017
c#8 looks good to me. Thanks! Side note: Another way might be using a proportional size(x% of the given height) but I don't think we need that.
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6416ba5d192d3d123b9ba75ff76fd1fa40900b37 commit 6416ba5d192d3d123b9ba75ff76fd1fa40900b37 Author: Evan Stade <estade@chromium.org> Date: Wed Jun 07 16:18:56 2017 Fix omnibox keyword hint bubble for touch-hybrid mode. The bubble itself should have 4dip of padding above and below regardless of whether it's touch hybrid or normal mode (previously it was 6dip for touch hybrid and 4dip for normal). The padding interior to the bubble is also adjusted by 1dip to make the text slightly bigger in hybrid mode. Bug: 729719 Change-Id: I494e63aa181cb4a403b6d2f71c216bb8d0b7acfd Reviewed-on: https://chromium-review.googlesource.com/525996 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#477672} [modify] https://crrev.com/6416ba5d192d3d123b9ba75ff76fd1fa40900b37/chrome/browser/ui/layout_constants.cc [modify] https://crrev.com/6416ba5d192d3d123b9ba75ff76fd1fa40900b37/chrome/browser/ui/layout_constants.h [modify] https://crrev.com/6416ba5d192d3d123b9ba75ff76fd1fa40900b37/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/6416ba5d192d3d123b9ba75ff76fd1fa40900b37/chrome/browser/ui/views/location_bar/keyword_hint_view.cc [modify] https://crrev.com/6416ba5d192d3d123b9ba75ff76fd1fa40900b37/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/6416ba5d192d3d123b9ba75ff76fd1fa40900b37/chrome/browser/ui/views/location_bar/location_bar_view.h
,
Jun 15 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by hwi@chromium.org
, Jun 5 201729.9 KB
29.9 KB View Download