New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729710 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

UI issues blocking desktop PR launch

Project Member Reported by anthonyvd@chromium.org, Jun 5 2017

Issue description

* Information "previews" should be vertically centered with "Choose" button and label for row (see empty states in mocks)
* Num extra items should be after other items and before total
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0710b613bfc1756643ed7095f6ae51b23d9bea8c

commit 0710b613bfc1756643ed7095f6ae51b23d9bea8c
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Mon Jun 05 23:57:48 2017

[Web Payments] Payment Sheet UI fixes

Prevent "and 0 more" in the previews
Move "1 more item" in inline summary to line before total
Don't display "1 more item"
Center content and name with button

Bug:  729710 
Change-Id: I5cf1ea3262196938af78080866a207c4ec377856
Reviewed-on: https://chromium-review.googlesource.com/523677
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477126}
[modify] https://crrev.com/0710b613bfc1756643ed7095f6ae51b23d9bea8c/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/0710b613bfc1756643ed7095f6ae51b23d9bea8c/components/payments_strings.grdp

Comment 2 by ma...@chromium.org, Jun 6 2017

Labels: Merge-Request-60
Status: Fixed (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 7 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: There is .grd file changes and we are only 54 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Anthony, would you mind helping us in verifying the fix in latest canary 
in order to proceed with merge approval.
Verified on 61.0.3123.0 (Official Build) 
Labels: -Merge-Review-60 Merge-Approved-60
Thanks!  Approving for merge into M60 as this is a small change and blocking a launch.
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 12 2017

Cc: ma...@chromium.org bustamante@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge the patch to M60 branch(3112),Beta RC cut is scheduled @ 4.00 PM PST tomorrow(06/13).
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 13 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd5d606a416e2809a76dbd055bd1ffec00d32af8

commit cd5d606a416e2809a76dbd055bd1ffec00d32af8
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Tue Jun 13 14:49:36 2017

Merge - [Web Payments] Payment Sheet UI fixes

Prevent "and 0 more" in the previews
Move "1 more item" in inline summary to line before total
Don't display "1 more item"
Center content and name with button

TBR=anthonyvd@chromium.org

(cherry picked from commit 0710b613bfc1756643ed7095f6ae51b23d9bea8c)

Bug:  729710 
Change-Id: I5cf1ea3262196938af78080866a207c4ec377856
Reviewed-on: https://chromium-review.googlesource.com/523677
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#477126}
Reviewed-on: https://chromium-review.googlesource.com/533393
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#317}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/cd5d606a416e2809a76dbd055bd1ffec00d32af8/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/cd5d606a416e2809a76dbd055bd1ffec00d32af8/components/payments_strings.grdp

Labels: -Pri-3 Pri-0
Status: Untriaged (was: Fixed)
Hello, this merge broke the official build; see  issue 732887 , this requires immediate attention from someone on the payments team or the CL in question will be reverted. Since this is marked as a PR launch let me know if reverting is okay.
Status: Assigned (was: Untriaged)
On it, I'll revert this for now as it looks like it depends on another CL and I bork'd the merge.
Thanks!
Cc: hdodda@chromium.org
Labels: Needs-Feedback
@Anthony-- If this can be verified manually from test team end , please provide us the steps to verify.

Thanks!
Labels: -Hotlist-Merge-Review -Pri-0 -M-60 M-61 Pri-1
Status: Fixed (was: Assigned)
Since we're not merging this to 60 anymore, there's nothing more to do here.
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment