UI issues blocking desktop PR launch |
||||||||||||
Issue description* Information "previews" should be vertically centered with "Choose" button and label for row (see empty states in mocks) * Num extra items should be after other items and before total
,
Jun 6 2017
,
Jun 7 2017
This bug requires manual review: There is .grd file changes and we are only 54 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 7 2017
Anthony, would you mind helping us in verifying the fix in latest canary in order to proceed with merge approval.
,
Jun 7 2017
Verified on 61.0.3123.0 (Official Build)
,
Jun 7 2017
Thanks! Approving for merge into M60 as this is a small change and blocking a launch.
,
Jun 12 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2017
Please merge the patch to M60 branch(3112),Beta RC cut is scheduled @ 4.00 PM PST tomorrow(06/13).
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd5d606a416e2809a76dbd055bd1ffec00d32af8 commit cd5d606a416e2809a76dbd055bd1ffec00d32af8 Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Tue Jun 13 14:49:36 2017 Merge - [Web Payments] Payment Sheet UI fixes Prevent "and 0 more" in the previews Move "1 more item" in inline summary to line before total Don't display "1 more item" Center content and name with button TBR=anthonyvd@chromium.org (cherry picked from commit 0710b613bfc1756643ed7095f6ae51b23d9bea8c) Bug: 729710 Change-Id: I5cf1ea3262196938af78080866a207c4ec377856 Reviewed-on: https://chromium-review.googlesource.com/523677 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#477126} Reviewed-on: https://chromium-review.googlesource.com/533393 Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#317} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/cd5d606a416e2809a76dbd055bd1ffec00d32af8/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/cd5d606a416e2809a76dbd055bd1ffec00d32af8/components/payments_strings.grdp
,
Jun 13 2017
Hello, this merge broke the official build; see issue 732887 , this requires immediate attention from someone on the payments team or the CL in question will be reverted. Since this is marked as a PR launch let me know if reverting is okay.
,
Jun 13 2017
On it, I'll revert this for now as it looks like it depends on another CL and I bork'd the merge.
,
Jun 13 2017
Thanks!
,
Jun 14 2017
@Anthony-- If this can be verified manually from test team end , please provide us the steps to verify. Thanks!
,
Jun 20 2017
,
Jun 21 2017
Since we're not merging this to 60 anymore, there's nothing more to do here.
,
Jun 27 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 5 2017