New issue
Advanced search Search tips

Issue 729703 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

SSL Browser Tests incorrect in the face of fieldtrial_testing_config.json

Project Member Reported by elawrence@chromium.org, Jun 5 2017

Issue description

In ssl_browser_tests.cc, we have various tests that CreateFieldTrial with kMarkHttpAsDangerous. This field trial is overridden by the fieldtrial_testing_config.json settings.

We also don't have a test that actually tests that MarkHttpAsDangerous marks HTTP as dangerous.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22f6d5b3389c0b066ae841d12889373818cabfc0

commit 22f6d5b3389c0b066ae841d12889373818cabfc0
Author: elawrence <elawrence@chromium.org>
Date: Tue Jun 06 23:15:07 2017

Add MarkHttpAsDangerous test and correct other MarkNonSecureAs tests

In ssl_browser_tests.cc, we have various tests that CreateFieldTrial
with kMarkHttpAsDangerous. This field trial is overridden by the
fieldtrial_testing_config.json settings and therefore these calls
are ineffective. This CL overrides the fieldtrial_testing settings.

We also didn't have a test that actually tests that the setting
MarkHttpAsDangerous marks HTTP as dangerous. This CL adds such
a test.

BUG= 729703 

Review-Url: https://codereview.chromium.org/2928453002
Cr-Commit-Position: refs/heads/master@{#477456}

[modify] https://crrev.com/22f6d5b3389c0b066ae841d12889373818cabfc0/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/22f6d5b3389c0b066ae841d12889373818cabfc0/testing/variations/fieldtrial_testing_config.json

Status: Fixed (was: Started)

Sign in to add a comment