Issue metadata
Sign in to add a comment
|
Regression: On profile error, UI shows nothing but the wallpaper after login |
||||||||||||||||||||
Issue description
- Trigger a manual profile error by running:
echo "sjkhdgasjdhdfgadjhgfdajshgd" > /home/chronos/Default/History
- Reboot
- Login and observe that the UI is empty.
Expected:
- After login, you get the profile error dialog as in screenshot_1.
Actual:
- UI is empty [screenshot_2]
Bisecting ... Culprtit CL is https://codereview.chromium.org/2891223002. Assigning to xiyuan.
,
Jun 5 2017
The profile error dialog runs a nested message loop. It seems to me that mojo messages are not delivered when there is a nested message loop. As a result, ACTIVE session state is not delivered to ash. Hence the wallpaper is not moved.
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2404367d4408db72ffdda3a5d7e520ce9c4f4590 commit 2404367d4408db72ffdda3a5d7e520ce9c4f4590 Author: xiyuan <xiyuan@chromium.org> Date: Wed Jun 14 15:17:29 2017 Make profile error dialog async So that it does not run a nested message loop to block mojo messages. BUG= 729701 Review-Url: https://codereview.chromium.org/2929953002 Cr-Commit-Position: refs/heads/master@{#479389} [modify] https://crrev.com/2404367d4408db72ffdda3a5d7e520ce9c4f4590/chrome/browser/ui/android/simple_message_box_android.cc [modify] https://crrev.com/2404367d4408db72ffdda3a5d7e520ce9c4f4590/chrome/browser/ui/cocoa/simple_message_box_mac.mm [modify] https://crrev.com/2404367d4408db72ffdda3a5d7e520ce9c4f4590/chrome/browser/ui/profile_error_dialog.cc [modify] https://crrev.com/2404367d4408db72ffdda3a5d7e520ce9c4f4590/chrome/browser/ui/simple_message_box.h [modify] https://crrev.com/2404367d4408db72ffdda3a5d7e520ce9c4f4590/chrome/browser/ui/views/simple_message_box_views.cc
,
Jun 14 2017
,
Jun 15 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 19 2017
,
Jun 23 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 23 2017
Merged to branch 3112 in https://codereview.chromium.org/2951503002/
,
Jan 22 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by xiy...@chromium.org
, Jun 5 2017