New issue
Advanced search Search tips

Issue 729689 link

Starred by 1 user
Status: Assigned
Owner:
wychen@chromium.org
Cc:
twelling...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 728655


Sign in to add a comment

Turn on "use strict" in JS minifier

Project Member Reported by wychen@chromium.org, Jun 5 2017 
In grit, JavaScript files are minified using closure compiler (on Android only for now). The output is in ES6 without "use strict", until a roll in https://codereview.chromium.org/2918683002, which adds "use strict" by default for ES6 (now called ES2015).

Having "use strict" caused failures in DOM distiller, which is tracked in issue 728655. Even though turning "use strict" on in that roll was accidental, we should fix the regression and turn it on for real, to make our JavaScript more future proof.

DOM distiller is the only known issue, but there might be other regressions with "use strict" that's not covered by tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14fb5d1f03c1d705a5c0e1d33904df5da7153221

commit 14fb5d1f03c1d705a5c0e1d33904df5da7153221
Author: wychen <wychen@chromium.org>
Date: Tue Jun 06 04:18:58 2017

Reverse accidental enabling of 'use strict' in closure compiler

In grit, JavaScript files are minified using closure compiler. The output
is in ES6 without "use strict", until a roll in
https://codereview.chromium.org/2918683002, which adds "use strict" by default
for ES6 (now called ES2015).

Having "use strict" caused failures in DOM distiller and probably other things,
so we need to fix them first.

BUG=728655, 729689
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2921143002
Cr-Commit-Position: refs/heads/master@{#477192}

[modify] https://crrev.com/14fb5d1f03c1d705a5c0e1d33904df5da7153221/components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc
[modify] https://crrev.com/14fb5d1f03c1d705a5c0e1d33904df5da7153221/third_party/closure_compiler/closure_args.gni

Comment 2 by wychen@chromium.org, Jun 6 2017

Blockedon: 728655

Comment 3 by amaralp@chromium.org, Apr 12 2018

Labels: android-fe-triaged
Owner: wychen@chromium.org
Status: Assigned (was: Untriaged)
►

Sign in to add a comment