New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729656 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Budget API needs to properly share milliseconds instead of seconds

Project Member Reported by peter@chromium.org, Jun 5 2017

Issue description

Apparently we've not been doing this diligently, leading to a bug spotted by Matt. Fix upcoming.
 

Comment 2 by peter@chromium.org, Jun 6 2017

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 7 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge the patch to M60 branch(3112),Beta RC cut is scheduled @ 4.00 PM PST today(06/07).

Project Member

Comment 5 by sheriffbot@chromium.org, Jun 12 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Ping.

Comment 7 by peter@chromium.org, Jun 13 2017

Done now, sorry for the delay. ligimole@, it's very confusing that some of these "automated" approvals come immediately, and some take more than a day. Why does this happen?
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 13 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b2aad48388c9af18b28d536d1dc4368d877a153

commit 3b2aad48388c9af18b28d536d1dc4368d877a153
Author: Peter Beverloo <peter@chromium.org>
Date: Tue Jun 13 12:27:17 2017

Always use milliseconds in the Budget API implementation

BUG= 729656 

Review-Url: https://codereview.chromium.org/2922203002
Cr-Original-Commit-Position: refs/heads/master@{#477147}
Review-Url: https://codereview.chromium.org/2934063002 .
Cr-Commit-Position: refs/branch-heads/3112@{#315}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/3b2aad48388c9af18b28d536d1dc4368d877a153/chrome/browser/budget_service/budget_database.cc
[modify] https://crrev.com/3b2aad48388c9af18b28d536d1dc4368d877a153/chrome/browser/budget_service/budget_database_unittest.cc
[modify] https://crrev.com/3b2aad48388c9af18b28d536d1dc4368d877a153/chrome/browser/budget_service/budget_service_impl.cc

Comment 9 by peter@chromium.org, Jun 14 2017

Status: Fixed (was: Started)

Sign in to add a comment