Use data file for mac face detection test |
|||
Issue descriptionCurrently the face detection test for mac uses an inlined base64 encoded jpg. https://cs.chromium.org/chromium/src/services/shape_detection/face_detection_impl_mac_unittest.mm?l=33 This file now exists at services/test/data/mona_lisa.jpg, so we should use it.
,
Sep 18 2017
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3c3f343acf536583cdc8d25ae694837b6590c02 commit c3c3f343acf536583cdc8d25ae694837b6590c02 Author: junweifu <junwei.fu@intel.com> Date: Thu Sep 21 07:05:27 2017 ShapeDetection: Use existing image file for mac face detection test Use existing image file instead of current inlined base64 encoded data. Remove Try Catch of creating frame from bitmap because the |bitmap| is valid parameter. BUG= 729653 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Change-Id: I718570aedfe17a937a7f455fc5debe072cac0783 Reviewed-on: https://chromium-review.googlesource.com/670146 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#503378} [modify] https://crrev.com/c3c3f343acf536583cdc8d25ae694837b6590c02/services/shape_detection/BUILD.gn [modify] https://crrev.com/c3c3f343acf536583cdc8d25ae694837b6590c02/services/shape_detection/android/java/src/org/chromium/shape_detection/BitmapUtils.java [modify] https://crrev.com/c3c3f343acf536583cdc8d25ae694837b6590c02/services/shape_detection/face_detection_impl_mac_unittest.mm
,
Sep 21 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mcasas@chromium.org
, Jun 5 2017