New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 729646 link

Starred by 3 users
Status: Fixed
Owner:
█ chenwilliam@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: create invariant check for bundled module file in Source/devtools/BUILD.gn

Project Member Reported by chenwilliam@chromium.org, Jun 5 2017 
It's easy to forget to add this one-line in our BUILD.gn file when you add a new front-end module, which can be very problematic since it may be able to pass through CQ and cause regressions. [0] [1]

The plan is to create an invariant check in our PRESUBMIT script to ensure that a BUILD.gn file *could* be valid and is definitely not invalid.

[0]  crbug.com/729011 
[1] https://codereview.chromium.org/2879943003
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed6ec852ac94bcd64f7a9b7fb279916adb1cf22c

commit ed6ec852ac94bcd64f7a9b7fb279916adb1cf22c
Author: chenwilliam <chenwilliam@chromium.org>
Date: Thu Jun 08 23:53:23 2017

DevTools: check BUILD.gn file as part of PRESUBMIT

This PRESUBMIT check only takes ~0.12 seconds on my workstation.

It actually caught a real issue with our existing BUILD.gn as it accidentally
included the generated terminal_module.js (a 104kb file) in the Chrome binary.

BUG= 729646 

Review-Url: https://codereview.chromium.org/2926563004
Cr-Commit-Position: refs/heads/master@{#478125}

[modify] https://crrev.com/ed6ec852ac94bcd64f7a9b7fb279916adb1cf22c/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/ed6ec852ac94bcd64f7a9b7fb279916adb1cf22c/third_party/WebKit/Source/devtools/PRESUBMIT.py
[modify] https://crrev.com/ed6ec852ac94bcd64f7a9b7fb279916adb1cf22c/third_party/WebKit/Source/devtools/package.json
[add] https://crrev.com/ed6ec852ac94bcd64f7a9b7fb279916adb1cf22c/third_party/WebKit/Source/devtools/scripts/check_gn.js

Comment 2 by chenwilliam@chromium.org, Jun 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment