Issue metadata
Sign in to add a comment
|
[Payments] [Desktop] Accessibility readout for input fields is not quite right |
||||||||||||||||||||||||
Issue description(0) Activate VoiceOver on mac (1) Add a credit card. (2) Go to edit the credit card, and have it read the input field for card number as you are changing it. It reads the wrong values.
,
Jun 5 2017
,
Jun 6 2017
,
Jun 6 2017
Sent an email to Trent and Patti to see if we could reasonably fix this.
,
Jun 7 2017
If it's ok, I'll merge this with the existing bug and assign you it - feel free to edit as you feel necessary.
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c40f49bfd5d6574449f8fb8bdb774684f5355094 commit c40f49bfd5d6574449f8fb8bdb774684f5355094 Author: mathp <mathp@chromium.org> Date: Mon Jun 12 13:29:55 2017 [Payments] Improve some accessibility labels in editors BUG= 729633 TEST=VoiceOver Review-Url: https://codereview.chromium.org/2931503002 Cr-Commit-Position: refs/heads/master@{#478600} [modify] https://crrev.com/c40f49bfd5d6574449f8fb8bdb774684f5355094/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc [modify] https://crrev.com/c40f49bfd5d6574449f8fb8bdb774684f5355094/chrome/browser/ui/views/payments/editor_view_controller.cc
,
Jun 12 2017
,
Jun 13 2017
The bug is marked as P3 or Feature. It should not be merged as M60 is in beta. Please contact the approriate milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 15 2017
Trying again with the merge request, accessibility is important.
,
Jun 15 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 16 2017
Accessibility bug, small fix - approving merge to m60.
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02d8551dfe076a0ed784c8f307a6132fe1fc3c22 commit 02d8551dfe076a0ed784c8f307a6132fe1fc3c22 Author: Mathieu Perreault <mathp@chromium.org> Date: Fri Jun 16 20:16:15 2017 [Payments] Improve some accessibility labels in editors BUG= 729633 TEST=VoiceOver TBR=mathp@chromium.org (cherry picked from commit c40f49bfd5d6574449f8fb8bdb774684f5355094) Review-Url: https://codereview.chromium.org/2931503002 Cr-Original-Commit-Position: refs/heads/master@{#478600} Change-Id: Iaa1d4f6e7cac2b985b03a85ee76ffaf420961940 Reviewed-on: https://chromium-review.googlesource.com/538818 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#364} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/02d8551dfe076a0ed784c8f307a6132fe1fc3c22/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc [modify] https://crrev.com/02d8551dfe076a0ed784c8f307a6132fe1fc3c22/chrome/browser/ui/views/payments/editor_view_controller.cc
,
Jun 21 2017
Tested the issue on Mac OS 10.12.5 using chrome latest Beta M60-60.0.3112.40 by following steps mentioned in the original comment. Observed that VO announces an old value of the text field(Previously entered value) @mathp: Could you please let me know if i have missed anything.Please find the screen cast for reference. Thank you!
,
Jun 21 2017
@rbasuvula follow 657884 for the fix for that.
My fix here was to announce what type each field way ("credit card name", "expiration date", etc.)
,
Jun 27 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ma...@chromium.org
, Jun 5 2017