New issue
Advanced search Search tips

Issue 729633 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 657884
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Payments] [Desktop] Accessibility readout for input fields is not quite right

Project Member Reported by ma...@chromium.org, Jun 5 2017

Issue description

(0) Activate VoiceOver on mac
(1) Add a credit card.
(2) Go to edit the credit card, and have it read the input field for card number as you are changing it.

It reads the wrong values.
 

Comment 1 by ma...@chromium.org, Jun 5 2017

Over to Anthony for triage

Comment 2 by ma...@chromium.org, Jun 5 2017

Summary: [Payments] [Desktop] Accessibility readout for input fields is not quite right (was: [Payments] [Desktop] Accessibility readout for input fields is off)

Comment 3 by ma...@chromium.org, Jun 6 2017

Owner: ma...@chromium.org

Comment 4 by ma...@chromium.org, Jun 6 2017

Cc: tapted@chromium.org patricia...@chromium.org
Sent an email to Trent and Patti to see if we could reasonably fix this.
Mergedinto: 657884
Status: Duplicate (was: Assigned)
If it's ok, I'll merge this with the existing bug and assign you it - feel free to edit as you feel necessary.

Comment 7 by ma...@chromium.org, Jun 12 2017

Labels: Merge-Request-60
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 13 2017

Labels: -Merge-Request-60 Merge-Reject-60 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M60 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by ma...@chromium.org, Jun 15 2017

Labels: -Pri-3 -Merge-Reject-60 -Hotlist-Merge-Reject Merge-Request-60 Pri-2
Trying again with the merge request, accessibility is important.
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 15 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Accessibility bug, small fix - approving merge to m60.
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 16 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02d8551dfe076a0ed784c8f307a6132fe1fc3c22

commit 02d8551dfe076a0ed784c8f307a6132fe1fc3c22
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Jun 16 20:16:15 2017

[Payments] Improve some accessibility labels in editors

BUG= 729633 
TEST=VoiceOver
TBR=mathp@chromium.org

(cherry picked from commit c40f49bfd5d6574449f8fb8bdb774684f5355094)

Review-Url: https://codereview.chromium.org/2931503002
Cr-Original-Commit-Position: refs/heads/master@{#478600}
Change-Id: Iaa1d4f6e7cac2b985b03a85ee76ffaf420961940
Reviewed-on: https://chromium-review.googlesource.com/538818
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#364}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/02d8551dfe076a0ed784c8f307a6132fe1fc3c22/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/02d8551dfe076a0ed784c8f307a6132fe1fc3c22/chrome/browser/ui/views/payments/editor_view_controller.cc

Labels: Needs-Feedback
Tested the issue on Mac OS 10.12.5 using chrome latest Beta M60-60.0.3112.40 by following steps mentioned in the original comment. Observed that VO announces an old value of the text field(Previously entered value)

@mathp: Could you please let me know if i have missed anything.Please find the screen cast for reference.

Thank you!
729633.mp4
1.1 MB View Download

Comment 14 by ma...@chromium.org, Jun 21 2017

@rbasuvula follow  657884 for the fix for that. 

My fix here was to announce what type each field way ("credit card name", "expiration date", etc.)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment