New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729621 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

suspend_stress_test is causing cdmem process crash.

Project Member Reported by son...@google.com, Jun 5 2017

Issue description

Chrome Version: 9592.5.0
OS: Chrome

What steps will reproduce the problem?
(1) Sign in to the device.
(2) Run "suspend_stress_test"


What is the expected result?
Should not get any error messages.

What happens instead?
Getting error message "cbmem: cbmem.c:684: void dump_console(int): Assertion `!regcomp(&re, regex[i], 0)' failed. Aborted (core dumped)".

Observed cdmem crashes during suspend.
crash report link: https://crash.corp.google.com/browse?stbtiq=4c9f70def0000000

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by ka...@chromium.org, Jun 5 2017

Labels: -Stability_crash Stability-Crash

Comment 3 by son...@google.com, Jun 8 2017

Cc: pgangishetty@chromium.org ka...@chromium.org rjahagir@chromium.org sontis@chromium.org snanda@chromium.org
 Issue 731215  has been merged into this issue.

Comment 4 by tbroch@chromium.org, Jun 10 2017

Owner: jwer...@chromium.org
Status: Assigned (was: Untriaged)
Yeah, this is really odd, it shouldn't do that. I can see a few hundred crashes for this uploaded to the crash server... but they are restricted to only 5 client IDs (a Quawks, a Falco, a Rikku, a Ninja and a Candy... but those aren't even the same chipsets!). I've installed the same image on my Falco but it runs the test just fine.

Does this only happen a few times for you or is it 100% reproducible? Does it happen right after the first iteration of the test or only at some later time?

If you have DUTs that can reproduce this it might be easiest if I borrow one of those from you.
Okay, I can reproduce it now. Seems to be the difference between a test and a base image. Maybe some missing library? I'll find out...
Labels: Merge-Request-60
Oh, actually, it's just a very simple bug. Not sure why I couldn't repro it at first... must have screwed up when installing the image.

Since the offending CL made it into R60 (https://chromium-review.googlesource.com/c/509513/) I'll need to merge the fix back (once it lands upstream). It is very trivial: https://review.coreboot.org/#/c/20171/
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 13 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 16 2017

Labels: merge-merged-chromeos-2016.05
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/a1d1941d62453658c48912d805c9e6b2e3dc2602

commit a1d1941d62453658c48912d805c9e6b2e3dc2602
Author: Julius Werner <jwerner@chromium.org>
Date: Fri Jun 16 00:27:54 2017

UPSTREAM: cbmem: Escape literal asterisks in log banner regex

I had a stupid. :( Asterisks have a special meaning in regexes, but I
just wanted to match three literal ones. This kills the regex parser.

BUG= chromium:729621 

Change-Id: Ia6149e72715d651c914583ed3235680ce5b7a2e0
Signed-off-by: Julius Werner <jwerner@chromium.org>
Original-Reviewed-on: https://review.coreboot.org/20171
Original-Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Original-Reviewed-by: Philippe Mathieu-Daud <philippe.mathieu.daude@gmail.com>
Reviewed-on: https://chromium-review.googlesource.com/537138

[modify] https://crrev.com/a1d1941d62453658c48912d805c9e6b2e3dc2602/util/cbmem/cbmem.c

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 16 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/1342b608d7458220cd727037b8c37752201cabe8

commit 1342b608d7458220cd727037b8c37752201cabe8
Author: Julius Werner <jwerner@chromium.org>
Date: Fri Jun 16 01:00:12 2017

UPSTREAM: cbmem: Escape literal asterisks in log banner regex

I had a stupid. :( Asterisks have a special meaning in regexes, but I
just wanted to match three literal ones. This kills the regex parser.

BUG= chromium:729621 

Change-Id: Ia6149e72715d651c914583ed3235680ce5b7a2e0
Signed-off-by: Julius Werner <jwerner@chromium.org>
Original-Reviewed-on: https://review.coreboot.org/20171
Original-Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Original-Reviewed-by: Philippe Mathieu-Daud <philippe.mathieu.daude@gmail.com>
Reviewed-on: https://chromium-review.googlesource.com/537138
(cherry picked from commit a1d1941d62453658c48912d805c9e6b2e3dc2602)
Reviewed-on: https://chromium-review.googlesource.com/537977

[modify] https://crrev.com/1342b608d7458220cd727037b8c37752201cabe8/util/cbmem/cbmem.c

Status: Fixed (was: Assigned)
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 19 2017

Cc: josa...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-60
Status: Verified (was: Fixed)
Verified on build 9592.37.0

Sign in to add a comment