New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729614 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

GetVRDisplays returns 0 devices when WebVR site is access in VrShell

Project Member Reported by amp@chromium.org, Jun 5 2017

Issue description

Chrome Version: 61.0.3119.0
OS: Android

What steps will reproduce the problem?
(1) Enter VrShell (using a daydream device or through dev flag menu).
(2) Navigate to https://webvr.info/samples/03-vr-presentation.html

What is the expected result?
WebVR should return expected devices and an 'Enter VR' buttons display.

What happens instead?
WebVR returns 0 devices available.

 

Comment 1 by amp@chromium.org, Jun 5 2017

This was caused by https://codereview.chromium.org/2915993004 and reverting that is a potential fix (but it would break some tests that were fixed after that change went in).

https://codereview.chromium.org/2916423002/ is a potential fix as well (although somewhat messy).
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0376a2d193d886e60e2e618be407e4a262446df

commit c0376a2d193d886e60e2e618be407e4a262446df
Author: amp <amp@chromium.org>
Date: Mon Jun 05 22:36:17 2017

[WebVR] Handle slow connecting devices.

A race condition exists when entering WebVR while already in VR (from
VrShell) which slows down devices connecting.  We keep track if we have
seen an immediate handling of the device without a connection (which
signifies that libraries aren't loaded) which allows us to return a 0
count in that case, but return non-zero in the case where a device will
eventually connect.

BUG= 729614 

Review-Url: https://codereview.chromium.org/2916423002
Cr-Commit-Position: refs/heads/master@{#477103}

[modify] https://crrev.com/c0376a2d193d886e60e2e618be407e4a262446df/device/vr/vr_service_impl.cc
[modify] https://crrev.com/c0376a2d193d886e60e2e618be407e4a262446df/device/vr/vr_service_impl.h

Comment 3 by amp@chromium.org, Jun 6 2017

Labels: M-60
Tagging M-60 as the change here will need to be merged back to 60 along with https://codereview.chromium.org/2915993004 to make sure we don't break VrShell to WebVR transitions when we fix the promise resolving for  issue 727969 .

Comment 4 by amp@chromium.org, Jun 6 2017

Labels: Merge-Request-60
Verified on Canary 61.0.3122.0, requesting merge to 60.
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 6 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 6 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d15601fcab3d91e87952272473056bfc82f8f141

commit d15601fcab3d91e87952272473056bfc82f8f141
Author: amp <amp@chromium.org>
Date: Tue Jun 06 16:46:23 2017

[WebVR] Handle slow connecting devices.

A race condition exists when entering WebVR while already in VR (from
VrShell) which slows down devices connecting.  We keep track if we have
seen an immediate handling of the device without a connection (which
signifies that libraries aren't loaded) which allows us to return a 0
count in that case, but return non-zero in the case where a device will
eventually connect.

BUG= 729614 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2916423002
Cr-Original-Commit-Position: refs/heads/master@{#477103}
Review-Url: https://codereview.chromium.org/2923823002
Cr-Commit-Position: refs/branch-heads/3112@{#186}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/d15601fcab3d91e87952272473056bfc82f8f141/device/vr/vr_service_impl.cc
[modify] https://crrev.com/d15601fcab3d91e87952272473056bfc82f8f141/device/vr/vr_service_impl.h

Comment 7 by amp@chromium.org, Jun 6 2017

Status: Fixed (was: Started)
Components: Blink>WebXR

Sign in to add a comment