New issue
Advanced search Search tips

Issue 729607 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

CrSettingsInternetPageTest.All is flaky on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Project Member Reported by dpranke@chromium.org, Jun 5 2017

Issue description

Components: UI>Browser>WebUI
Owner: steve...@chromium.org
Status: Assigned (was: Available)
Labels: -Sheriff-Chromium
I haven't seen any further flakes, so I'm going to leave this open but take it out of the sheriff queue for now.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71abd0a7a977201c05fda3615f02a3404bac92b9

commit 71abd0a7a977201c05fda3615f02a3404bac92b9
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jun 08 02:00:15 2017

MD Settings: disable flaky CrSettingsInternetPageTest on CrOS debug

TBR=stevenjb@chromium.org
BUG= 729607 

Change-Id: Id07a3a125241d7019f502ee1b5ab99b0ce866e68
Reviewed-on: https://chromium-review.googlesource.com/527668
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477860}
[modify] https://crrev.com/71abd0a7a977201c05fda3615f02a3404bac92b9/chrome/test/data/webui/settings/cr_settings_browsertest.js

Labels: M-65 OS-Chrome
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3315f3631e7004f47c7e496371ffb0c04f7b795

commit c3315f3631e7004f47c7e496371ffb0c04f7b795
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Dec 12 18:03:28 2017

CrSettingsBrowsertest: De-flake CrOs subpage tests

* CrSettingsInternetPageTest added flushAsync() after it was disabled
  but it was never re-enabled; it should be stable now.
* CrSettingsAndroidAppsPageTest was failing for similar reasons on
  Mash and appears to be stable with a similar fix.
* CrSettingsBluetoothPageTest follows a similar pattern so a similar
  fix was applied to prevent any potential unreported flake.

Bug:  678687 , 729607 
Change-Id: I0f1fce0a81c5b6a9c7a9f390a6761a9d341cd1f7
Reviewed-on: https://chromium-review.googlesource.com/821357
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523475}
[modify] https://crrev.com/c3315f3631e7004f47c7e496371ffb0c04f7b795/chrome/test/data/webui/settings/android_apps_page_test.js
[modify] https://crrev.com/c3315f3631e7004f47c7e496371ffb0c04f7b795/chrome/test/data/webui/settings/bluetooth_page_tests.js
[modify] https://crrev.com/c3315f3631e7004f47c7e496371ffb0c04f7b795/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/c3315f3631e7004f47c7e496371ffb0c04f7b795/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter

Status: Fixed (was: Started)

Sign in to add a comment